Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 27 Feb 2020 10:42:14 +0000
From:   Qais Yousef <qais.yousef@arm.com>
To:     Valentin Schneider <valentin.schneider@arm.com>
Cc:     linux-kernel@vger.kernel.org, mingo@kernel.org,
        peterz@infradead.org, vincent.guittot@linaro.org,
        Dietmar.Eggemann@arm.com, patrick.bellasi@matbug.net,
        t1zhou@aliyun.com
Subject: Re: [PATCH v2 0/3] sched/debug: Add uclamp values to procfs
Message-ID: <20200227104213.4viewcfy5povydpj@e107158-lin.cambridge.arm.com>
References: <20200226124543.31986-1-valentin.schneider@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200226124543.31986-1-valentin.schneider@arm.com>
User-Agent: NeoMutt/20171215
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 02/26/20 12:45, Valentin Schneider wrote:
> Hi,
> 
> This is a small debug series I've been sitting on. It's been helpful in
> testing and reviewing some uclamp stuff, for instance the issue Qais fixed
> at [1] was really easy to observe with those debug prints.
> 
> [1]: https://lore.kernel.org/lkml/20191224115405.30622-1-qais.yousef@arm.com/

That would be handy indeed. And nice cleanup along the way.

For the series

Reviewed-by: Qais Yousef <qais.yousef@arm.com>

Cheers

--
Qais Yousef

> 
> Cheers,
> Valentin
> 
> Revisions
> =========
> 
> v1 -> v2
> --------
> o Added parentheses for the casting part of the macros (Tao)
> 
> Valentin Schneider (3):
>   sched/debug: Remove redundant macro define
>   sched/debug: Bunch up printing formats in common macros
>   sched/debug: Add task uclamp values to SCHED_DEBUG procfs
> 
>  kernel/sched/debug.c | 44 ++++++++++++++++++--------------------------
>  1 file changed, 18 insertions(+), 26 deletions(-)
> 
> --
> 2.24.0
>