Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 27 Feb 2020 12:56:14 +0100
From:   Andreas Kemnade <andreas@kemnade.info>
To:     Lee Jones <lee.jones@linaro.org>
Cc:     knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
        b.galvani@gmail.com, linus.walleij@linaro.org,
        linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
        phh@phh.me, stefan@agner.ch, letux-kernel@openphoenux.org,
        jic23@kernel.org
Subject: Re: [PATCH v5 1/2] mfd: rn5t618: add ADC subdevice for RC5T619
Message-ID: <20200227125544.510a10f7@kemnade.info>
In-Reply-To: <20200227094006.GV3494@dell>
References: <20200223131638.12130-1-andreas@kemnade.info>
        <20200223131638.12130-2-andreas@kemnade.info>
        <20200226154055.GQ3494@dell>
        <20200226174914.047667d5@kemnade.info>
        <20200226174640.GR3494@dell>
        <20200226190028.0de5c095@kemnade.info>
        <20200227094006.GV3494@dell>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 boundary="Sig_/yc8PI1h7Z/61=XnB+ULCMgZ"; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_/yc8PI1h7Z/61=XnB+ULCMgZ
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Thu, 27 Feb 2020 09:40:06 +0000
Lee Jones <lee.jones@linaro.org> wrote:

> On Wed, 26 Feb 2020, Andreas Kemnade wrote:
>=20
> > On Wed, 26 Feb 2020 17:46:40 +0000
> > Lee Jones <lee.jones@linaro.org> wrote:
> >  =20
> > > On Wed, 26 Feb 2020, Andreas Kemnade wrote:
> > >  =20
> > > > On Wed, 26 Feb 2020 15:40:55 +0000
> > > > Lee Jones <lee.jones@linaro.org> wrote:
> > > >    =20
> > > > > On Sun, 23 Feb 2020, Andreas Kemnade wrote:
> > > > >    =20
> > > > > > This adds a subdevice for the ADC in the RC5T619
> > > > > >=20
> > > > > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > > > > > ---
> > > > > > depends on:
> > > > > > https://lore.kernel.org/lkml/20191220122416.31881-1-andreas@kem=
nade.info/
> > > > > >=20
> > > > > > Changes in v3:
> > > > > > re-added it to the series because of
> > > > > > "Oh, it looks like there was a conflict.  Could you collect any=
 Acks
> > > > > > (including mine) rebase and resend please?"     =20
> > > > >=20
> > > > > Looks like there is still a conflict.  Sure, it's not a complicat=
ed
> > > > > fix, but that's beside the point.  What tree is this set based on?
> > > > >    =20
> > > > It must be applied on top of my rc5t619 rtc series here:
> > > > https://lore.kernel.org/lkml/20191220122416.31881-1-andreas@kemnade=
.info/
> > > >=20
> > > > I expected it to make it into 5.6 and when I first sent the RTC ser=
ies
> > > >  (in October) I had no idea when I will continue with other stuff.
> > > >=20
> > > > That is why I sent this ADC series separately, also to give the IIO
> > > > maintainer plenty of time to review.    =20
> > >=20
> > > If a patch-set can or should be applied on its own, you should send it
> > > based on an upstream commit, or else things like this happen.
> > >  =20
> > It cannot without breaking bisectability. The RTC series adds IRQ suppo=
rt in
> > the PMIC which is used here. =20
>=20
> Then Kconfig should reflect that.
>=20
> Or, if that's not possible, then you should not break-up and submit
> sets which cannot be applied by themselves.  Either submit the whole
> set together, or submit them piece by piece, not submitting the next
> part until it's predecessor has been applied.
>=20
I will send you a complete series containing both RTC and ADC support.
Then you can decide wether you
1. apply the whole series (both things)
2. apply RTC for 5.7 and this series later
3. ignore them  (not my preferred choice ;-) ).

BTW: The way I did was based on the following note in=20
Documentation/process/submitting-patches.rst

"If one patch depends on another patch in order for a change to be
complete, that is OK.  Simply note **"this patch depends on patch X"**
in your patch description."


Regards,
Andreas

--Sig_/yc8PI1h7Z/61=XnB+ULCMgZ
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEPIWxmAFyOaBcwCpFl4jFM1s/ye8FAl5Xrl4ACgkQl4jFM1s/
ye+f3A//WjqnfE2Ok7w+zmm/hu9FQonJQnp77QUGgDJxnG9IE2f0pdcQO+PZwLTF
bqP3/lyDiFhCUI425h2UHNm3YB2CxnNDUqcqzmvTKRQVqlNIgInBySfX8VGpLT/J
AKEV7bwkfpS7J9SxIEV+Gj0ljjkRktc7kFufkXjeMoGaVcflXk981CsfNFQJV5QQ
ZLx/DDrosKKOB7CzEo5brffI1o7dD64n3qTWlXgBaU56uO/DKQGwqAE1Vfa+V7Jb
l6IeBJ6cp03ywEHtXdGxSBkmrOxUx39fdWbCnCc+KY9LGzgXf72MSmKfMHJlADmc
DCg/ZQ0yfpAt+a8LlCTCuhmQ8w3XpapNrDItS8Y0oVp3hqwUt2ttDyKq1Hl4ytqV
hmf9fz1VAKHnccQ+87T/qYgVuu5HETorKeF9L+EJWYC7Y2yWB4vhPvg7nhOp57nI
VGV8Vbcz9pdHVWZVTPB+N0D2J1lFZeEKMCNf+GwrEinbLEru5Nq6iybyA1/yHLCA
FHnAa/sHZnelLqgvpKU09VOMm1T1J+A40TKAENigHCmgkv4TdA1SvgIk++2+qYEY
dZr/qGv3/9hMpqVBbguifvM1onF8KiyIIh5DpRhFoVLqfrdQ6VzeC8iP/M2rU+RZ
xi4zqSmPUfai4QpgIHlnwhs7nJJ8GpUZlwPbrFxKlOao3VNLGFo=
=EWRZ
-----END PGP SIGNATURE-----

--Sig_/yc8PI1h7Z/61=XnB+ULCMgZ--