Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp1043116ybf; Thu, 27 Feb 2020 04:05:46 -0800 (PST) X-Google-Smtp-Source: APXvYqz4hE2PFjOsDDrAN2aoIZjUK2v1Dgr0d261Px+yc4XCYS3gJyaghcCse9lnu9Ilz2nD5Lqn X-Received: by 2002:aca:2312:: with SMTP id e18mr3139670oie.34.1582805146264; Thu, 27 Feb 2020 04:05:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582805146; cv=none; d=google.com; s=arc-20160816; b=T71TULhd9wmWGWgfwDrjmNH4Htp2v/M9tIyBRstQOxfwn4OrDxc8gSFID6DRJLXoQy KKRGsjnqkNzBpYhHv4HmR2qTVqjLeGMnAyC+x61kZSQUiimEc7OaIqiCcmKM6emXjBWw iaHymcWwVAkwR4C9gSJZvhQQyZhf5CzsxwlxafrTYkCFqWunHBKt8tgxLIZsUmh9C8Zw KcyH+r/fmj/e0JPTBlNAnEkG+17M4lbCfuJQXwxteNQuBRtXsDwEMcywEZsSegLetreH FYz7yEghVrNNGvlXJYg7h35ANNzGVPcj3i3aqGAWaJUyNt7J76cyRfIR53neLzOotobI eSgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=LFKRLVR3En2qAyWAFyjSG1BfnWs6i3rEBFI+3Z3Uh14=; b=LZ9oiRcfEXjtPlWlGEYPh7Zx4TdP6HVwAkdBvz461VoXjLuUrUCgHYnkP/zAEaG4Gr 1MBsl6foPKKhUfsErYYq5DyGF1BIRxE6TBDWsS2qkPjt9Sa2MFng2HLGpj9PQGom2aOA jkAX1XOzxzIQ6bovbcKVlAMqp54lMKO1M+PtTMiAs6dFqlVBnvIt80/jNzqssH1Du+nU RngTGvUe2JV1TA9Z8UJYUtieM6NJ97opquZZf2Fi3msSQmO5icANq0pgfTnd27s9SIZl xKiFqNASogyI1EDa8xsLfxUiW1MD2Q6FbGEE5qeqcDMOKRbw8SIzt4PCiTa83kB3wm4e DkKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vdInBT6S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a6si1202613oia.33.2020.02.27.04.05.34; Thu, 27 Feb 2020 04:05:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vdInBT6S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729059AbgB0MC7 (ORCPT + 99 others); Thu, 27 Feb 2020 07:02:59 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:51688 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728882AbgB0MC7 (ORCPT ); Thu, 27 Feb 2020 07:02:59 -0500 Received: by mail-wm1-f68.google.com with SMTP id t23so3259513wmi.1 for ; Thu, 27 Feb 2020 04:02:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LFKRLVR3En2qAyWAFyjSG1BfnWs6i3rEBFI+3Z3Uh14=; b=vdInBT6S+Cz7AIQeFEX/HBaX1a273oG5ysqqQNm6tMxsB11TcE6gB7Qk7dSWeJk+dR +UdWmHGvW/PT2YtbbK/p6BxPnkCfSkaXP60ZOmuwNesmvONeuAn/hneMI1pfBdhL0pBW TtEWwU4gp2vmK/cWYrqWWyGPF0Bk8fmwDpyAWbZly5vhqdXPVAXFR6VGTaNFFo+5S2gh DEtiqgzQUC41JK3cQ1LVa+siCwhhbGyvkPuOCbGFoRfVLZtYoc69I/8Ch6159+ee21E3 2ZPsrUKSFCC2he7B22o8IFsQGT1CcU1NSHwhjNO7XgcfQnaWrOutEdrBvrc0/rf1GOQx +chA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LFKRLVR3En2qAyWAFyjSG1BfnWs6i3rEBFI+3Z3Uh14=; b=WzQZAWr5IJ6SWKvEQry/uOhKsKkSVoVVHnhHCB619l2ylKMjIpTmI1+jJjKIrqxFRc Rp7uAS/WaVGjlPcFCtOgjLGdMd41JSzqYs15LBL+e2h5xs5IkXzTxcHk2W9XA9p+L5BA /rCcDXDO3hlwiTXoXjmw74ZdYu5jx7lw9dArgARSUDFo7T+ShyHOYhpAqIgRQgCY5s4z vbc23iLHciCITvYd+ThcpqKwjs4dKV8a0+29gsQhbF1Y9+wWTxtoz7AyA8cLV2TQTV3H Ut2N2ofsUX2mv7FCflG51ABh5cM3jK5ptqA5Rzy0uwVqEZUtZQ74IYrJV89saDzEv7Ux 1F1Q== X-Gm-Message-State: APjAAAV/2QRXKliTS8lKJEfB/HpmDQIiMi1EKOsiGJjmh1GQ30qCzZgt UR1WSte3U3JrAqmNgbLqDlM= X-Received: by 2002:a1c:a443:: with SMTP id n64mr4733588wme.141.1582804977474; Thu, 27 Feb 2020 04:02:57 -0800 (PST) Received: from wambui.zuku.co.ke ([197.237.61.225]) by smtp.googlemail.com with ESMTPSA id t10sm7655017wru.59.2020.02.27.04.02.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 04:02:56 -0800 (PST) From: Wambui Karuga To: daniel@ffwll.ch, airlied@linux.ie, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org Subject: [PATCH 04/21] drm/vram-helper: make drm_vram_mm_debugfs_init() return void Date: Thu, 27 Feb 2020 15:02:15 +0300 Message-Id: <20200227120232.19413-5-wambui.karugax@gmail.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200227120232.19413-1-wambui.karugax@gmail.com> References: <20200227120232.19413-1-wambui.karugax@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() never fails and should return void. Therefore, remove its use as the return value of drm_vram_mm_debugfs_init(), and have the function declared as void instead. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/drm_gem_vram_helper.c | 14 ++++---------- include/drm/drm_gem_vram_helper.h | 2 +- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c index 92a11bb42365..76506bedac11 100644 --- a/drivers/gpu/drm/drm_gem_vram_helper.c +++ b/drivers/gpu/drm/drm_gem_vram_helper.c @@ -1042,20 +1042,14 @@ static const struct drm_info_list drm_vram_mm_debugfs_list[] = { * * @minor: drm minor device. * - * Returns: - * 0 on success, or - * a negative error code otherwise. */ -int drm_vram_mm_debugfs_init(struct drm_minor *minor) +void drm_vram_mm_debugfs_init(struct drm_minor *minor) { - int ret = 0; - #if defined(CONFIG_DEBUG_FS) - ret = drm_debugfs_create_files(drm_vram_mm_debugfs_list, - ARRAY_SIZE(drm_vram_mm_debugfs_list), - minor->debugfs_root, minor); + drm_debugfs_create_files(drm_vram_mm_debugfs_list, + ARRAY_SIZE(drm_vram_mm_debugfs_list), + minor->debugfs_root, minor); #endif - return ret; } EXPORT_SYMBOL(drm_vram_mm_debugfs_init); diff --git a/include/drm/drm_gem_vram_helper.h b/include/drm/drm_gem_vram_helper.h index 0f6e47213d8d..b63bcd1b996d 100644 --- a/include/drm/drm_gem_vram_helper.h +++ b/include/drm/drm_gem_vram_helper.h @@ -196,7 +196,7 @@ static inline struct drm_vram_mm *drm_vram_mm_of_bdev( return container_of(bdev, struct drm_vram_mm, bdev); } -int drm_vram_mm_debugfs_init(struct drm_minor *minor); +void drm_vram_mm_debugfs_init(struct drm_minor *minor); /* * Helpers for integration with struct drm_device -- 2.25.0