Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Wambui Karuga <wambui.karugax@gmail.com>
Date:   Thu, 27 Feb 2020 15:23:31 +0300 (EAT)
To:     Jyri Sarha <jsarha@ti.com>
cc:     Wambui Karuga <wambui.karugax@gmail.com>, daniel@ffwll.ch,
        airlied@linux.ie, Tomi Valkeinen <tomi.valkeinen@ti.com>,
        linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
        dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 17/21] drm/tilcdc: remove check for return value of
 debugfs functions.
In-Reply-To: <614d42f2-881e-6e4e-f3c4-c247a86d9262@ti.com>
Message-ID: <alpine.LNX.2.21.99999.375.2002271516120.19554@wambui>
References: <20200227120232.19413-1-wambui.karugax@gmail.com> <20200227120232.19413-18-wambui.karugax@gmail.com> <614d42f2-881e-6e4e-f3c4-c247a86d9262@ti.com>
User-Agent: Alpine 2.21.99999 (LNX 375 2019-10-29)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On Thu, 27 Feb 2020, Jyri Sarha wrote:

> On 27/02/2020 14:02, Wambui Karuga wrote:
>> Since 987d65d01356 (drm: debugfs: make
>> drm_debugfs_create_files() never fail), drm_debugfs_create_files() never
>> fails. Therefore, remove the check and error handling of the return
>> value of drm_debugfs_create_files() as it is not needed in
>> tilcdc_debugfs_init().
>>
>> Also remove local variables that are not used after the changes, and
>> declare tilcdc_debugfs_init() as void.
>>
>> Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
>
>
> Ok, so this is a part of a bigger series.
>
Yes, this was converted to a series after initial feedback. Thanks for 
your review

wambui karuga.
> Acked-by: Jyri Sarha <jsarha@ti.com>
>
> I assume the series will be merged as one without my involvement. Please
> let me know if that is not the case.
>
> BR,
> Jyri
>
>> ---
>>  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 17 ++++-------------
>>  1 file changed, 4 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
>> index 0791a0200cc3..78c1877d13a8 100644
>> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
>> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
>> @@ -478,26 +478,17 @@ static struct drm_info_list tilcdc_debugfs_list[] = {
>>  		{ "mm",   tilcdc_mm_show,   0 },
>>  };
>>
>> -static int tilcdc_debugfs_init(struct drm_minor *minor)
>> +static void tilcdc_debugfs_init(struct drm_minor *minor)
>>  {
>> -	struct drm_device *dev = minor->dev;
>>  	struct tilcdc_module *mod;
>> -	int ret;
>>
>> -	ret = drm_debugfs_create_files(tilcdc_debugfs_list,
>> -			ARRAY_SIZE(tilcdc_debugfs_list),
>> -			minor->debugfs_root, minor);
>> +	drm_debugfs_create_files(tilcdc_debugfs_list,
>> +				 ARRAY_SIZE(tilcdc_debugfs_list),
>> +				 minor->debugfs_root, minor);
>>
>>  	list_for_each_entry(mod, &module_list, list)
>>  		if (mod->funcs->debugfs_init)
>>  			mod->funcs->debugfs_init(mod, minor);
>> -
>> -	if (ret) {
>> -		dev_err(dev->dev, "could not install tilcdc_debugfs_list\n");
>> -		return ret;
>> -	}
>> -
>> -	return ret;
>>  }
>>  #endif
>>
>>
>
>
> -- 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>