Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp1116971ybf; Thu, 27 Feb 2020 05:21:18 -0800 (PST) X-Google-Smtp-Source: APXvYqwl4bHMo/Vm7Dtam3YfU8YJPn5kiB+t//OTN/WoospFdLt0V4E7ayTuWzcQzVtC0kyNIQzy X-Received: by 2002:a9d:12a8:: with SMTP id g37mr3325705otg.261.1582809677957; Thu, 27 Feb 2020 05:21:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582809677; cv=none; d=google.com; s=arc-20160816; b=wvBFYlao8Z3t0IcBXRCxrLq3SG11FnwlsdWz2r3O0CZaDO5wCDFRvY385tg8tzkmC6 kbpHZoelrNpbujagVYLdQRjdke7mgJ9b0ftT1xh3gRVg5CjbF4dvWx1FF4GEX6Y3Q/wY rihK3WCztHtO8W0/nEM2j8Sy0sJuOxfpg1vAtJHNJNX9An3IIY6p59iypPCBjP2defq0 cZr8jVM04W0YqYVLO5Q/erlccxdGqfbzKwrIzylX01vJkDA4px8v+ODK/O78DTGpjzMq V5hI/CZ3GDtGLEKgRjJtg4mwrRoPk/neR0f1uBfZUv/aTU+Tx58XkGQz9eg80ZJg9Vff W8Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject; bh=21YdGaaeHlOwVtIIrUR9WJQCzIkXvV6IX+FZ9QDti9Y=; b=mxBrT1Vpnq+GI1rw5vJSNM/aCW0T/kAmFNMd76m/lqE9vi03C3B+cLn6QBAMpNQ0J7 MMhundnG3IVjjwDGcX8ehpiRECMBn27AKxwZk1FK+eoiqy/j5NBvIcCytfEEyQyMi9/G BUJG6rjenj3cKeHaFE/sptdoGGvHu4PSverY5kTqCKboXSbS8cc1u2tUYGKHtnTeaQV3 i5vl9ESyLiK+qtMJoldFtmXGtgWFkxJ53iRQikH+LN7mJr/I1kgpJ3rWbIXxDpa7w3i8 yCpbCdLLx3Uvnn1cz5m0FJj9+inNCGW0w52if1Y9zchBkEA5oquMqVxs2VhnItOUbUXk pwCw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o18si1406261oic.18.2020.02.27.05.21.05; Thu, 27 Feb 2020 05:21:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729167AbgB0NTx (ORCPT + 99 others); Thu, 27 Feb 2020 08:19:53 -0500 Received: from mga07.intel.com ([134.134.136.100]:50317 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729088AbgB0NTx (ORCPT ); Thu, 27 Feb 2020 08:19:53 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2020 05:19:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,492,1574150400"; d="scan'208";a="231836526" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.167]) ([10.237.72.167]) by orsmga008.jf.intel.com with ESMTP; 27 Feb 2020 05:19:50 -0800 Subject: Re: [PATCH] mmc: host: sdhci-sprd: Set the missing MMC_CAP_WAIT_WHILE_BUSY flag To: Baolin Wang , ulf.hansson@linaro.org Cc: orsonzhai@gmail.com, zhang.lyra@gmail.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org References: <96f16647f6a6e8cb058c44e46c61b122df027059.1582535202.git.baolin.wang7@gmail.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Thu, 27 Feb 2020 15:19:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <96f16647f6a6e8cb058c44e46c61b122df027059.1582535202.git.baolin.wang7@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/02/20 11:08 am, Baolin Wang wrote: > The Spreadtrum host controller supports HW busy detection for I/O > operations, which means when the host gets a transfer complete event, > that always indicates the busy signal is released. Thus we can set > the MMC_CAP_WAIT_WHILE_BUSY flag to remove some redundant software > busy polling. > > Signed-off-by: Baolin Wang Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-sprd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c > index d346223..2ab42c5 100644 > --- a/drivers/mmc/host/sdhci-sprd.c > +++ b/drivers/mmc/host/sdhci-sprd.c > @@ -556,7 +556,7 @@ static int sdhci_sprd_probe(struct platform_device *pdev) > sdhci_sprd_voltage_switch; > > host->mmc->caps = MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED | > - MMC_CAP_ERASE | MMC_CAP_CMD23; > + MMC_CAP_ERASE | MMC_CAP_CMD23 | MMC_CAP_WAIT_WHILE_BUSY; > ret = mmc_of_parse(host->mmc); > if (ret) > goto pltfm_free; >