Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp1160151ybf; Thu, 27 Feb 2020 06:07:31 -0800 (PST) X-Google-Smtp-Source: APXvYqyca/REwm8BXZ5kjUuIAX9ZsVtJJdhNHHaVhWcZdU7jmD3iPKZT+x6caORZSdKRL0SKoqDn X-Received: by 2002:a54:440e:: with SMTP id k14mr3274618oiw.160.1582812451699; Thu, 27 Feb 2020 06:07:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582812451; cv=none; d=google.com; s=arc-20160816; b=BQZjVDRZPrALDm1JjxSW0fvE/J2yldayu+1OYiLpSJKAKKauFYk+pvNU1R4jOeXcg9 YnG9lDByKteboVcMvh4oebJYF31XRH9J5LxNHn5SmHctsqf5NEfajToJD3LD6CyG7dHX CZOh0DyWpnmKsWuXsI1d5Qfsayi97ZqSE3IhQE/lNneJrlyhc7qWPOUgCFzUleNi1Km3 ZrQLphJ/5oKpxYRF1UfrBC3RNBftfiATVxdh8zBhbeC5Sb5oxLBTSHMO+GqyDbywc4qP mcfmu/spigiHz/UhVUtOZ6tmzGihhWzHN5DJcieU6hn7gvy2OiM+NDOip2UoUbkL7ZQT x4zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=f5TntJHGki6J9uPL9933iuwwC0C+adPnUsQuXnqrBFs=; b=hlF1/PcQmjsiaSv6YVIZkiNr+oyuW21CTI543ufRVc22KVN7+zsriu70S7vsgqVD8y 6ENyUm9mUa5r6/VlZAZ/mpyKhV+nLoy56fmot7E3gsUxMlmipgs2MywUQ6Ye+1PcChFl rr6bVhyxyt69onWWfZKis8MLV6/sxU+LkjPCjf7wxUHc05Y9N9iXXISIgjm+pxgB+Vrk /8df7T74ALaN2ToDuw0jcVbnCt7aP8NixstnvzPvwqQe+YmAah8oRBd9QW2Nje4FseXf gcUjOg25dnn6CQ48qY03AKso5KWhAfiFJc9wO+efTOZSb2EMpmw6wx2U27QDAfxahxFc W+dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=J6Ml0PMu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h9si1589981oti.155.2020.02.27.06.07.10; Thu, 27 Feb 2020 06:07:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=J6Ml0PMu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387997AbgB0OG4 (ORCPT + 99 others); Thu, 27 Feb 2020 09:06:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:44122 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733251AbgB0OGu (ORCPT ); Thu, 27 Feb 2020 09:06:50 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3601620801; Thu, 27 Feb 2020 14:06:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582812409; bh=SG+w3XEZEe1qhjFJHmDkXqxudXX4yoxpPZ91qTpBJyo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J6Ml0PMuyIHPgMzS6n29aeaZdxhdx/CIzG/Ayh59spKAcCueOZqMD6CSAXBM7vz+k NYlVgWKqxT7PbrzrqxzcJRJ8auzKv9ZYaobwWepi4y/7fWuP9zcZ/FnSEm6CqnVvJ1 Rzwy2qWkXNkp5XoHYy8cFVinDlMI618VNs8XNNXQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jan Kara , Theodore Tso , stable@kernel.org Subject: [PATCH 4.19 68/97] ext4: fix mount failure with quota configured as module Date: Thu, 27 Feb 2020 14:37:16 +0100 Message-Id: <20200227132225.574960751@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200227132214.553656188@linuxfoundation.org> References: <20200227132214.553656188@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jan Kara commit 9db176bceb5c5df4990486709da386edadc6bd1d upstream. When CONFIG_QFMT_V2 is configured as a module, the test in ext4_feature_set_ok() fails and so mount of filesystems with quota or project features fails. Fix the test to use IS_ENABLED macro which works properly even for modules. Link: https://lore.kernel.org/r/20200221100835.9332-1-jack@suse.cz Fixes: d65d87a07476 ("ext4: improve explanation of a mount failure caused by a misconfigured kernel") Signed-off-by: Jan Kara Signed-off-by: Theodore Ts'o Cc: stable@kernel.org Signed-off-by: Greg Kroah-Hartman --- fs/ext4/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -2948,7 +2948,7 @@ static int ext4_feature_set_ok(struct su return 0; } -#if !defined(CONFIG_QUOTA) || !defined(CONFIG_QFMT_V2) +#if !IS_ENABLED(CONFIG_QUOTA) || !IS_ENABLED(CONFIG_QFMT_V2) if (!readonly && (ext4_has_feature_quota(sb) || ext4_has_feature_project(sb))) { ext4_msg(sb, KERN_ERR,