Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp1160614ybf; Thu, 27 Feb 2020 06:07:56 -0800 (PST) X-Google-Smtp-Source: APXvYqz/D+FnXSe7IN5Kh53zAEVmn3Ea/g81HX5kSp5SePRfsLfIvBfDP472G/x09B1Xhqn5OJvj X-Received: by 2002:a9d:5d09:: with SMTP id b9mr3416231oti.207.1582812476613; Thu, 27 Feb 2020 06:07:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582812476; cv=none; d=google.com; s=arc-20160816; b=G2GMlV1P3o+cRkzaA3JkiMaY/xwjpViEh8XcWjjlK5tgDpAJnjIQu5OZ6mIA9LKdDJ 1PgyZTVg3v1Kgpyp+lA+03dmk6krDcWFYuu9NElFwijUgaR4PYjIqUzSBypEYNn+lxze PzcENy7w7IzF1gpQxkyhDQlnV59okcyqaK9NSdejPLnLumjr5qhe69z5e3z5VkcQecoe XcXMHkGisvp3wh/ru5l8eSZXeNfi5W3kUsk1DT6PxvXu/kMrI9+4g8GBMe5Ul9giso85 20kORVskvkaOesAyToQNQWXpxCx4Hd1El2Fpqq6Lqfmw71Xvm6paStHhDT+LK3HPNOi4 2KVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=zpmWMCvI2lNKrbWXMvn1oSfG/VXo7nzEuLdCdn3YYDs=; b=aYZart7780Uxd86TqL4k1KfyotZ60IUXgH67NlE7Ft0IChW0sxJD4ZE3prm22xdk6R hnYZ6NYw0OeOVm98tIGlGxg+fvP2H4X999/3SN7viMYbPfKPlUDzNBpvjVyAItTYhlX1 KegJ1Gdvwn/3BMOZMDfFJ83lGq8ORCuU8lj9J0e2Iv5LsDQFb141GI1c5Ct3KMH05G5g 5VC2lUQec5AtaqkQspTrG5fNnjjO/RrclpXQf7QED6/wFAceSq8JbObT/hC4ZfQAQr0z yQt+4kw/4LWf0MuRyKCbZzf6vBL7KFu3ZjmmZijE63fLGSF4VDmHfujjkWAZNX8vxCnC 6HdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vW2yornH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l21si1389762oic.126.2020.02.27.06.07.18; Thu, 27 Feb 2020 06:07:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vW2yornH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387721AbgB0OFY (ORCPT + 99 others); Thu, 27 Feb 2020 09:05:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:41914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387734AbgB0OFR (ORCPT ); Thu, 27 Feb 2020 09:05:17 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B9E020801; Thu, 27 Feb 2020 14:05:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582812316; bh=U0GxQ/StVdrq3IAdMSnRpyea2jabzGv+n2eoSD3uqs8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vW2yornHtMocrqlpwIhy3zVM+1emqbnZ+jPNSrAqcQ1GeM1lNffDRvuU/yjesSS+c o9EApER1NC5tXP1wFR0WN6qOSRylgpMY0sYk+ctm+3qxRWX/hQtI/7AilbZ7Q0RIxv yfPIjxYcP6y/faI1Wmq4P0EdjlXpwGzRvUKLBb7I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Biggers , Theodore Tso , Jan Kara , stable@kernel.org Subject: [PATCH 4.19 69/97] ext4: rename s_journal_flag_rwsem to s_writepages_rwsem Date: Thu, 27 Feb 2020 14:37:17 +0100 Message-Id: <20200227132225.748009552@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200227132214.553656188@linuxfoundation.org> References: <20200227132214.553656188@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Biggers commit bbd55937de8f2754adc5792b0f8e5ff7d9c0420e upstream. In preparation for making s_journal_flag_rwsem synchronize ext4_writepages() with changes to both the EXTENTS and JOURNAL_DATA flags (rather than just JOURNAL_DATA as it does currently), rename it to s_writepages_rwsem. Link: https://lore.kernel.org/r/20200219183047.47417-2-ebiggers@kernel.org Signed-off-by: Eric Biggers Signed-off-by: Theodore Ts'o Reviewed-by: Jan Kara Cc: stable@kernel.org Signed-off-by: Greg Kroah-Hartman --- fs/ext4/ext4.h | 2 +- fs/ext4/inode.c | 14 +++++++------- fs/ext4/super.c | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h @@ -1521,7 +1521,7 @@ struct ext4_sb_info { struct ratelimit_state s_msg_ratelimit_state; /* Barrier between changing inodes' journal flags and writepages ops. */ - struct percpu_rw_semaphore s_journal_flag_rwsem; + struct percpu_rw_semaphore s_writepages_rwsem; struct dax_device *s_daxdev; }; --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -2730,7 +2730,7 @@ static int ext4_writepages(struct addres if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb)))) return -EIO; - percpu_down_read(&sbi->s_journal_flag_rwsem); + percpu_down_read(&sbi->s_writepages_rwsem); trace_ext4_writepages(inode, wbc); /* @@ -2950,7 +2950,7 @@ unplug: out_writepages: trace_ext4_writepages_result(inode, wbc, ret, nr_to_write - wbc->nr_to_write); - percpu_up_read(&sbi->s_journal_flag_rwsem); + percpu_up_read(&sbi->s_writepages_rwsem); return ret; } @@ -2965,13 +2965,13 @@ static int ext4_dax_writepages(struct ad if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb)))) return -EIO; - percpu_down_read(&sbi->s_journal_flag_rwsem); + percpu_down_read(&sbi->s_writepages_rwsem); trace_ext4_writepages(inode, wbc); ret = dax_writeback_mapping_range(mapping, inode->i_sb->s_bdev, wbc); trace_ext4_writepages_result(inode, wbc, ret, nr_to_write - wbc->nr_to_write); - percpu_up_read(&sbi->s_journal_flag_rwsem); + percpu_up_read(&sbi->s_writepages_rwsem); return ret; } @@ -6207,7 +6207,7 @@ int ext4_change_inode_journal_flag(struc } } - percpu_down_write(&sbi->s_journal_flag_rwsem); + percpu_down_write(&sbi->s_writepages_rwsem); jbd2_journal_lock_updates(journal); /* @@ -6224,7 +6224,7 @@ int ext4_change_inode_journal_flag(struc err = jbd2_journal_flush(journal); if (err < 0) { jbd2_journal_unlock_updates(journal); - percpu_up_write(&sbi->s_journal_flag_rwsem); + percpu_up_write(&sbi->s_writepages_rwsem); return err; } ext4_clear_inode_flag(inode, EXT4_INODE_JOURNAL_DATA); @@ -6232,7 +6232,7 @@ int ext4_change_inode_journal_flag(struc ext4_set_aops(inode); jbd2_journal_unlock_updates(journal); - percpu_up_write(&sbi->s_journal_flag_rwsem); + percpu_up_write(&sbi->s_writepages_rwsem); if (val) up_write(&EXT4_I(inode)->i_mmap_sem); --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -1017,7 +1017,7 @@ static void ext4_put_super(struct super_ percpu_counter_destroy(&sbi->s_freeinodes_counter); percpu_counter_destroy(&sbi->s_dirs_counter); percpu_counter_destroy(&sbi->s_dirtyclusters_counter); - percpu_free_rwsem(&sbi->s_journal_flag_rwsem); + percpu_free_rwsem(&sbi->s_writepages_rwsem); #ifdef CONFIG_QUOTA for (i = 0; i < EXT4_MAXQUOTAS; i++) kfree(get_qf_name(sb, sbi, i)); @@ -4495,7 +4495,7 @@ no_journal: err = percpu_counter_init(&sbi->s_dirtyclusters_counter, 0, GFP_KERNEL); if (!err) - err = percpu_init_rwsem(&sbi->s_journal_flag_rwsem); + err = percpu_init_rwsem(&sbi->s_writepages_rwsem); if (err) { ext4_msg(sb, KERN_ERR, "insufficient memory"); @@ -4595,7 +4595,7 @@ failed_mount6: percpu_counter_destroy(&sbi->s_freeinodes_counter); percpu_counter_destroy(&sbi->s_dirs_counter); percpu_counter_destroy(&sbi->s_dirtyclusters_counter); - percpu_free_rwsem(&sbi->s_journal_flag_rwsem); + percpu_free_rwsem(&sbi->s_writepages_rwsem); failed_mount5: ext4_ext_release(sb); ext4_release_system_zone(sb);