Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp1163831ybf; Thu, 27 Feb 2020 06:10:45 -0800 (PST) X-Google-Smtp-Source: APXvYqwGfP2LkKU3XCy70QjQ4GyBqrW/YyYryMzOMoMYoy0CWrZXCZ1Iwa1nXNC/nGZ0f3E85Ilp X-Received: by 2002:a05:6808:251:: with SMTP id m17mr3391664oie.15.1582812645746; Thu, 27 Feb 2020 06:10:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582812645; cv=none; d=google.com; s=arc-20160816; b=COe8gmF5wPVu+XFnZuD4NTdiauxi7HMGzB+3HdpWCvHJjAVzVQUllFmDwbLBAJaH0c y6zwifzHfunOkzNrlE+hJSZC6TRHotcP/85GH+dsJx2tWoVQWpSmLcTlCImcX8r1XBi9 yTbv3aoQs1yDA8oD5pnbdPTdF4x1vUzmAtMGv1dql/IJ1lEJHA61zaEJaAfAzL0jg0uQ Ku4NAIV+b7/G7cQ5Hmo/h9YgfpMRVae/fPOqKDkMjSetv0g3aV28gOYK+d8cvY6Kt0kY i+ojz27SIr2dnMDShVtz3yNkUPVXFOo3eqxTGLtVbBhaWRpBvGUgL3fJ5Gl9IMAeBkjL o7QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+GyBCtBJHJv18UCmKIhLGK/CxW1ndbowZ4TXZUv70Os=; b=kSc09/9ptdcGDwe30oFVm2xFxTjJqDXx6OCEgdsnx7pi1xkiJ80TuldJihp/swmkNs stC3ZClIvZYu4pKWU5n9GuabJvB3LAn4wMZQUb6gHfFDvaAia4OiWOoqubQ26bRFyCUA bKd+YSWuw4LvJEzYxjCv+Pva20o3A3N4Ddd9kEo/7jV5XcooKuumNNkYyhIbKArlHxmo yNgJsn1m2GpWKVIX/+0lOyEbmNBR3iu30Wxmn8FMkonwnsPcXFQaXiKXstnYVdTXLG9n KA7xQpERIQWbSN9D2tuq1af8kUKfh1tgxLiwM8Mm3ED3DpLEZDxSO6YGZhHZqRwq8BNQ IaAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RWpKsnkP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q6si1634558oth.26.2020.02.27.06.10.20; Thu, 27 Feb 2020 06:10:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RWpKsnkP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388514AbgB0OKS (ORCPT + 99 others); Thu, 27 Feb 2020 09:10:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:48394 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388501AbgB0OKO (ORCPT ); Thu, 27 Feb 2020 09:10:14 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6503920801; Thu, 27 Feb 2020 14:10:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582812613; bh=e5ndoiRDxYwRbPxOyEKXWF7FHr5AOsY73wdAskUzJB0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RWpKsnkPf9A4EBl0voxPTdnMHx/YxItTwcJJdfM4gFN3RDd6Jy2LYgv/ZGdQ7i93m 0JtE8oX0HxL0tCSMF80u/67jBGhxEY2cRJH3I4EEipdoTBTo82KMT/SWLio6bdEdpx xNvW/msZ2MwA8YIDhzRDOgxt3E9vgsbAcWPAO3s4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Biggers , Theodore Tso , Jan Kara , stable@kernel.org Subject: [PATCH 5.4 085/135] ext4: rename s_journal_flag_rwsem to s_writepages_rwsem Date: Thu, 27 Feb 2020 14:37:05 +0100 Message-Id: <20200227132242.102651886@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200227132228.710492098@linuxfoundation.org> References: <20200227132228.710492098@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Biggers commit bbd55937de8f2754adc5792b0f8e5ff7d9c0420e upstream. In preparation for making s_journal_flag_rwsem synchronize ext4_writepages() with changes to both the EXTENTS and JOURNAL_DATA flags (rather than just JOURNAL_DATA as it does currently), rename it to s_writepages_rwsem. Link: https://lore.kernel.org/r/20200219183047.47417-2-ebiggers@kernel.org Signed-off-by: Eric Biggers Signed-off-by: Theodore Ts'o Reviewed-by: Jan Kara Cc: stable@kernel.org Signed-off-by: Greg Kroah-Hartman --- fs/ext4/ext4.h | 2 +- fs/ext4/inode.c | 14 +++++++------- fs/ext4/super.c | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h @@ -1549,7 +1549,7 @@ struct ext4_sb_info { struct ratelimit_state s_msg_ratelimit_state; /* Barrier between changing inodes' journal flags and writepages ops. */ - struct percpu_rw_semaphore s_journal_flag_rwsem; + struct percpu_rw_semaphore s_writepages_rwsem; struct dax_device *s_daxdev; }; --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -2734,7 +2734,7 @@ static int ext4_writepages(struct addres if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb)))) return -EIO; - percpu_down_read(&sbi->s_journal_flag_rwsem); + percpu_down_read(&sbi->s_writepages_rwsem); trace_ext4_writepages(inode, wbc); /* @@ -2955,7 +2955,7 @@ unplug: out_writepages: trace_ext4_writepages_result(inode, wbc, ret, nr_to_write - wbc->nr_to_write); - percpu_up_read(&sbi->s_journal_flag_rwsem); + percpu_up_read(&sbi->s_writepages_rwsem); return ret; } @@ -2970,13 +2970,13 @@ static int ext4_dax_writepages(struct ad if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb)))) return -EIO; - percpu_down_read(&sbi->s_journal_flag_rwsem); + percpu_down_read(&sbi->s_writepages_rwsem); trace_ext4_writepages(inode, wbc); ret = dax_writeback_mapping_range(mapping, inode->i_sb->s_bdev, wbc); trace_ext4_writepages_result(inode, wbc, ret, nr_to_write - wbc->nr_to_write); - percpu_up_read(&sbi->s_journal_flag_rwsem); + percpu_up_read(&sbi->s_writepages_rwsem); return ret; } @@ -6185,7 +6185,7 @@ int ext4_change_inode_journal_flag(struc } } - percpu_down_write(&sbi->s_journal_flag_rwsem); + percpu_down_write(&sbi->s_writepages_rwsem); jbd2_journal_lock_updates(journal); /* @@ -6202,7 +6202,7 @@ int ext4_change_inode_journal_flag(struc err = jbd2_journal_flush(journal); if (err < 0) { jbd2_journal_unlock_updates(journal); - percpu_up_write(&sbi->s_journal_flag_rwsem); + percpu_up_write(&sbi->s_writepages_rwsem); return err; } ext4_clear_inode_flag(inode, EXT4_INODE_JOURNAL_DATA); @@ -6210,7 +6210,7 @@ int ext4_change_inode_journal_flag(struc ext4_set_aops(inode); jbd2_journal_unlock_updates(journal); - percpu_up_write(&sbi->s_journal_flag_rwsem); + percpu_up_write(&sbi->s_writepages_rwsem); if (val) up_write(&EXT4_I(inode)->i_mmap_sem); --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -1018,7 +1018,7 @@ static void ext4_put_super(struct super_ percpu_counter_destroy(&sbi->s_freeinodes_counter); percpu_counter_destroy(&sbi->s_dirs_counter); percpu_counter_destroy(&sbi->s_dirtyclusters_counter); - percpu_free_rwsem(&sbi->s_journal_flag_rwsem); + percpu_free_rwsem(&sbi->s_writepages_rwsem); #ifdef CONFIG_QUOTA for (i = 0; i < EXT4_MAXQUOTAS; i++) kfree(get_qf_name(sb, sbi, i)); @@ -4585,7 +4585,7 @@ no_journal: err = percpu_counter_init(&sbi->s_dirtyclusters_counter, 0, GFP_KERNEL); if (!err) - err = percpu_init_rwsem(&sbi->s_journal_flag_rwsem); + err = percpu_init_rwsem(&sbi->s_writepages_rwsem); if (err) { ext4_msg(sb, KERN_ERR, "insufficient memory"); @@ -4685,7 +4685,7 @@ failed_mount6: percpu_counter_destroy(&sbi->s_freeinodes_counter); percpu_counter_destroy(&sbi->s_dirs_counter); percpu_counter_destroy(&sbi->s_dirtyclusters_counter); - percpu_free_rwsem(&sbi->s_journal_flag_rwsem); + percpu_free_rwsem(&sbi->s_writepages_rwsem); failed_mount5: ext4_ext_release(sb); ext4_release_system_zone(sb);