Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp1164924ybf; Thu, 27 Feb 2020 06:11:41 -0800 (PST) X-Google-Smtp-Source: APXvYqzIB7fyLpAPXu4WAo0JlwaDZPwTvS5nZ7Sdpt+53jYaJQG9bnXXwkeyPLTkvt+vUbLYyUvd X-Received: by 2002:aca:d903:: with SMTP id q3mr3454184oig.12.1582812700857; Thu, 27 Feb 2020 06:11:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582812700; cv=none; d=google.com; s=arc-20160816; b=a+YiAJEwWT3yBgp9KlzCq2bELuqsXp0qrFMaFh+StXtMMukuvgUCVoMN1dAk8e7DNL kslzNwUQy2xrXygKpn0pE58NLmUDxlNxAanQxkb0pv3JFt1RZSedOqd6caHedSGfT/PD XSHLhu8hHfuap5cQlopqjac8Stg/Ec45z3S00xKLshE/+P91zS9E4D4SfFGabTX8UJiC Pv6oMH6CcV1BhW3W4VDB72pkHaBaqPZTTxV5+ZSC+8a9CbbW2A7EanaFCb5TWu0c9ITT u5BrpGdSnZJx9hmnUYZtPXucZC2VcGmhIeqwMNhrj+2wLOR8+89ADhf7YSJ0s0v1erTX CxuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=lKcJX3cOd/k4g85XvmWI+e7h+FgZxq9Xgp5vDtfPrcU=; b=F/HLz3ht5vs4GISMXLtRWEDXrrAVEQmOC+2cSQaMtGkUWcUdUM7kxfqi0tMM6ffapv Kc6QSLHbmy3NLm0n7CSjT3xGqxIDQTLiKvHNn6JtotwrXursOgEZVRqdZihcpDgdiF4g Fs+ksRuwjtA7ZkLS3dRCa2V2T+DWNm+UsO3alkuzLbFkCK479bIlmGV9NEelupo5So/3 FfasKZFpH6rwcx1v7/KBaNpkrrATmnU+Y8E12DbpsyRP5BlBB8Lkx6JAM3B+dY8uvG9j jMy4u63D4jkny33HMDi62BjdZgC8UoTzPUUUlLcULsJghzhLq2pvNF+R5QDFxC7noLl7 jFsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ppUlIqdv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l5si1494412otf.37.2020.02.27.06.11.24; Thu, 27 Feb 2020 06:11:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ppUlIqdv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388505AbgB0OKP (ORCPT + 99 others); Thu, 27 Feb 2020 09:10:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:48346 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730787AbgB0OKL (ORCPT ); Thu, 27 Feb 2020 09:10:11 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE3CF20801; Thu, 27 Feb 2020 14:10:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582812611; bh=9wPCMzkHM9+mYWPFSLeEEhGk2FiNuHNNnwHxHh+WAt8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ppUlIqdvU+LD8YZEVdZD4eekQLTvlSwG2enxe/G0K3OSew/yTKGVfLm17KVkb1Vsf N2DcyZnxMsG3jawrn8HCXYd32a7/1G4gEc9vuBwTbmk5fw9Cl15XwphglxalF7UIoA BZOD3p4oeUjX4IL7NUjlTU6eCu0AbiyHN0iRkCeg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jan Kara , Theodore Tso , stable@kernel.org Subject: [PATCH 5.4 084/135] ext4: fix mount failure with quota configured as module Date: Thu, 27 Feb 2020 14:37:04 +0100 Message-Id: <20200227132241.992822466@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200227132228.710492098@linuxfoundation.org> References: <20200227132228.710492098@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jan Kara commit 9db176bceb5c5df4990486709da386edadc6bd1d upstream. When CONFIG_QFMT_V2 is configured as a module, the test in ext4_feature_set_ok() fails and so mount of filesystems with quota or project features fails. Fix the test to use IS_ENABLED macro which works properly even for modules. Link: https://lore.kernel.org/r/20200221100835.9332-1-jack@suse.cz Fixes: d65d87a07476 ("ext4: improve explanation of a mount failure caused by a misconfigured kernel") Signed-off-by: Jan Kara Signed-off-by: Theodore Ts'o Cc: stable@kernel.org Signed-off-by: Greg Kroah-Hartman --- fs/ext4/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -2986,7 +2986,7 @@ static int ext4_feature_set_ok(struct su return 0; } -#if !defined(CONFIG_QUOTA) || !defined(CONFIG_QFMT_V2) +#if !IS_ENABLED(CONFIG_QUOTA) || !IS_ENABLED(CONFIG_QFMT_V2) if (!readonly && (ext4_has_feature_quota(sb) || ext4_has_feature_project(sb))) { ext4_msg(sb, KERN_ERR,