Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp1179356ybf; Thu, 27 Feb 2020 06:24:19 -0800 (PST) X-Google-Smtp-Source: APXvYqyuCG1jyWo32rrULWhwGAmxpSevwjKqHgSs4yNEv2qieCruiOmypPlFd3taBQX9u6gjwQVL X-Received: by 2002:aca:b80a:: with SMTP id i10mr3378228oif.106.1582813459211; Thu, 27 Feb 2020 06:24:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582813459; cv=none; d=google.com; s=arc-20160816; b=yzu+4rwaw5YRf+XKamkRqfYYwMfVnZY6EzF0GSM87MALjkZVxiYsZAjNInuv6xzPen AZsFeM8rDxehOvRUVolf1xZSZ6GGlYk39/OoL90GweQeUi2WoiTFbnHXXQN7aoonPZg5 ibfOxVmAwlo/ehtwpPIQFvi0p9osFMfzPTWRCxELGuVhpkc+Fo4g7GG86QW/CB2JnUtv SUx0hQ+osO7/EksvzLEg65PLEDOlQFvuPiIIyJku0auiyEx3NtmxMA+nAMNcuDZtVm+D TQtpv+W0eWqIjpIe7zdeVmTYEui1oBDVJqClPkdZrBB3YbtUMvcGFlf9/ogsvpG/p1cW JK+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :robot-unsubscribe:robot-id:message-id:mime-version:references :in-reply-to:cc:subject:to:reply-to:from:date; bh=ssCkZiSdy1zPMnFiA6bHl3A/YpTDHhw/Xqo4tb2nVt8=; b=lDNRcTddoR1ZbDOsv3899FErC7chBbN4DEdmm0lrnOF4T+u3v9rPfXic85MfGh2h/V QZEHxfldV93KQ3qhhhzwlPZwWrUABrlD6eDvN65DTGHbZiFGl4FI0WrXTIDKE3/WbpYb Q/4VOf5RNlAUgRoD5a86X0ncErVGHpv4cTtadcIUz+HigH47k758apjh845sjm1HVCZ+ wu2mkcWa/zp+bW4grqBqu0aa8mygC+IeHsie0Q76NvD2w7TNJyJeqh2V9Th+cl1EiAMZ LTGCoCkobX5a7LN2i0sDkRWVmfO0sC1u11rcGxs5QD+McvC+tSD7Fh3maMkrEutDKyQr hh2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l5si1494412otf.37.2020.02.27.06.24.06; Thu, 27 Feb 2020 06:24:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389895AbgB0OWF (ORCPT + 99 others); Thu, 27 Feb 2020 09:22:05 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:34462 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389445AbgB0OQN (ORCPT ); Thu, 27 Feb 2020 09:16:13 -0500 Received: from [5.158.153.53] (helo=tip-bot2.lab.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1j7JxG-0005Bu-PZ; Thu, 27 Feb 2020 15:15:59 +0100 Received: from [127.0.1.1] (localhost [IPv6:::1]) by tip-bot2.lab.linutronix.de (Postfix) with ESMTP id 69E1D1C2170; Thu, 27 Feb 2020 15:15:58 +0100 (CET) Date: Thu, 27 Feb 2020 14:15:58 -0000 From: "tip-bot2 for Thomas Gleixner" Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: x86/entry] x86/traps: Remove pointless irq enable from do_spurious_interrupt_bug() Cc: Thomas Gleixner , Sean Christopherson , Alexandre Chartre , Frederic Weisbecker , Andy Lutomirski , "Peter Zijlstra (Intel)" , x86 , LKML In-Reply-To: <20191023123117.871608831@linutronix.de> References: <20191023123117.871608831@linutronix.de> MIME-Version: 1.0 Message-ID: <158281295805.28353.16374560066347927254.tip-bot2@tip-bot2> X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the x86/entry branch of tip: Commit-ID: e039dd815941e785203142261397da6ec64d20cc Gitweb: https://git.kernel.org/tip/e039dd815941e785203142261397da6ec64d20cc Author: Thomas Gleixner AuthorDate: Tue, 25 Feb 2020 22:36:40 +01:00 Committer: Thomas Gleixner CommitterDate: Thu, 27 Feb 2020 14:48:39 +01:00 x86/traps: Remove pointless irq enable from do_spurious_interrupt_bug() That function returns immediately after conditionally reenabling interrupts which is more than pointless and requires the ASM code to disable interrupts again. Signed-off-by: Thomas Gleixner Reviewed-by: Sean Christopherson Reviewed-by: Alexandre Chartre Reviewed-by: Frederic Weisbecker Reviewed-by: Andy Lutomirski Acked-by: Peter Zijlstra (Intel) Link: https://lore.kernel.org/r/20191023123117.871608831@linutronix.de Link: https://lkml.kernel.org/r/20200225220216.518575042@linutronix.de --- arch/x86/kernel/traps.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index 6ef00eb..474b8cb 100644 --- a/arch/x86/kernel/traps.c +++ b/arch/x86/kernel/traps.c @@ -862,7 +862,6 @@ do_simd_coprocessor_error(struct pt_regs *regs, long error_code) dotraplinkage void do_spurious_interrupt_bug(struct pt_regs *regs, long error_code) { - cond_local_irq_enable(regs); } dotraplinkage void