Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp1182950ybf; Thu, 27 Feb 2020 06:27:30 -0800 (PST) X-Google-Smtp-Source: APXvYqwdg54RE0S+jGJs5mB9GilnaZsbRQqntORryBCy0WBflm/5cyhaRHU+fk7oEt1pmC6WosGC X-Received: by 2002:a9d:46e:: with SMTP id 101mr3566639otc.11.1582813650663; Thu, 27 Feb 2020 06:27:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582813650; cv=none; d=google.com; s=arc-20160816; b=EKVV7/pYMFHpFRWqWbUBy9MIv+tByWrvStangWpNQ1g/zq80cEwgcW0oT/ZbfkdAU4 HJE6J1p7siQIBkGygkUOG8iK3dxTEY/9q2dVaJSQpDXepIwvI+oUE1YUPPTzJBb1AiYS p5EmFVMsyLQmDoFHQN0HKOL8t2z2nyv+ZE3Htg8OrOKCvUC9Y3HL6O3I/q+IfYFETu2R bfCLiOViuGBFZcU55p4SLsoZm/dV+/ugdPUSd1iTgycOqrLGLfzSi5OlvnYVibLBO82j DGoeX1rW8stLEZELXeKGIy7Sw//1raLVBaascnRFSjaGzQosQl0k3y62Tr4MxRQB7OfM WxsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ycQ4OM0GuiKa4B6agMtr6e0DcA3u66okRRNHJak9QaQ=; b=CRJgiVbOEGBxGxnG7BXwSldQ1BbP/CceT3bIvMToxbV6AOSS4UwTEtvRwEQ67S2y2c V3CRXV11hWer4ndp8T2JKjDEb8jL0yRxMhqjDvsUkSCV2+kz/jKLnzjZYZbMLRK68hMG WxWtYtO3cNd75qok0C6CONzgK73rLOof+CJv5p0bSgN0t9FFVvgc3VWIJwPaKqLcxVvH aqip5VZ/JFXJk0f2YWjxteVjYNEOEjOtvdVJT1KmyiM/gF6AH+mPhgytLTVWTFYbxkx7 h7TvchcyDCs+4nguFsWQ14VRiRCJUydYdKCGuf/kvkD6EbTSgj5KGUF+gSVxnZBZXYKb hBdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iOIpUz8y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v25si1298083oiv.144.2020.02.27.06.27.19; Thu, 27 Feb 2020 06:27:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iOIpUz8y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388803AbgB0O0v (ORCPT + 99 others); Thu, 27 Feb 2020 09:26:51 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:35106 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388212AbgB0O0r (ORCPT ); Thu, 27 Feb 2020 09:26:47 -0500 Received: by mail-pl1-f193.google.com with SMTP id g6so1223669plt.2 for ; Thu, 27 Feb 2020 06:26:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ycQ4OM0GuiKa4B6agMtr6e0DcA3u66okRRNHJak9QaQ=; b=iOIpUz8yFMYlcEm1UZYDNFzSJAykarKnN0dZBkN7DkYhUOowyXt7D4TMvTw2xJBRnq +GzAaKP+Tk45ZozBwVSlKcS0zXDyEyp786dqV2wzOsdEM96Lw7SFVDoJmyEWOa6UnHI8 7912HltfPziYci9i1f5q1G0kAO9lOWY4p5SUCOmUFv+RUOIMfWcvfeNf5eIfnxfyo4YA fL17rHV1YKvr8N4y3K8n7Re0ZU1oriE+W4pDB1flp+zLgqx1z3H/bf0UlqPh3i1SE/uQ OPUUPdNZgfyeq9KTx/wySfgA0Nfqqe2cRiRmPur0TB66Xpdsg3G5qha/Kqr1rSDVZSFa 2SDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ycQ4OM0GuiKa4B6agMtr6e0DcA3u66okRRNHJak9QaQ=; b=UpJrP43trXMDefkO2Wb0fxdzMk+e7wiH8qV035Ope3hURDDhTHOP/mrjjI6ChHiZpB hdiUsR2sMeM12pp415oK4pF7ChAEORxlVFszokd9jKoJY5/ortt9Ffa90MtoSdQ40NPC iraKMEHr75g1tJN7SMjPslMHR9RX523QfJ29GXHnBXVygC4xpAcBq8WMuyD4aGs2vzE1 iz3JLU0YdlcD9ZaCjW0Y2kXbWA6hfU9CUbFRljhOt7JoIamNU2lQqrFopv+cx1cm1zbp T+Tfti3k8gYYIdm0tysBY8J3b6WJqYsrTqvQ6FKxKpSuHmnDjHvK8RzLeFfkS3aaRHLV Dpww== X-Gm-Message-State: APjAAAVWu+aKONtieVvfuA/z92i5zfOr1rIx3SKqr0o4TjeHmD9+0sea o5YNu6Qkk3y2uKd2Jq08HVM= X-Received: by 2002:a17:902:7283:: with SMTP id d3mr20329pll.118.1582813606112; Thu, 27 Feb 2020 06:26:46 -0800 (PST) Received: from localhost ([106.51.232.35]) by smtp.gmail.com with ESMTPSA id u1sm7303392pfn.133.2020.02.27.06.26.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Feb 2020 06:26:45 -0800 (PST) Date: Thu, 27 Feb 2020 19:56:43 +0530 From: afzal mohammed To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Juergen Gross , Josh Poimboeuf , Masami Hiramatsu , Peter Zijlstra Subject: Re: [PATCH 14/18] x86: Replace setup_irq() by request_irq() Message-ID: <20200227142643.GA5610@afzalpc> References: <87v9nsmhjj.fsf@nanos.tec.linutronix.de> <20200227113648.GA5760@afzalpc> <87sgiwma3x.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87sgiwma3x.fsf@nanos.tec.linutronix.de> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thomas, On Thu, Feb 27, 2020 at 02:29:54PM +0100, Thomas Gleixner wrote: > Using scripting to find the spots and automatically convert them to > something which is functionally and semantically correct is perfectly > fine. But scripts neither have taste nor common sense. > > So going over a scripted conversion and fixing non-sensical stuff up > manually is a good thing. > The easy route is fine for the initial step. See above. Sure, i will do the changes as per your suggestion. Regards afzal