Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 27 Feb 2020 15:00:04 +0100
From:   Thomas Bogendoerfer <tbogendoerfer@suse.de>
To:     Pavel Machek <pavel@ucw.cz>
Cc:     Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        Dan Murphy <dmurphy@ti.com>, linux-kernel@vger.kernel.org,
        linux-leds@vger.kernel.org
Subject: Re: [PATCH v5] leds: add SGI IP30 led support
Message-Id: <20200227150004.97154811ecbd2f5ccc22fa64@suse.de>
In-Reply-To: <20200226140058.GH4080@duo.ucw.cz>
References: <20200224111733.10320-1-tbogendoerfer@suse.de>
        <20200226140058.GH4080@duo.ucw.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 26 Feb 2020 15:00:58 +0100
Pavel Machek <pavel@ucw.cz> wrote:

> > +	switch (num) {
> > +	case IP30_LED_SYSTEM:
> > +		data->cdev.name = "white:system";
> > +		break;
> > +	case IP30_LED_FAULT:
> > +		data->cdev.name = "red:fault";
> > +		break;
> 
> If the white LED normally serves as power indicator for the system, we
> might want to specify that. Does it?

it could be seen as such, but it will be turned on only after POST has finished
successfull. So it's off if POST failed, which doesn't make it a real power led
IMHO.

Thomas.

-- 
SUSE Software Solutions Germany GmbH
HRB 36809 (AG N?rnberg)
Gesch?ftsf?hrer: Felix Imend?rffer