Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 28 Feb 2020 00:25:53 +0900
From:   Masami Hiramatsu <mhiramat@kernel.org>
To:     Alexandre Ghiti <alex@ghiti.fr>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Sasha Levin <sashal@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: Perf tool regression from 07d369857808
Message-Id: <20200228002553.31b82876b705aaabbd717131@kernel.org>
In-Reply-To: <2bb02f9b-1413-97c3-684b-104a0fab9144@ghiti.fr>
References: <2bb02f9b-1413-97c3-684b-104a0fab9144@ghiti.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Thu, 27 Feb 2020 13:23:19 +0100
Alexandre Ghiti <alex@ghiti.fr> wrote:

> Hi Masami,
> 
> The commit 07d369857808 ("perf probe: Fix wrong address verification) 
> found its way in kernel 4.19.98 (and debian 10) and I observed some 
> regressions when I try to add probes in shared libraries.
> The symptoms are:
> 
> $ perf probe -f --exec=/home/aghiti/lib/libdpuhw.so --add 
> 'log_rank_path=log_rank_path rank path:string'
>    Failed to find symbol at 0x3bf0
>      Error: Failed to add events.

Hm...

> 
> Whereas when I revert this patch, on the same shared library:
> 
> $ perf probe -f --exec=/home/aghiti/lib/libdpuhw.so --add 
> 'log_rank_path=log_rank_path rank path:string'
> Added new event:
>    probe_libdpuhw:log_rank_path_4 (on log_rank_path in 
> /home/aghiti/lib/libdpuhw.so.2020.1.0 with rank path:string)
> 
> You can now use it in all perf tools, such as:
> 
> 	perf record -e probe_libdpuhw:log_rank_path_4 -aR sleep 1
> 
> Actually, I noted that this patch reverts a previous patch that stated 
> that dwfl_module_addrsym could fail on shared libraries 664fee3dc379 
> ("perf probe: Do not use dwfl_module_addrsym if dwarf_diename finds 
> symbol name").

Ah, OK. Hmm, actually, the reason why reverted it was the actuall
address of symbol is unclear if the DIE only has address range.
OK, at first try to find entrypc and if not, try dwlf_module_addrsym().
That will be better idea.

Thank you,


-- 
Masami Hiramatsu <mhiramat@kernel.org>