Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <2d0854b00d7f85e988aff4f8186e8ac5d8a9aff2.1581410798.git.baolin.wang7@gmail.com>
In-Reply-To: <2d0854b00d7f85e988aff4f8186e8ac5d8a9aff2.1581410798.git.baolin.wang7@gmail.com>
From:   Orson Zhai <orsonzhai@gmail.com>
Date:   Fri, 28 Feb 2020 00:06:17 +0800
Message-ID: <CA+H2tpFAZuPSH0EErLt0Lj=TKLVq3XwEox06tbGzFaquSpKa0w@mail.gmail.com>
Subject: Re: [PATCH] power: supply: Allow charger manager can be built as a module
To:     Baolin Wang <baolin.wang7@gmail.com>
Cc:     sre@kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Lyra Zhang <zhang.lyra@gmail.com>,
        kernel-team@android.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Sebastian and other guys here,

On Tue, Feb 11, 2020 at 4:51 PM Baolin Wang <baolin.wang7@gmail.com> wrote:
>
> Allow charger manager can be built as a module like other charger
> drivers.
>
What do you think about this patch?
We want to set charger-manager as module in our project for new Android devices.

-Orson

> Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
> ---
>  drivers/power/supply/Kconfig          |    2 +-
>  include/linux/power/charger-manager.h |    7 +------
>  2 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index 9a5591a..195bc04 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -480,7 +480,7 @@ config CHARGER_GPIO
>           called gpio-charger.
>
>  config CHARGER_MANAGER
> -       bool "Battery charger manager for multiple chargers"
> +       tristate "Battery charger manager for multiple chargers"
>         depends on REGULATOR
>         select EXTCON
>         help
> diff --git a/include/linux/power/charger-manager.h b/include/linux/power/charger-manager.h
> index ad19e68..40493b2 100644
> --- a/include/linux/power/charger-manager.h
> +++ b/include/linux/power/charger-manager.h
> @@ -248,11 +248,6 @@ struct charger_manager {
>         u64 charging_end_time;
>  };
>
> -#ifdef CONFIG_CHARGER_MANAGER
>  extern void cm_notify_event(struct power_supply *psy,
> -                               enum cm_event_types type, char *msg);
> -#else
> -static inline void cm_notify_event(struct power_supply *psy,
> -                               enum cm_event_types type, char *msg) { }
> -#endif
> +                           enum cm_event_types type, char *msg);
>  #endif /* _CHARGER_MANAGER_H */
> --
> 1.7.9.5
>