Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp1299623ybf; Thu, 27 Feb 2020 08:22:05 -0800 (PST) X-Google-Smtp-Source: APXvYqxrdaHMGM0PeuxzzCUshWqxzPL1+y+s316mtIQZUVIQgKu+IHe/uDKDgVs89ZGpDRRSj4FP X-Received: by 2002:aca:2b0a:: with SMTP id i10mr3173715oik.64.1582820525044; Thu, 27 Feb 2020 08:22:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582820525; cv=none; d=google.com; s=arc-20160816; b=pq1Cmq7YRKQ4kkE5Ag/cia1NzQFNAs6tIavbKXzQJEF5o9L0yJss9kEYr7dvxrEut4 0zo8B0sB+eqR+71tXeGo7NpvmSm3znmC+mQxXJY+NRiY/BsJTnAuge4bp4TlR8GoHmw4 44ujcACxKo2whV+uKJ5C5mbJqXdSk+JjNu+BmKKKUdrZZ4GfIKzTjQp2lZipXTIL0ouM 4I93z0z0EzwesjB44wz6VFAjb1au681gJJBnRPSuh5WlOlRvRcDjpWBE0qGzKJuicru1 mI0QEGpYvdjIWooW2ZrocNPyJwqTuhqydgOXp7uZjqTcMR3OYkDLzATFFIFZvL4I4hca kqRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:message-id :content-transfer-encoding:references:importance:sensitivity :mime-version:date:cc:to:from:in-reply-to; bh=0aWDin/0mV2C591bfdWDMGCYi82fuVzvaJunNWzydzw=; b=QU7VoN6dAp7Cgt0Blp6ysRoVJ1izvo3jroD8R7EDlBZ/2kZWUFWMPDjrgtQC3T0+qz Y/ic/FZ2pdcbxJ0taFIQRESIaNrAYrvrABxYUelqeHPExCU57HplNL1vNA0iW5Rt7agv ypH05zi7AJVlSvmPe3ktfh2FEKxL/cFm8+kQksDO1md3vDBPg412fFbdh9xqI2MspHQs e7GTx8Y2xbPhxNLlSFeECrLvkIxfWYhBsW6QU9M+4l9dCLawFo3lHSza/1x/xeK0sUeG rCgxV+jdS5/rnPhwENFuiu6FnXHKZfwQoHmollWC/lifY38ZDuhEXJvQw0ayQelm0l8m oW1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 2si115853oij.97.2020.02.27.08.21.51; Thu, 27 Feb 2020 08:22:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730045AbgB0QVc convert rfc822-to-8bit (ORCPT + 99 others); Thu, 27 Feb 2020 11:21:32 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:5768 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728963AbgB0QVc (ORCPT ); Thu, 27 Feb 2020 11:21:32 -0500 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01RGKAup026069 for ; Thu, 27 Feb 2020 11:21:31 -0500 Received: from smtp.notes.na.collabserv.com (smtp.notes.na.collabserv.com [158.85.210.111]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ydcp673g7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 27 Feb 2020 11:21:30 -0500 Received: from localhost by smtp.notes.na.collabserv.com with smtp.notes.na.collabserv.com ESMTP for from ; Thu, 27 Feb 2020 16:21:30 -0000 Received: from us1b3-smtp06.a3dr.sjc01.isc4sb.com (10.122.203.184) by smtp.notes.na.collabserv.com (10.122.47.52) with smtp.notes.na.collabserv.com ESMTP; Thu, 27 Feb 2020 16:21:22 -0000 Received: from us1b3-mail162.a3dr.sjc03.isc4sb.com ([10.160.174.187]) by us1b3-smtp06.a3dr.sjc01.isc4sb.com with ESMTP id 2020022716212224-572447 ; Thu, 27 Feb 2020 16:21:22 +0000 In-Reply-To: <20200227155335.GI31668@ziepe.ca> From: "Bernard Metzler" To: "Jason Gunthorpe" Cc: "syzbot" , chuck.lever@oracle.com, dledford@redhat.com, leon@kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, parav@mellanox.com, syzkaller-bugs@googlegroups.com, willy@infradead.org Date: Thu, 27 Feb 2020 16:21:21 +0000 MIME-Version: 1.0 Sensitivity: Importance: Normal X-Priority: 3 (Normal) References: <20200227155335.GI31668@ziepe.ca>,<20200226204238.GC31668@ziepe.ca> <000000000000153fac059f740693@google.com> X-Mailer: IBM iNotes ($HaikuForm 1054.1) | IBM Domino Build SCN1812108_20180501T0841_FP62 November 04, 2019 at 09:47 X-KeepSent: 0C6D63D8:F1817050-0025851B:0059D878; type=4; name=$KeepSent X-LLNOutbound: False X-Disclaimed: 18363 X-TNEFEvaluated: 1 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset=UTF-8 x-cbid: 20022716-3633-0000-0000-000001C8796B X-IBM-SpamModules-Scores: BY=0.021699; FL=0; FP=0; FZ=0; HX=0; KW=0; PH=0; SC=0.399202; ST=0; TS=0; UL=0; ISC=; MB=0.012841 X-IBM-SpamModules-Versions: BY=3.00012651; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000293; SDB=6.01340059; UDB=6.00714142; IPR=6.01122420; MB=3.00030996; MTD=3.00000008; XFM=3.00000015; UTC=2020-02-27 16:21:29 X-IBM-AV-DETECTION: SAVI=unsuspicious REMOTE=unsuspicious XFE=unused X-IBM-AV-VERSION: SAVI=2020-02-27 12:31:36 - 6.00011055 x-cbparentid: 20022716-3634-0000-0000-0000AD5397FE Message-Id: Subject: RE: possible deadlock in cma_netdev_callback X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-02-27_05:2020-02-26,2020-02-27 signatures=0 X-Proofpoint-Spam-Reason: safe Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -----"Jason Gunthorpe" wrote: ----- >To: "Bernard Metzler" >From: "Jason Gunthorpe" >Date: 02/27/2020 04:53PM >Cc: "syzbot" , >chuck.lever@oracle.com, dledford@redhat.com, leon@kernel.org, >linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, >netdev@vger.kernel.org, parav@mellanox.com, >syzkaller-bugs@googlegroups.com, willy@infradead.org >Subject: [EXTERNAL] Re: possible deadlock in cma_netdev_callback > >On Thu, Feb 27, 2020 at 10:11:13AM +0000, Bernard Metzler wrote: > >> Thanks for letting me know! Hmm, we cannot use RCU locks since >> we potentially sleep. One solution would be to create a list >> of matching interfaces while under lock, unlock and use that >> list for calling siw_listen_address() (which may sleep), >> right...? > >Why do you need to iterate over addresses anyhow? Shouldn't the >listen >just be done with the address the user gave and a BIND DEVICE to the >device siw is connected to? The user may give a wildcard local address, so we'd have to bind to all addresses of that device... Best, Bernard. > >Also that loop in siw_create looks wrong to me > >Jason > >