Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Liu, Zhan" <Zhan.Liu@amd.com>
To:     Melissa Wen <melissa.srw@gmail.com>,
        "Wentland, Harry" <Harry.Wentland@amd.com>,
        "Li, Sun peng (Leo)" <Sunpeng.Li@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Koenig, Christian" <Christian.Koenig@amd.com>,
        "Zhou, David(ChunMing)" <David1.Zhou@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
CC:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] drm/amd/display: dc_link: code clean up on detect_dp
 function
Thread-Topic: [PATCH 2/2] drm/amd/display: dc_link: code clean up on detect_dp
 function
Thread-Index: AQHV7PFJrzsxO38xA0qqdJAhaAZqgqgvYCNQ
Date:   Thu, 27 Feb 2020 18:39:51 +0000
Message-ID: <DM5PR1201MB25540271F42D8034FB2611829EEB0@DM5PR1201MB2554.namprd12.prod.outlook.com>
References: <cover.1582752490.git.melissa.srw@gmail.com>
 <9961afca2cf831ac688025a63b7cd35dd0908fac.1582752490.git.melissa.srw@gmail.com>
In-Reply-To: <9961afca2cf831ac688025a63b7cd35dd0908fac.1582752490.git.melissa.srw@gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1bb0ce8f-e298-4c0f-1df5-08d7bbb46e9f
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2020 18:39:51.8954
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vbvX29cIn9n3J+/a/Xx2pFFtw1vzd/D2U/sBx7dThZ6YaiuE+ZyN4UKrFBCqiu+h
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0090
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Melissa Wen
> Sent: 2020/February/26, Wednesday 5:08 PM
> To: Wentland, Harry <Harry.Wentland@amd.com>; Li, Sun peng (Leo)
> <Sunpeng.Li@amd.com>; Deucher, Alexander
> <Alexander.Deucher@amd.com>; Koenig, Christian
> <Christian.Koenig@amd.com>; Zhou, David(ChunMing)
> <David1.Zhou@amd.com>; David Airlie <airlied@linux.ie>; Daniel Vetter
> <daniel@ffwll.ch>; Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
> Cc: dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; linux=
-
> kernel@vger.kernel.org
> Subject: [PATCH 2/2] drm/amd/display: dc_link: code clean up on detect_dp
> function
>=20
> Removes codestyle issues on detect_dp function as suggested by
> checkpatch.pl.
>=20
> CHECK: Lines should not end with a '('
> WARNING: Missing a blank line after declarations
> WARNING: line over 80 characters
> CHECK: Alignment should match open parenthesis
>=20
> Signed-off-by: Melissa Wen <melissa.srw@gmail.com>

Thank you Melissa for your contribution! Will apply it.

This patch is:
Reviewed-by: Zhan Liu <zhan.liu@amd.com>

> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_link.c | 35 +++++++++----------
>  1 file changed, 16 insertions(+), 19 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index 0f28b5694144..adb717f02c9c 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -585,14 +585,14 @@ static void
> read_current_link_settings_on_detect(struct dc_link *link)
>  		LINK_SPREAD_05_DOWNSPREAD_30KHZ :
> LINK_SPREAD_DISABLED;  }
>=20
> -static bool detect_dp(
> -	struct dc_link *link,
> -	struct display_sink_capability *sink_caps,
> -	bool *converter_disable_audio,
> -	struct audio_support *audio_support,
> -	enum dc_detect_reason reason)
> +static bool detect_dp(struct dc_link *link,
> +		      struct display_sink_capability *sink_caps,
> +		      bool *converter_disable_audio,
> +		      struct audio_support *audio_support,
> +		      enum dc_detect_reason reason)
>  {
>  	bool boot =3D false;
> +
>  	sink_caps->signal =3D link_detect_sink(link, reason);
>  	sink_caps->transaction_type =3D
>  		get_ddc_transaction_type(sink_caps->signal);
> @@ -606,9 +606,8 @@ static bool detect_dp(
>  			sink_caps->signal =3D
> SIGNAL_TYPE_DISPLAY_PORT_MST;
>  			link->type =3D dc_connection_mst_branch;
>=20
> -			dal_ddc_service_set_transaction_type(
> -							link->ddc,
> -							sink_caps-
> >transaction_type);
> +			dal_ddc_service_set_transaction_type(link->ddc,
> +							     sink_caps-
> >transaction_type);
>=20
>  			/*
>  			 * This call will initiate MST topology discovery.
> Which @@ -637,13 +636,10 @@ static bool detect_dp(
>  			if (reason =3D=3D DETECT_REASON_BOOT)
>  				boot =3D true;
>=20
> -			dm_helpers_dp_update_branch_info(
> -				link->ctx,
> -				link);
> +			dm_helpers_dp_update_branch_info(link->ctx, link);
>=20
> -			if (!dm_helpers_dp_mst_start_top_mgr(
> -				link->ctx,
> -				link, boot)) {
> +			if (!dm_helpers_dp_mst_start_top_mgr(link->ctx,
> +							     link, boot)) {
>  				/* MST not supported */
>  				link->type =3D dc_connection_single;
>  				sink_caps->signal =3D
> SIGNAL_TYPE_DISPLAY_PORT; @@ -651,7 +647,7 @@ static bool detect_dp(
>  		}
>=20
>  		if (link->type !=3D dc_connection_mst_branch &&
> -			is_dp_active_dongle(link)) {
> +		    is_dp_active_dongle(link)) {
>  			/* DP active dongles */
>  			link->type =3D dc_connection_active_dongle;
>  			if (!link->dpcd_caps.sink_count.bits.SINK_COUNT)
> { @@ -662,14 +658,15 @@ static bool detect_dp(
>  				return true;
>  			}
>=20
> -			if (link->dpcd_caps.dongle_type !=3D
> DISPLAY_DONGLE_DP_HDMI_CONVERTER)
> +			if (link->dpcd_caps.dongle_type !=3D
> +			    DISPLAY_DONGLE_DP_HDMI_CONVERTER)
>  				*converter_disable_audio =3D true;
>  		}
>  	} else {
>  		/* DP passive dongles */
>  		sink_caps->signal =3D dp_passive_dongle_detection(link->ddc,
> -				sink_caps,
> -				audio_support);
> +								sink_caps,
> +
> 	audio_support);
>  	}
>=20
>  	return true;
> --
> 2.25.0
>=20
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org