Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@micron.com>
To:     Boris Brezillon <boris.brezillon@collabora.com>
CC:     Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Frieder Schrempf <frieder.schrempf@kontron.de>,
        Boris Brezillon <bbrezillon@kernel.org>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "shiva.linuxworks@gmail.com" <shiva.linuxworks@gmail.com>
Subject: RE: [EXT] Re: [PATCH v4 2/5] mtd: spinand: micron: Add new Micron SPI
 NAND devices
Thread-Topic: [EXT] Re: [PATCH v4 2/5] mtd: spinand: micron: Add new Micron
 SPI NAND devices
Thread-Index: AQHV7Zrt8nxb4M5o4EyJweDi+Kt0uqgveTTw
Date:   Thu, 27 Feb 2020 20:16:46 +0000
Message-ID: <MN2PR08MB6397477172BAC14986175E6DB8EB0@MN2PR08MB6397.namprd08.prod.outlook.com>
References: <20200206202206.14770-1-sshivamurthy@micron.com>
        <20200206202206.14770-3-sshivamurthy@micron.com>
 <20200227192247.52f84723@collabora.com>
In-Reply-To: <20200227192247.52f84723@collabora.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: micron.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 777269e7-1919-4e74-8535-08d7bbc1f88b
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2020 20:16:46.7626
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f38a5ecd-2813-4862-b11b-ac1d563c806f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 566LSgObpshVDZ54KUfcIBdsxTaa0D14hxMyIFlB0/8bGVpE1sKl4PckQvlq5JR21RiXS4J1bJs+CXN9YMT7FQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR08MB5936
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Boris,

Thanks for the review.

>=20
> On Thu,  6 Feb 2020 21:22:03 +0100
> shiva.linuxworks@gmail.com wrote:
>=20
> > From: Shivamurthy Shastri <sshivamurthy@micron.com>
> >
> > Add device table for M79A and M78A series Micron SPI NAND devices.
> >
> > Signed-off-by: Shivamurthy Shastri <sshivamurthy@micron.com>
> > ---
> >  drivers/mtd/nand/spi/micron.c | 31
> +++++++++++++++++++++++++++++++
> >  1 file changed, 31 insertions(+)
> >
> > diff --git a/drivers/mtd/nand/spi/micron.c
> b/drivers/mtd/nand/spi/micron.c
> > index c028d0d7e236..5fd1f921ef12 100644
> > --- a/drivers/mtd/nand/spi/micron.c
> > +++ b/drivers/mtd/nand/spi/micron.c
> > @@ -91,6 +91,7 @@ static int micron_8_ecc_get_status(struct
> spinand_device *spinand,
> >  }
> >
> >  static const struct spinand_info micron_spinand_table[] =3D {
> > +	/* M79A 2Gb 3.3V */
>=20
> Should be added in a separate patch.

Okay, I will create separate patch for each device.

>=20
> >  	SPINAND_INFO("MT29F2G01ABAGD", 0x24,
> >  		     NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 2, 1, 1),
> >  		     NAND_ECCREQ(8, 512),
> > @@ -100,6 +101,36 @@ static const struct spinand_info
> micron_spinand_table[] =3D {
> >  		     0,
> >  		     SPINAND_ECCINFO(&micron_8_ooblayout,
> >  				     micron_8_ecc_get_status)),
> > +	/* M79A 2Gb 1.8V */
> > +	SPINAND_INFO("MT29F2G01ABBGD", 0x25,
> > +		     NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 2, 1, 1),
> > +		     NAND_ECCREQ(8, 512),
> > +		     SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
> > +					      &write_cache_variants,
> > +					      &update_cache_variants),
> > +		     0,
> > +		     SPINAND_ECCINFO(&micron_8_ooblayout,
> > +				     micron_8_ecc_get_status)),
> > +	/* M78A 1Gb 3.3V */
> > +	SPINAND_INFO("MT29F1G01ABAFD", 0x14,
> > +		     NAND_MEMORG(1, 2048, 128, 64, 1024, 20, 1, 1, 1),
> > +		     NAND_ECCREQ(8, 512),
> > +		     SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
> > +					      &write_cache_variants,
> > +					      &update_cache_variants),
> > +		     0,
> > +		     SPINAND_ECCINFO(&micron_8_ooblayout,
> > +				     micron_8_ecc_get_status)),
> > +	/* M78A 1Gb 1.8V */
> > +	SPINAND_INFO("MT29F1G01ABAFD", 0x15,
> > +		     NAND_MEMORG(1, 2048, 128, 64, 1024, 20, 1, 1, 1),
> > +		     NAND_ECCREQ(8, 512),
> > +		     SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
> > +					      &write_cache_variants,
> > +					      &update_cache_variants),
> > +		     0,
> > +		     SPINAND_ECCINFO(&micron_8_ooblayout,
> > +				     micron_8_ecc_get_status)),
> >  };
> >
> >  static int micron_spinand_detect(struct spinand_device *spinand)