Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 27 Feb 2020 21:52:13 +0100
From:   Boris Brezillon <boris.brezillon@collabora.com>
To:     "Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@micron.com>
Cc:     Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Frieder Schrempf <frieder.schrempf@kontron.de>,
        Boris Brezillon <bbrezillon@kernel.org>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "shiva.linuxworks@gmail.com" <shiva.linuxworks@gmail.com>
Subject: Re: [EXT] Re: [PATCH v4 2/5] mtd: spinand: micron: Add new Micron
 SPI NAND devices
Message-ID: <20200227215213.01fd760b@collabora.com>
In-Reply-To: <MN2PR08MB639762D89F85C2556F51D48EB8EB0@MN2PR08MB6397.namprd08.prod.outlook.com>
References: <20200206202206.14770-1-sshivamurthy@micron.com>
        <20200206202206.14770-3-sshivamurthy@micron.com>
        <20200227192247.52f84723@collabora.com>
        <MN2PR08MB6397477172BAC14986175E6DB8EB0@MN2PR08MB6397.namprd08.prod.outlook.com>
        <20200227211759.7ba02273@collabora.com>
        <MN2PR08MB639762D89F85C2556F51D48EB8EB0@MN2PR08MB6397.namprd08.prod.outlook.com>
Organization: Collabora
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 27 Feb 2020 20:24:22 +0000
"Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@micron.com> wrote:

> Hi Boris,
> 
> > 
> > On Thu, 27 Feb 2020 20:16:46 +0000
> > "Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@micron.com> wrote:
> >   
> > > Hi Boris,
> > >
> > > Thanks for the review.
> > >  
> > > >
> > > > On Thu,  6 Feb 2020 21:22:03 +0100
> > > > shiva.linuxworks@gmail.com wrote:
> > > >  
> > > > > From: Shivamurthy Shastri <sshivamurthy@micron.com>
> > > > >
> > > > > Add device table for M79A and M78A series Micron SPI NAND devices.
> > > > >
> > > > > Signed-off-by: Shivamurthy Shastri <sshivamurthy@micron.com>
> > > > > ---
> > > > >  drivers/mtd/nand/spi/micron.c | 31  
> > > > +++++++++++++++++++++++++++++++  
> > > > >  1 file changed, 31 insertions(+)
> > > > >
> > > > > diff --git a/drivers/mtd/nand/spi/micron.c  
> > > > b/drivers/mtd/nand/spi/micron.c  
> > > > > index c028d0d7e236..5fd1f921ef12 100644
> > > > > --- a/drivers/mtd/nand/spi/micron.c
> > > > > +++ b/drivers/mtd/nand/spi/micron.c
> > > > > @@ -91,6 +91,7 @@ static int micron_8_ecc_get_status(struct  
> > > > spinand_device *spinand,  
> > > > >  }
> > > > >
> > > > >  static const struct spinand_info micron_spinand_table[] = {
> > > > > +	/* M79A 2Gb 3.3V */  
> > > >
> > > > Should be added in a separate patch.  
> > >
> > > Okay, I will create separate patch for each device.  
> > 
> > No, I meant just for this line.  
> 
> How about including this line with 1st Patch?

It's even worse if you move it to patch 1. Let's keep it like that.