Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: tbGJqOl+JAhox8pNPnj6l393cQmK0Y0Ra06fL1QCzrhjg1w50obkL8xxm3FzaL2wztOs05DTky
 z3utEj4+4zEBlj/KCfts8ok9ZFCSgo1KgA/jn0Hd79MWIi/0ut1a2Tx9VbA1zoy9krrATZ8XkZ
 VLuM4XyEM/D7wF8ja5vz+RM3uCO+kr/lrU2KqUfjLhL/Rop24vim7weWpwFE6dlwKuDOhDuuwW
 DZVQwM7lRyKzP26aQV1DMikwg1cJzszUuwfhMmiGXcA35IKoUoBRQ3AKPw9Efix3Dd/eC9+xf6
 XIM=
IronPort-SDR: MSubYsUrb2x1Cw2HfLZpah1uR2qjO/8/m40K3/1zT2OyGr0KqFab5GemDEHCzm4h/hOkJWFogp
 E5N8l4y64ZqQcFoKO2WOX+OI6hIJwLmO3CpQX4gLtA0hZ31jdU0CRQaYpscHeGXK4O0w5X2j94
 mW9bWOf4cwapDl0bTh1j4/nwxvnSQtcmPGaZVY9wR2GCZiUkirPHQ1hKWce9Sl9HGFuKczxW+V
 m2l7VcFG2++ONX6IE3oQIVINAsNQDlcZ5e0RWhdFxtqzxwaPBbOpvAjAy1fCO/7IJZMieDpp8b
 xDKvd1nGHG1Kweytk2hLVPdE
IronPort-SDR: 13dHDQuDjVqwy8bQJ4BCMMPrMoM5zJFnejUUpuHIR70QwoFMAzTZphl0K1TRDjvt+V0mHY7dIN
 2qrCH9bD+NIRABatKHGwCexrRun/O6kt8oA/zGcHQKKX595Rv+/rS4Ea1pA9iqyzrzH7m/GuSw
 lNiCDt6q370n/YxDOk1tbF4xHMpTdaq65VQNiUB1n7f8ZG5go43b6PXOiwkT3eK/xHacdX0YDt
 nMD/aHbGf8kboB85aZrMza641cM7iDDZd3i74SeIxVcubdbqLaxNjirWa8S9GNKxIRw0RVlDag
 zGg=
WDCIronportException: Internal
From:   Alistair Francis <alistair.francis@wdc.com>
To:     linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        virtualization@lists.linux-foundation.org
Cc:     daniel@ffwll.ch, airlied@linux.ie, kraxel@redhat.com,
        alistair23@gmail.com, Alistair Francis <alistair.francis@wdc.com>,
        Khem Raj <raj.khem@gmail.com>
Subject: [PATCH] drm/bochs: Remove vga write
Date:   Thu, 27 Feb 2020 13:04:54 -0800
Message-Id: <20200227210454.18217-1-alistair.francis@wdc.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

The QEMU model for the Bochs display has no VGA memory section at offset
0x400 [1]. By writing to this register Linux can create a write to
unassigned memory which depending on machine and architecture can result
in a store fault.

I don't see any reference to this address at OSDev [2] or in the Bochs
source code.

Removing this write still allows graphics to work inside QEMU with
the bochs-display.

1: https://gitlab.com/qemu-project/qemu/-/blob/master/hw/display/bochs-display.c#L264
2. https://wiki.osdev.org/Bochs_VBE_Extensions

Reported-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
 drivers/gpu/drm/bochs/bochs_hw.c | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/drivers/gpu/drm/bochs/bochs_hw.c b/drivers/gpu/drm/bochs/bochs_hw.c
index b615b7dfdd9d..dfb2a5363c62 100644
--- a/drivers/gpu/drm/bochs/bochs_hw.c
+++ b/drivers/gpu/drm/bochs/bochs_hw.c
@@ -10,19 +10,6 @@
 
 /* ---------------------------------------------------------------------- */
 
-static void bochs_vga_writeb(struct bochs_device *bochs, u16 ioport, u8 val)
-{
-	if (WARN_ON(ioport < 0x3c0 || ioport > 0x3df))
-		return;
-
-	if (bochs->mmio) {
-		int offset = ioport - 0x3c0 + 0x400;
-		writeb(val, bochs->mmio + offset);
-	} else {
-		outb(val, ioport);
-	}
-}
-
 static u16 bochs_dispi_read(struct bochs_device *bochs, u16 reg)
 {
 	u16 ret = 0;
@@ -217,8 +204,6 @@ void bochs_hw_setmode(struct bochs_device *bochs,
 			 bochs->xres, bochs->yres, bochs->bpp,
 			 bochs->yres_virtual);
 
-	bochs_vga_writeb(bochs, 0x3c0, 0x20); /* unblank */
-
 	bochs_dispi_write(bochs, VBE_DISPI_INDEX_ENABLE,      0);
 	bochs_dispi_write(bochs, VBE_DISPI_INDEX_BPP,         bochs->bpp);
 	bochs_dispi_write(bochs, VBE_DISPI_INDEX_XRES,        bochs->xres);
-- 
2.25.0