Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp1580541ybf; Thu, 27 Feb 2020 13:53:18 -0800 (PST) X-Google-Smtp-Source: APXvYqxJzpphm6/CJutmOeZR78EZV03iduxZ4/ao2n7CKobF9DwXQuT7i1ao4X+3lJyvZeAhQno1 X-Received: by 2002:aca:75d2:: with SMTP id q201mr262466oic.81.1582840398208; Thu, 27 Feb 2020 13:53:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582840398; cv=none; d=google.com; s=arc-20160816; b=yXWc1sSAAGFwuPmbrMlIHcUNYtPgIBiqHzuNFUl9blF5JQ08kybDcytnNM+xJV9y1x is0bVMUdWELOa3NbeKbswjM77eYXrvuv25IGsIeLWaOkTMUWuz1lV/OZ78K9QalCvWOD iJpLXihgvzIPzDUziiWP6dxLrzDUaG6GOohekHAjPG7snEnP7gJO/QdMVBFNiJVBKhxA EF6Mzel52UIUolnp5d+XPP4IYzVIhtPdz1QaTLOMEGIpgMcuABC3+z5uaQAN07fNzrCV xbkRQwWygrr2yMDehASVHq/fd6xs9NYTn0b+Pjv3BboBrkrDg0Ja8M9VZ1lvbpEh/dIt OzSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=a8tz7pn6WYS1zSkKOSE65k1PsuDxpcFOThMRyfGsXzE=; b=05/HiVrnKwsnoWzSTJ24L7pmxL5Z7NvZzxtA6icYDYum9RJ4UIvdItg4MWcyIANnul bRPyqOnT3l+Ddvm9Hun25GeIiyVspIm2MHqlA4UNzBSn7qfDJTqjzgsvU0RLjljhuk0Q n7EQZiFdiu1DwcdgZ5X0uWcsAT0Fz4FnPXWMr3ZxIbkFMXZekTQqJJ/q20S4xxQzNrAH 86YDTLRVedDuYRIYjFWDSNh0oipUAGBgxZCRmtmWKB6XvvUoYNAmN7FqYudPTZtFEOZY VDhfYkhl6jAEN0KEOhLyjB+5ClA7llcUS8BwUYhySkgSK7SBC6KC7FJaxJJJwfNJagGP eicg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="Nu/xJQJc"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w20si563425oic.103.2020.02.27.13.53.06; Thu, 27 Feb 2020 13:53:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="Nu/xJQJc"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730011AbgB0Vwn (ORCPT + 99 others); Thu, 27 Feb 2020 16:52:43 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:45829 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726791AbgB0Vwm (ORCPT ); Thu, 27 Feb 2020 16:52:42 -0500 Received: by mail-pf1-f195.google.com with SMTP id 2so517334pfg.12 for ; Thu, 27 Feb 2020 13:52:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=a8tz7pn6WYS1zSkKOSE65k1PsuDxpcFOThMRyfGsXzE=; b=Nu/xJQJcfGP5wjtq6rtG/YhcMWcwj5otv44cx4FAAyishIVQiJQUHZjthXqMGPt5mx q3ZItdbyNqwOLeJLnUgK7Ij7Xz6qHMF8gxezXja59kyh659wtD/c5NTCYvpI+N/feY7n zJynnhsSZEQvADPTbT7WzlnuziaDLdClsJDtRzZKzVGSZ6ioBrHzl0Ow/2N5dnIxDwyY 9YvVLFUhSv6Qld1wjqqIcFdYhanLQItBzbmIXkZWjk92iQPuWJbeSrBKk9Hu7M3RwsDg R5oJGClkDbCW5J5gP35HFIkaV7DyO9w8adVx4dA7AvU1PlUG49dEnAi8TDjSV0rKmRxD uqmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=a8tz7pn6WYS1zSkKOSE65k1PsuDxpcFOThMRyfGsXzE=; b=BuVV9mXJBbmkOs2BvAMVEAB7ISiBPjfgCa1Fp0ItkkrR+HxU46D//UD0tcw/qyoibo 42xcH3vvglxlOV30E/xtEUWQw67bxBkFRWPkBphGyr4eRZo6cA/SijI1Bc44UHF/4b5i OzdIM3m4VKiYaqsngVtWCba1O66r8ALcYwOt8UE+szJ7rx/FkD/4WjUHA9uesKMMjXbm 1Bt30C++Cqi9SO4/XqQqu6hlsJ4vrjAjTUz0gRcco3tmOAQl2UT4zmcdmL9DOHsxhIUH 9GcMJp/UtUTfDCKYRb3pUx44mh0QpqtyTEtJSDxlTo6aOkXhcNAot/Muij/n4rk6BgPO 5+zQ== X-Gm-Message-State: APjAAAWjxGfiMOiXfMatjikwcXTvmGkrspaWkCCsjo8aY5WDmay4AULV 1wJbD5MH5KSyb5QoZvEN1+w= X-Received: by 2002:a63:36cd:: with SMTP id d196mr1396472pga.280.1582840361366; Thu, 27 Feb 2020 13:52:41 -0800 (PST) Received: from google.com ([2620:15c:211:1:3e01:2939:5992:52da]) by smtp.gmail.com with ESMTPSA id w25sm8060951pfi.106.2020.02.27.13.52.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 13:52:37 -0800 (PST) Date: Thu, 27 Feb 2020 13:52:35 -0800 From: Minchan Kim To: Jules Irenge Cc: linux-kernel@vger.kernel.org, boqun.feng@gmail.com, Nitin Gupta , Sergey Senozhatsky , Andrew Morton , "open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR" Subject: Re: [PATCH 10/30] mm/zsmalloc: Add missing annotation for migrate_read_lock() Message-ID: <20200227215235.GB215068@google.com> References: <0/30> <20200214204741.94112-1-jbi.octave@gmail.com> <20200214204741.94112-11-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200214204741.94112-11-jbi.octave@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 14, 2020 at 08:47:21PM +0000, Jules Irenge wrote: > Sparse reports a warning at migrate_read_lock()() > > warning: context imbalance in migrate_read_lock() - wrong count at exit > > The root cause is the missing annotation at migrate_read_lock() > Add the missing __acquires(&zspage->lock) annotation > > Signed-off-by: Jules Irenge Acked-by: Minchan Kim