Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp1581757ybf; Thu, 27 Feb 2020 13:54:57 -0800 (PST) X-Google-Smtp-Source: APXvYqxFA31ZD5PAgSXqtX+CoZEmifgOD8SSN+XKMwxjRvGsACxZVuCSKqt4oIz+2Z3IOBeOufqI X-Received: by 2002:a9d:7309:: with SMTP id e9mr858017otk.260.1582840497391; Thu, 27 Feb 2020 13:54:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582840497; cv=none; d=google.com; s=arc-20160816; b=UOWHiFq/qcjDqKPNs5hFg538XFPIXM8szePH1PiivGr385mw/yma2XLrdTL73wwZ8P z12k3SQ5Een7JU//A6uVkd1eVK8dXP1/aIBdRWlzwlHzR4M1SgpgZo2fs/SY+E9Q9S50 RJVMmxDd9oxwGTG2vTYZEEr4qYJQpIpzgSd8yumh4JKr6OYbN/T9jl575e1EpjhIFX/S noL3McWE2Z+iceNBIHU6IFzz8dlzaOz5o6dPmBWkSgziaK2fsOwy88HDrdMJ4uE+w7Rg 2sUVkCfzR6i6hRPU9JeJo3aUu3h1mytwZG4ot2NX9QcT/nstXa/WGICGqeumws4QOyA7 Ar2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=7dwQH34KOZabRYRAwZrdnJHMAH3aJ68bic4ZknrTLvQ=; b=mV7DOckW5mrRle/cHDurKILlpaNlKGAH3eUw9vrAjM5SZ/xkovQXl1csriHfqCxP1E e1XSYlrvHnH4zRGN32cUN7tD+dMt8p1WIPtWYAzTd25R6AW0l3Jf42oI/hPz4WCidGBe CQ0xeE1ALi3wQiyY6oL4RfUBMpkEGOXwa05WaFx2TjpCqrTArlEswmvsTaZP/UKOyQ8k mMtgFXxnUwMcg9mkmppIfKVomb2hwoOA8GGiwQf6PUAsh8tHNFjLIiJiRD/hIvYkmrO3 l0ZZ7Wnqt6Zi6zc22CyAAqLMeAruF8tD1x1Rl4eAiGHzssWFvg/yMUdID7imaEvJlTwk jpgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=mjmOJ66o; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l25si334737otq.76.2020.02.27.13.54.37; Thu, 27 Feb 2020 13:54:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=mjmOJ66o; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730215AbgB0Vxz (ORCPT + 99 others); Thu, 27 Feb 2020 16:53:55 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:40310 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729773AbgB0Vxy (ORCPT ); Thu, 27 Feb 2020 16:53:54 -0500 Received: by mail-pf1-f194.google.com with SMTP id b185so532119pfb.7 for ; Thu, 27 Feb 2020 13:53:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7dwQH34KOZabRYRAwZrdnJHMAH3aJ68bic4ZknrTLvQ=; b=mjmOJ66owX0Df96b/m5GC1crg6u5wtB1ayeppKZj6Rh3bevN9Nj/By2G3ScTRQpKn7 l+QLMQJsMBwlF1Zv2iBkFTRR4zrlvvcKN2MrL/R6n5r9pc/SRafnlN/oxqFg3CCvhFkw x3rKHRm5o1xq8zpLmYfzBSkrODdyNgBksE58gfKBjFofl3sAgeX9ZF9lhTfstRzvzgUO vXWIH65KMcmLCNHHgxg6IbeiXN1IFExj7wyNO1eYaAQAjFUveBoFv0WbPqH0pukyHoAN a6tDVZmzsPqplyKO/DIOOkWvoHUxTBq3BZ2DbwpFclx7qXI34rd0ey+jlA1W2Rylis/C pNsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=7dwQH34KOZabRYRAwZrdnJHMAH3aJ68bic4ZknrTLvQ=; b=j5oQTpvaEw14apK6WSurOexJ3O0/lWyCu4BvePLrx/Hv/LeBcgR6w3UnB4wVx0sxY+ xhXuMiV/gPRzCb8W7ZcKbj2EUoaMHx+7yOSY92XO9H83cjERJ0QuZNljebw83v+VeVzW tXmfBpK2R6CTXhA1MNFQ04Cy+aePQyP10YWFQMD7i9Q2dIMNuvX0qidMamk+CN6nmAuy IIc0S954Kwa6xOussD/EX7tBZzAe5XK609hYuNkTr0DJkUed3Tw/0NYa5WR6fuch0vqU 1GsWh4qP61IhkVLOF/oVxTh/fBAFKyOZjzXPRfAPz5rbjPpk35dbvH0Dw57kBp37g73M u5kQ== X-Gm-Message-State: APjAAAUnzl5RAo6xoJA2huMPM2pYWRbgsNgM03n+2x2W8Onht/68z9Ko SM0dbCXZ755LG/ietsEr2Ks= X-Received: by 2002:a63:f13:: with SMTP id e19mr1283835pgl.135.1582840433706; Thu, 27 Feb 2020 13:53:53 -0800 (PST) Received: from google.com ([2620:15c:211:1:3e01:2939:5992:52da]) by smtp.gmail.com with ESMTPSA id q4sm8748395pfl.175.2020.02.27.13.53.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 13:53:52 -0800 (PST) Date: Thu, 27 Feb 2020 13:53:51 -0800 From: Minchan Kim To: Jules Irenge Cc: linux-kernel@vger.kernel.org, boqun.feng@gmail.com, Nitin Gupta , Sergey Senozhatsky , Andrew Morton , "open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR" Subject: Re: [PATCH 13/30] mm/zsmalloc: Add missing annotation for unpin_tag() Message-ID: <20200227215351.GE215068@google.com> References: <0/30> <20200214204741.94112-1-jbi.octave@gmail.com> <20200214204741.94112-14-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200214204741.94112-14-jbi.octave@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 14, 2020 at 08:47:24PM +0000, Jules Irenge wrote: > Sparse reports a warning at unpin_tag()() > > warning: context imbalance in unpin_tag() - unexpected unlock > > The root cause is the missing annotation at unpin_tag() > Add the missing __releases(bitlock) annotation > > Signed-off-by: Jules Irenge Acked-by: Minchan Kim