Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp1582143ybf; Thu, 27 Feb 2020 13:55:41 -0800 (PST) X-Google-Smtp-Source: APXvYqzlE/BMb1bG2+1FKMUV3vfVX/szXpIWhEWtzjtoofLsjH4JcPshZ8AJLUhMZAfiX05Cm7es X-Received: by 2002:a05:6808:153:: with SMTP id h19mr879335oie.80.1582840540913; Thu, 27 Feb 2020 13:55:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582840540; cv=none; d=google.com; s=arc-20160816; b=GmwWGrrhJxgzHboeBbBU1h/UHVPZIaIpfKcP7CGVCnhwIBfKJpAtFOPTJTikuaVx2l uVeZKQzG2bQae4nyZm/lSBg8xX9IEPZB0JWE6pXgFv6PayFZHHs/aSBChtqewjAPj6vx s9HvObaNfFpZBpGQuUR7OHG1Ike/v+6NcQBZOOAek51huYkT7KHkb5hZQxiTJQSv6KsQ oYAIsJWKRbBK82jD7LwF0sYLMrdMf63BhQx4AczjsNg3tas6MTTz7Hp4TspK+PrQBunT Uczf0oKXfYmdT6JroAw+52cobS5G2JMZyQVPiVKBmtmJSd23c3azZ62I8gy1eXw9qtgI W9yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=aWQjRfD263PGFSWLYeye9fWJ9nZRg32z3KxjvyDZXrg=; b=YXvmXsaHQnKqwOBmjWwW+S2QpPidYSBdElnfw/o69RL2dHvNowuXkNNO6ZhxtlswK8 4neKI8T6Vtm+1QaFwwB5liaLEHJGtGhaW4Jq65RSFTlEzDx+ZITzHVO/TCWnfttDcTP+ w+z0dxr7CJ7pwA8DBckCEfPhaC9bXDqaRRr+4hFuySKbs0P/P0RfQTv2qHNBGjbiJn7y 0EjqA+SLe1fSrPJAoErRVxMkoLPiT3RTxIxvDLcIigQo3ie/IvYy8D4OWIvalqx3VgYy dkydRdVeHSo87tps037/QPAofzpzGYZ8koUWRMoTfFr8lD6CUsLyA5RQi+kYTxu5Snir YYDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=n2jzjZjw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 45si316760otg.7.2020.02.27.13.55.29; Thu, 27 Feb 2020 13:55:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=n2jzjZjw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729989AbgB0Vy0 (ORCPT + 99 others); Thu, 27 Feb 2020 16:54:26 -0500 Received: from mail-pj1-f68.google.com ([209.85.216.68]:52613 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729773AbgB0VyZ (ORCPT ); Thu, 27 Feb 2020 16:54:25 -0500 Received: by mail-pj1-f68.google.com with SMTP id ep11so361884pjb.2 for ; Thu, 27 Feb 2020 13:54:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=aWQjRfD263PGFSWLYeye9fWJ9nZRg32z3KxjvyDZXrg=; b=n2jzjZjwu07thEgJQI35ioymXtHOwXo8lvcLzl9cFm9gu60A2HTlJznoMvuFXNQ8CV 36QsZg7nba3Am6zK2Id4yKIbCTcENut1Hg88TbIoSAtcn3/KjhnCDfZBfclCx/0LfLqE tnXsfFxhkwZ8yjF50zmXsoQUTD1pADesZWJLZsMBC6OCbgxlBpUnbwlY5ZJxOctBtYj0 L0W8ndd3c6JrSc8LvVIw/OHUHqqXAMuOkM9/qUKkb6RmfFtX3d5FvnVI/aeoA5wNj3sX V8okCYs+RH0Jq45Hir6Vt8ysQ44eTJNoV2PUjATwkO6w38gdoqrKcGzxAx9WHTsJ8aKM eODQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=aWQjRfD263PGFSWLYeye9fWJ9nZRg32z3KxjvyDZXrg=; b=m2GWIJxJIN8bVv/tvE4IKax4l2GJIgmY1pplr1HBXNfXW8/FW36RxJkLft7seRhOh0 y22PyozwRcFwWRnBzwIDmvAasGpvPNKLYvVEagvxxu/n+1hoHGHZOkxnv+d2raSsR3j1 dAMbXuMLz+n//a6l4pO4s0soqj4Cqjcjx+tP66le9sRQSLWT5zA7Hwpm7uYnjvFrWlpG sOAD/Vpa5ade3DPKqtRyvRVO1eawreF1YidBgTBvk/lLSzQnuFJW+FGm8Myh8MkMISxf cN/i4B4pOXNNT6RJOSNz3jkvb7HzVQnz7gmYHy5/cAxKB7GH2BAOSXHDTCionrvoFJxB g1ew== X-Gm-Message-State: APjAAAXzb4tLu/a8oamkKzuYsQqSymZVjqE/f/yG+8Bly55v2EOENOIC ++28XF6JrjxvMPXSwz4wtqs= X-Received: by 2002:a17:902:444:: with SMTP id 62mr751742ple.209.1582840464193; Thu, 27 Feb 2020 13:54:24 -0800 (PST) Received: from google.com ([2620:15c:211:1:3e01:2939:5992:52da]) by smtp.gmail.com with ESMTPSA id t189sm8248302pfd.168.2020.02.27.13.54.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 13:54:23 -0800 (PST) Date: Thu, 27 Feb 2020 13:54:21 -0800 From: Minchan Kim To: Jules Irenge Cc: linux-kernel@vger.kernel.org, boqun.feng@gmail.com, Nitin Gupta , Sergey Senozhatsky , Andrew Morton , "open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR" Subject: Re: [PATCH 11/30] mm/zsmalloc: Add missing annotation for migrate_read_unlock() Message-ID: <20200227215421.GF215068@google.com> References: <0/30> <20200214204741.94112-1-jbi.octave@gmail.com> <20200214204741.94112-12-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200214204741.94112-12-jbi.octave@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 14, 2020 at 08:47:22PM +0000, Jules Irenge wrote: > Sparse reports a warning at migrate_read_unlock()() > > warning: context imbalance in migrate_read_unlock() - unexpected unlock > > The root cause is the missing annotation at migrate_read_unlock() > Add the missing __releases(&zspage->lock) annotation > > Signed-off-by: Jules Irenge Acked-by: Minchan Kim