Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <7800e98e3688c124ac3672284b87d67321e1c29e.camel@surriel.com>
Subject: Re: [PATCH v2 2/2] mm,thp,compaction,cma: allow THP migration for
 CMA allocations
From:   Rik van Riel <riel@surriel.com>
To:     Mike Kravetz <mike.kravetz@oracle.com>,
        linux-kernel@vger.kernel.org
Cc:     kernel-team@fb.com, akpm@linux-foundation.org, linux-mm@kvack.org,
        mhocko@kernel.org, vbabka@suse.cz, mgorman@techsingularity.net,
        rientjes@google.com, aarcange@redhat.com, ziy@nvidia.com
Date:   Thu, 27 Feb 2020 20:21:38 -0500
In-Reply-To: <df83c62f-209f-b1fd-3a5c-c81c82cb2606@oracle.com>
References: <cover.1582321646.git.riel@surriel.com>
         <20200227213238.1298752-2-riel@surriel.com>
         <df83c62f-209f-b1fd-3a5c-c81c82cb2606@oracle.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-GuN/ZXBkrY1Ye2qQ9BQv"
User-Agent: Evolution 3.34.3 (3.34.3-1.fc31) 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-GuN/ZXBkrY1Ye2qQ9BQv
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2020-02-27 at 15:41 -0800, Mike Kravetz wrote:
> On 2/27/20 1:32 PM, Rik van Riel wrote:
> >=20
> > +++ b/mm/page_alloc.c
> > @@ -8253,14 +8253,19 @@ struct page *has_unmovable_pages(struct
> > zone *zone, struct page *page,
> > =20
> >  		/*
> >  		 * Hugepages are not in LRU lists, but they're movable.
> > +		 * THPs are on the LRU, but need to be counted as
> > #small pages.
> >  		 * We need not scan over tail pages because we don't
> >  		 * handle each tail page individually in migration.
> >  		 */
> > -		if (PageHuge(page)) {
> > +		if (PageHuge(page) || PageTransCompound(page)) {
> >  			struct page *head =3D compound_head(page);
> >  			unsigned int skip_pages;
> > =20
> > -			if
> > (!hugepage_migration_supported(page_hstate(head)))
> > +			if (PageHuge(page) &&
> > +			    !hugepage_migration_supported(page_hstate(h
> > ead)))
> > +				return page;
> > +
> > +			if (!PageLRU(head) && !__PageMovable(head))
>=20
> Pretty sure this is going to be true for hugetlb pages.  So, this
> will change
> behavior and make all hugetlb pages look unmovable.  Perhaps, only
> check this
> condition for THP pages?

Does that need to be the following, then?

     if (PageTransHuge(head) && !PageHuge(page) && !PageLRU(head) &&
!__PageMovable(head))
                 return page;

That's an easy one liner I would be happy to send in
if everybody agrees that should fix things :)

--=20
All Rights Reversed.

--=-GuN/ZXBkrY1Ye2qQ9BQv
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEKR73pCCtJ5Xj3yADznnekoTE3oMFAl5YayIACgkQznnekoTE
3oPx0Af/TX+zEkUxcEv+yrrOG4Jv1BzQ8b6pdaygAYaEH2MhPrSDgprArigLLmWl
2eWVDfgfoNPn1FW1//hUCZREJvTFQDd5UgtrXiCVw3qXt66mI0OfQQ6FtSh9yWM1
YV2D7uzDucuGYd16wFVeOs5XkVtNZk1o1TjCWBi1UVMScPU42HROoG3rrZ3kPEtG
JuXCdAPOq3S3s+PwyBushTVe51LNZCSFjA1lv0Y5viT52TgZU+ugySCme7wOnpb1
mT5UMkrUyjhye2TAqr0h3z8gpTYOG7uX5psZRx77l6eG89IedY/0hOAyk0MgwtSz
iqGb8+FoH3rjeRiXsrQ9JHpc/uW3ug==
=zMII
-----END PGP SIGNATURE-----

--=-GuN/ZXBkrY1Ye2qQ9BQv--