Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From:   David Hildenbrand <david@redhat.com>
Mime-Version: 1.0 (1.0)
Subject: Re: [RFC 2/3] mm: Add a new page flag PageLayzyFree() for MADV_FREE
Date:   Fri, 28 Feb 2020 07:13:33 +0100
Message-Id: <0C8CC772-5840-4F0C-9859-C1D7B8BF6025@redhat.com>
References: <20200228033819.3857058-3-ying.huang@intel.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Dave Hansen <dave.hansen@linux.intel.com>,
        David Hildenbrand <david@redhat.com>,
        Mel Gorman <mgorman@suse.de>, Vlastimil Babka <vbabka@suse.cz>,
        Zi Yan <ziy@nvidia.com>, Michal Hocko <mhocko@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Minchan Kim <minchan@kernel.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Hugh Dickins <hughd@google.com>
In-Reply-To: <20200228033819.3857058-3-ying.huang@intel.com>
To:     "Huang, Ying" <ying.huang@intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> Am 28.02.2020 um 04:38 schrieb Huang, Ying <ying.huang@intel.com>:
>=20
> =EF=BB=BFFrom: Huang Ying <ying.huang@intel.com>
>=20
> Now !PageSwapBacked() is used as the flag for the pages freed lazily
> via MADV_FREE.  This isn't obvious enough.  So Dave suggested to add a
> new page flag for that to improve the code readability.

This patch subject and description is *really* confusing. You=E2=80=98re add=
ing a helper function, not a page flag. It=E2=80=98s a fairly easy refactori=
ng.

(Adding new page flags is close to impossible).

Cheers!=