Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 3/5] ARM: dts: AM33xx-l4: Update PRUSS interconnect
 target-module node
To:     Suman Anna <s-anna@ti.com>, Tony Lindgren <tony@atomide.com>
CC:     Tero Kristo <t-kristo@ti.com>, <linux-omap@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
References: <20200227222837.7329-1-s-anna@ti.com>
 <20200227222837.7329-4-s-anna@ti.com>
From:   Roger Quadros <rogerq@ti.com>
Message-ID: <73ed421b-6786-8f4c-86b1-db4d9cb26bb8@ti.com>
Date:   Fri, 28 Feb 2020 10:33:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200227222837.7329-4-s-anna@ti.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 28/02/2020 00:28, Suman Anna wrote:
> The PRU-ICSS present on some AM33xx SoCs has a very unique SYSC
> register. The IP also uses a hard-reset line, and requires this
> PRCM reset to be deasserted to be able to access any registers.
> Update the existing PRUSS interconnect target-module with all
> the required properties.
> 
> The PRUSS device itself shall be added as a child node to this
> interconnect node in the future. PRU-ICSS is not supported on
> AM3351/AM3352/AM3354 SoCs though in the AM33xx family, so the
> target module node should be disabled in derivative board files
> that use any of these SoCs.
> 
> Signed-off-by: Suman Anna <s-anna@ti.com>

Reviewed-by: Roger Quadros <rogerq@ti.com>

> ---
> v2: Revise patch description, no code changes
> 
>   arch/arm/boot/dts/am33xx-l4.dtsi | 21 ++++++++++++++++++---
>   1 file changed, 18 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi
> index 4e2986f0c604..5ed7f3c58c0f 100644
> --- a/arch/arm/boot/dts/am33xx-l4.dtsi
> +++ b/arch/arm/boot/dts/am33xx-l4.dtsi
> @@ -759,12 +759,27 @@
>   			ranges = <0x0 0x200000 0x80000>;
>   		};
>   
> -		target-module@300000 {			/* 0x4a300000, ap 9 04.0 */
> -			compatible = "ti,sysc";
> -			status = "disabled";
> +		pruss_tm: target-module@300000 {	/* 0x4a300000, ap 9 04.0 */
> +			compatible = "ti,sysc-pruss", "ti,sysc";
> +			reg = <0x326000 0x4>,
> +			      <0x326004 0x4>;
> +			reg-names = "rev", "sysc";
> +			ti,sysc-mask = <(SYSC_PRUSS_STANDBY_INIT |
> +					 SYSC_PRUSS_SUB_MWAIT)>;
> +			ti,sysc-midle = <SYSC_IDLE_FORCE>,
> +					<SYSC_IDLE_NO>,
> +					<SYSC_IDLE_SMART>;
> +			ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> +					<SYSC_IDLE_NO>,
> +					<SYSC_IDLE_SMART>;
> +			clocks = <&pruss_ocp_clkctrl AM3_PRUSS_OCP_PRUSS_CLKCTRL 0>;
> +			clock-names = "fck";
> +			resets = <&prm_per 1>;
> +			reset-names = "rstctrl";
>   			#address-cells = <1>;
>   			#size-cells = <1>;
>   			ranges = <0x0 0x300000 0x80000>;
> +			status = "disabled";
>   		};
>   	};
>   };
> 

-- 
cheers,
-roger
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki