Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp466875ybf; Fri, 28 Feb 2020 01:23:59 -0800 (PST) X-Google-Smtp-Source: APXvYqzs0Uf8Vwbiy9UgRDkRbmiLjDgYiV2jfST/t9EdncPImid576rretp3dEGFGmPOFwWq7Bwo X-Received: by 2002:aca:4587:: with SMTP id s129mr2369284oia.124.1582881839407; Fri, 28 Feb 2020 01:23:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582881839; cv=none; d=google.com; s=arc-20160816; b=IWUdJ8F5amO1cLs2fRGqF0o+F64ChL9gsShsbfiJtwFMGcweBSkS+IVJBHIojGYsxo dr2COUgmrxlTlvjfZV3ejjiDWmScUS4w5Wx3rbGkwZshOPHLh/sY0UCTQe9FlCFv6ipM 49LKWM+6jsP/Tn/wpat0FbEHUEz7NbDF6pAMFEiyYe1HmYKdWnQm2U3mZmSm4bQV6shy JWUWBh73q7hc049Wu2Ru68uzex0xQKNXXHy1/74/Ml7x03xSGSoIopNVw9fTvQtAdXmE c/cIaEgkKW7V9rHuv/61J2K5QFbwF8MPdTYIheQ5yzz8ZeJ9doC2IFfkMql8uSDGX/tS XqIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=nZWlIAb25RKmpdimMBAR/YlDxxn7XYHb1GVQxtT07sg=; b=gpLxX7hQPy8cmpHKrAwZjKAZJBrQuIaLcba2Hee5aXhtxWSLr1fvDwwQ0Jwyh3TvJ4 RoQEghmSKBKL87eolF6I3vOXKBTW1CRXYAEIXXD8vFsltyBDDoEkiMHqtzlijfDErXeD AXceGzwEYCUQ4BZWBbzplA+WhltDDM3mGCHItgTfNDlcDrHl4BzLH//t6XWoo8FLLxL4 IniHlVZYnFBsNmSVO1HtIM0R79NPvr0FNGRK9448uzrxTrazPeJ872nhoeGf4rkZXqre rJWwPcg+Kr/yzKqJ/Z0iFtbln27Qyt/7rKp8DsQnQuCIFmD1nn7fykML2itipSS15aAl +V/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=VA8FU8oS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s9si1434258oij.78.2020.02.28.01.23.46; Fri, 28 Feb 2020 01:23:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=VA8FU8oS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726714AbgB1JXk (ORCPT + 99 others); Fri, 28 Feb 2020 04:23:40 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:57700 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726400AbgB1JXj (ORCPT ); Fri, 28 Feb 2020 04:23:39 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01S9HpmW025441; Fri, 28 Feb 2020 09:23:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2020-01-29; bh=nZWlIAb25RKmpdimMBAR/YlDxxn7XYHb1GVQxtT07sg=; b=VA8FU8oSws/28udQzHALpUPBiYzyBnUjB5OAFd2W3yXTsz118oZnNZsuTwpOwKb89XWf SHT4LG5++yWxPCqsw9eyKPCdwbNKCITTl9uHyAD3wLfBvLdanup70G6ZqjedO/6xKlhO 780qHl4zrIskSfsbZCJ7y1Zxepjr/VSj8AzpeXjiM/9yYyRZzOdtbBSyhM/gtcuIlPZq zbEoDDF4uJVM4PqF5RNirWICCyzW3L/89CVq6cb98ckizL0IVpSqp1xV2P/2dSU+pdcb FkvjYhqpdnkp4be+kZlhBRVfSJQ53WFW+uzH6h7528ncGWzaD8uyN4Q9FC+HYVQmZPYf 1w== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 2yehxrw3sb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 28 Feb 2020 09:23:31 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01S9MMeF121341; Fri, 28 Feb 2020 09:23:30 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 2ydcsdfhr6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 28 Feb 2020 09:23:30 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 01S9NS4V026416; Fri, 28 Feb 2020 09:23:28 GMT Received: from kili.mountain (/129.205.23.165) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 28 Feb 2020 01:23:27 -0800 Date: Fri, 28 Feb 2020 12:23:21 +0300 From: Dan Carpenter To: Maarten Lankhorst Cc: Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] drm: prevent a harmless integer overflow in drm_legacy_sg_alloc() Message-ID: <20200228092321.axulddmkxrujkmas@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9544 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 phishscore=0 mlxlogscore=999 spamscore=0 suspectscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002280078 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9544 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 priorityscore=1501 bulkscore=0 phishscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 adultscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002280077 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is an integer overflow when we round up to PAGE_SIZE, but it's harmless because we never re-use "request->size" for anything meaningful. Signed-off-by: Dan Carpenter --- This code predates git. drivers/gpu/drm/drm_scatter.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_scatter.c b/drivers/gpu/drm/drm_scatter.c index d5c386154246..ca520028b2cb 100644 --- a/drivers/gpu/drm/drm_scatter.c +++ b/drivers/gpu/drm/drm_scatter.c @@ -99,6 +99,9 @@ int drm_legacy_sg_alloc(struct drm_device *dev, void *data, if (!drm_core_check_feature(dev, DRIVER_SG)) return -EOPNOTSUPP; + if (request->size > SIZE_MAX - PAGE_SIZE) + return -EINVAL; + if (dev->sg) return -EINVAL; -- 2.11.0