Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>
To:     Luigi Rizzo <lrizzo@google.com>, netdev@vger.kernel.org,
        davem@davemloft.net, hawk@kernel.org, sameehj@amazon.com
Cc:     linux-kernel@vger.kernel.org, Luigi Rizzo <lrizzo@google.com>
Subject: Re: [PATCH v3 net-next] netdev attribute to control xdpgeneric skb linearization
In-Reply-To: <20200227173428.5298-1-lrizzo@google.com>
References: <20200227173428.5298-1-lrizzo@google.com>
Date:   Fri, 28 Feb 2020 11:16:36 +0100
Message-ID: <87h7zbuid7.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Luigi Rizzo <lrizzo@google.com> writes:

> Add a netdevice flag to control skb linearization in generic xdp mode.
>
> The attribute can be modified through
> 	/sys/class/net/<DEVICE>/xdp_linearize
> The default is 1 (on)

Calling it just 'xdp_linearize' implies (to me) that it also affects
driver-mode XDP. So maybe generic_xdp_linearize ?

[...]

> +
> +What:		/sys/class/net/<iface>/xdp_linearize
> +Date:		Jan 2020
> +KernelVersion:	5.6
> +Contact:	netdev@vger.kernel.org
> +Description:
> +		boolean controlling whether skb should be linearized in
> +		generic xdp. Defaults to true.

Could you also add a few words explaining what the tradeoff here is?
Something like: "turning this off can increase the performance of
generic XDP at the cost of making the content of making the XDP program
unable to access packet fragments after the first one"

-Toke