Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 28 Feb 2020 13:12:36 +0100
From:   Michal Kubecek <mkubecek@suse.cz>
To:     netdev@vger.kernel.org
Cc:     Luigi Rizzo <lrizzo@google.com>, toke@redhat.com,
        davem@davemloft.net, hawk@kernel.org, sameehj@amazon.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] netdev attribute to control xdpgeneric skb
 linearization
Message-ID: <20200228121236.GG6835@unicorn.suse.cz>
References: <20200228105435.75298-1-lrizzo@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200228105435.75298-1-lrizzo@google.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Feb 28, 2020 at 02:54:35AM -0800, Luigi Rizzo wrote:
> Add a netdevice flag to control skb linearization in generic xdp mode.
> 
> The attribute can be modified through
> 	/sys/class/net/<DEVICE>/xdpgeneric_linearize
> The default is 1 (on)

I'm a bit surprised that it didn't appear in earlier rounds of review
but I believe (rt)netlink is generally preferred configuration interface
for network device attributes. Making a new attribute accessible only
through sysfs doesn't seem right. (But it's not my call to make.)

Michal