Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp614797ybf; Fri, 28 Feb 2020 04:30:20 -0800 (PST) X-Google-Smtp-Source: APXvYqx1fBBpfiUQvKV5Fd5wctzmh/j3S52dchWudyOFZhfDeYjC0353PJLVglQ6GxDwuz8fpxQP X-Received: by 2002:aca:af49:: with SMTP id y70mr1183765oie.92.1582893020189; Fri, 28 Feb 2020 04:30:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582893020; cv=none; d=google.com; s=arc-20160816; b=Ed0pOnQiI7+QM6oXFPO4ObsO97yzYnePu3zsDhIa7TVQkpY+X0OAttNyMHM/pRXkpe u+0iOv9RhVUwcx1bes6mKFvv4eEGXIUaPVVSYunjyAH4HRaFWu5KhOai9YGsFQWnHDD4 LCuso3wucVvgY+qnqYy4VBQiIrtNNHAibj3jBPD5VAX8mc4AjjZjIjymiDeZFzZhhSku r94uci4ChVlJGqJh8AxH7akZY97qmYwtx2wCOvU82vOxXYVbKwLsLe9yqfDMfSpT+WyL KmwMddNWGM4F2zK/zEV5UIlE7SfNYuL6NGRwnH08eq7xXXoNAOSvjUFSc4QdsjPcPO1X dx6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=5/CKKzpFbreU0OMtvAw+wBkJ7+z4oVGyCnkh7UnzzUc=; b=HKIgUd0q2aOAqt8nT9DE0xm6W/x8AZfK7B5rS9+LHI4lcmdkZ838c4zjPuQ7TPSBlE GxB9dKox3D9uSXQGdMZyE1REPnSkHsJRZVUseml1YkW0lK/0hf/AUq7PF5W3QDq/0xse VMSOLphuJ8EcLDW0C4uRzxDjTIBilABoiYv40eYgwj+IjG43ztmHJWAe99DJ41ntlKx7 nOoNguhcZKwAGsYKLupzQPKuRKk0bxlT6YwhkT4/YRHLX3gLINWnTT3CtkiwcY94Q+me xZuDBzpQNMTxCR6dfZfObK9e9xMVZw7R3EfUvCqVImZyRrjXe2qEoFFrbKABik1H2Bze qJmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aRK8RvuN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s6si1503592otq.115.2020.02.28.04.30.07; Fri, 28 Feb 2020 04:30:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aRK8RvuN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725943AbgB1M35 (ORCPT + 99 others); Fri, 28 Feb 2020 07:29:57 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:60565 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725730AbgB1M34 (ORCPT ); Fri, 28 Feb 2020 07:29:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582892995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5/CKKzpFbreU0OMtvAw+wBkJ7+z4oVGyCnkh7UnzzUc=; b=aRK8RvuN6+iWq6muLH707J39wys5tayH/zU+13XXaGAuljSo1KER7f3Y7IIb9zT/sr8lCP TPEvcFT3GOz3nylWEqJliNEqtbccOQhVjkec12/PZjL0I24qArXJDUHerfAk+mlbehtU8j l1wpqcLSKU/1v8Wpv07gVOzXH/gzJ6w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-263-qfCMnb08OkGv40O0IKxkTQ-1; Fri, 28 Feb 2020 07:29:53 -0500 X-MC-Unique: qfCMnb08OkGv40O0IKxkTQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 982ED18A6ECC; Fri, 28 Feb 2020 12:29:51 +0000 (UTC) Received: from carbon (ovpn-200-19.brq.redhat.com [10.40.200.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 680E460BE0; Fri, 28 Feb 2020 12:29:46 +0000 (UTC) Date: Fri, 28 Feb 2020 13:29:41 +0100 From: Jesper Dangaard Brouer To: Luigi Rizzo Cc: netdev@vger.kernel.org, toke@redhat.com, davem@davemloft.net, hawk@kernel.org, sameehj@amazon.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] netdev attribute to control xdpgeneric skb linearization Message-ID: <20200228132941.2c8b8d01@carbon> In-Reply-To: <20200228105435.75298-1-lrizzo@google.com> References: <20200228105435.75298-1-lrizzo@google.com> Organization: Red Hat Inc. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Feb 2020 02:54:35 -0800 Luigi Rizzo wrote: > diff --git a/net/core/dev.c b/net/core/dev.c > index dbbfff123196..c539489d3166 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -4520,9 +4520,12 @@ static u32 netif_receive_generic_xdp(struct sk_buff *skb, > /* XDP packets must be linear and must have sufficient headroom > * of XDP_PACKET_HEADROOM bytes. This is the guarantee that also > * native XDP provides, thus we need to do it here as well. > + * For non shared skbs, xdpgeneric_linearize controls linearization. > */ > - if (skb_cloned(skb) || skb_is_nonlinear(skb) || > - skb_headroom(skb) < XDP_PACKET_HEADROOM) { > + if (skb_cloned(skb) || > + (skb->dev->xdpgeneric_linearize && > + (skb_is_nonlinear(skb) || > + skb_headroom(skb) < XDP_PACKET_HEADROOM))) { > int hroom = XDP_PACKET_HEADROOM - skb_headroom(skb); > int troom = skb->tail + skb->data_len - skb->end; > Have you checked that calling bpf_xdp_adjust_tail() is not breaking anything? -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer