Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp616978ybf; Fri, 28 Feb 2020 04:32:41 -0800 (PST) X-Google-Smtp-Source: APXvYqydn/HjeDVNJphDMAWutpg1sZHQNWlS23gJYgj1NHiB4f6JNWmj+oiIWBR1aA8QjnPPpVS5 X-Received: by 2002:aca:d483:: with SMTP id l125mr2909743oig.124.1582893161139; Fri, 28 Feb 2020 04:32:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582893161; cv=none; d=google.com; s=arc-20160816; b=QhxeqSd/0IooHTkwYdrenAoV1FxLTrtWGJiWLHi+XRKt1tj2uBN8AxIQRFiupx8pZ/ 0ORqus/2wtXcUS9Dwvj47D6Y4f29dWnoCwR+VeBCqnT9r+o49GuqE4kWAAC2g666Nb2T nVkikbWr6i0QWjGDsBV4QPzx5qLTKan2R2/GZkpuPyKshOw8IhkCUIe0cXhlbCk/19yn kYXEuvm9Z3ONzzdSYoXm4cSdcxSq9qr7Pmw4L2aa5Stwjp08tgIrhRcQ4JfjM5Hrhrbv YmjGJV+TlrfMFN2bidKTP03JLXT6a1S7HWiSEwH+mJIF1dAa0yqdvco7Ot88qnWIA4O6 sTGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=2RooJPrqf81zft4ke8YUUk8aT1Ot7fHdQHDbAT/pgK0=; b=oCgTcy5eGlZ2iWPfACA+Iqj+IFeFlQp/5X6l04qMx/QWG98gsDpIFHayBYO121DTX6 2+lK7ha7OJgNEST6ZS35pj5TkPKQvcdQwyBta2YpDOtV/zaQBSIbmwvwak/oxONW+Sg0 8TSIhhoJJVHP0+29A4tRjZYuco8hEhSSm0fBgCJb9hMuGaTPxTcMf53GmjRdKTKnZIYk 8R6eGlehqiHyeL0EQTu3F7OLLD4khTzAl9Y8/wivkDAd3QcISJzs5KPkUFERI7M1sw/L PUl1HT+KKmwDcste2E8O15DC43cU0IvBlo8v4VU40/hD4jCQzq/FAFZh5xlUXbDFQJL1 aUhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NwOPK07i; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h2si1678838oie.151.2020.02.28.04.32.28; Fri, 28 Feb 2020 04:32:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NwOPK07i; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726400AbgB1MbI (ORCPT + 99 others); Fri, 28 Feb 2020 07:31:08 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:38897 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725802AbgB1MbH (ORCPT ); Fri, 28 Feb 2020 07:31:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582893066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2RooJPrqf81zft4ke8YUUk8aT1Ot7fHdQHDbAT/pgK0=; b=NwOPK07i7IoY2NLS+1PZcsr+CC3IpVbfgJxPwhAE5S1uJfK1+YL0KVRe9NNh+LkpHhTVio ua2p4vVPxxyg3T05a42OyITV42c9cL2DkSM1ppCpmzCeZHNeZdmlEtLN7+rUeyryAlnL8C sN7OM0rGshH3+dBQbnyST+ZpPQgJRG8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-197-xA0PywavMw-iwRf2hXkv3g-1; Fri, 28 Feb 2020 07:31:05 -0500 X-MC-Unique: xA0PywavMw-iwRf2hXkv3g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A185C108C314; Fri, 28 Feb 2020 12:31:03 +0000 (UTC) Received: from carbon (ovpn-200-19.brq.redhat.com [10.40.200.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D1056E3EE; Fri, 28 Feb 2020 12:30:55 +0000 (UTC) Date: Fri, 28 Feb 2020 13:30:54 +0100 From: Jesper Dangaard Brouer To: Luigi Rizzo Cc: brouer@redhat.com, netdev@vger.kernel.org, toke@redhat.com, davem@davemloft.net, sameehj@amazon.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] netdev attribute to control xdpgeneric skb linearization Message-ID: <20200228133054.47cc4d71@carbon> In-Reply-To: <20200228105435.75298-1-lrizzo@google.com> References: <20200228105435.75298-1-lrizzo@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Feb 2020 02:54:35 -0800 Luigi Rizzo wrote: > diff --git a/net/core/dev.c b/net/core/dev.c > index dbbfff123196..c539489d3166 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -4520,9 +4520,12 @@ static u32 netif_receive_generic_xdp(struct sk_buff *skb, > /* XDP packets must be linear and must have sufficient headroom > * of XDP_PACKET_HEADROOM bytes. This is the guarantee that also > * native XDP provides, thus we need to do it here as well. > + * For non shared skbs, xdpgeneric_linearize controls linearization. > */ > - if (skb_cloned(skb) || skb_is_nonlinear(skb) || > - skb_headroom(skb) < XDP_PACKET_HEADROOM) { > + if (skb_cloned(skb) || > + (skb->dev->xdpgeneric_linearize && > + (skb_is_nonlinear(skb) || > + skb_headroom(skb) < XDP_PACKET_HEADROOM))) { > int hroom = XDP_PACKET_HEADROOM - skb_headroom(skb); > int troom = skb->tail + skb->data_len - skb->end; Have you checked that calling bpf_xdp_adjust_tail() is not breaking anything? -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer