Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <463BBB2A-8F9A-4CF1-80AE-677ACD21A3C6@lca.pw>
In-Reply-To: <463BBB2A-8F9A-4CF1-80AE-677ACD21A3C6@lca.pw>
From:   Marco Elver <elver@google.com>
Date:   Fri, 28 Feb 2020 13:43:32 +0100
Message-ID: <CANpmjNNyQ0vGAsSXCLkLtjvEVbq3T5kNnsg+T3XV-qBPCZ8FHw@mail.gmail.com>
Subject: Re: [PATCH] mm/swap: annotate data races for lru_rotate_pvecs
To:     Qian Cai <cai@lca.pw>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>,
        kasan-dev <kasan-dev@googlegroups.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 28 Feb 2020 at 12:30, Qian Cai <cai@lca.pw> wrote:
>
>
>
> > On Feb 28, 2020, at 5:49 AM, Marco Elver <elver@google.com> wrote:
> >
> > Note that, the fact that the writer has local interrupts disabled for
> > the write is irrelevant because it's the interrupt that triggered
> > while the read was happening that led to the concurrent write.
>
> I was just to explain that concurrent writers are rather unlikely as people may ask.
>
> >
> > I assume you ran this with CONFIG_KCSAN_INTERRUPT_WATCHER=y?  The
> > option is disabled by default (see its help-text). I don't know if we
> > want to deal with data races due to interrupts right now, especially
> > those that just result in 'data_race' annotations. Thoughts?
>
> Yes, I somehow got quite a bit clean runs lately thanks to the fix/annotations efforts for the last a few weeks (still struggling with the flags things a bit), so I am naturally expanding the testing coverage here.
>
> Right now the bottleneck is rather some subsystem maintainers are not so keen to deal with data races (looking forward to seeing more education opportunities for all), but the MM subsystem is not one of them.

Sounds reasonable.  FWIW

Acked-by: Marco Elver <elver@google.com>