Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp628719ybf; Fri, 28 Feb 2020 04:46:46 -0800 (PST) X-Google-Smtp-Source: APXvYqxhR1BgH0CbA6WTQqJWOjvzBVkTggWpSQPzc9Fuv5MrUZgkRWPhMeelYvgZzmJpv9TO3p5z X-Received: by 2002:a05:6808:4d3:: with SMTP id a19mr2788021oie.119.1582894006565; Fri, 28 Feb 2020 04:46:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582894006; cv=none; d=google.com; s=arc-20160816; b=d2h7z0MX30Eg78zUtkhgmRjip99lNgYA2MWziFCy/QIXZkfVwexhdcDe0sY9q3hi39 Hii18oKVQLu5gruxTDIuNUbrCbHcstYkVvm4Arbvvk+4nVdQzBNpNe+GVZGqNeanu4Wt yHEmkLdutwXHiBievYsJsOmVD6o4dSAJ2X7X6R/ha0sPRHMC9LGDDaAfk6SAQGM4o2vn CWsuGa+29y41hBqGllbcqKfw1iajwLtnmZbuSac1gvQXkAQAGujwno8iIapSGGCgI8zE y8CJ+7pmCicNquloAvUul3I4DKJewKowCFX4KclHmzU4JxRHmgQlUwKKQ3Wl4It57Omd RUkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:mime-version:user-agent:date:message-id:subject :autocrypt:from:cc:to; bh=do43bDtGB3qqHFVw23zNBk87jYLcuvth3O0g8EfD2hw=; b=og6nxBzNiQH0HaxtjDYoFw2BXhuZpEPfjvEo0ygYlxcGpZsa8/MfYKDE0T4+/cWa36 Ce/lxepcEIIX9GR6jlQpIyhc0P83WXekDNyEErpBkW6pavke758FvSr0OXLcLKx0yJFb wS2j/fEgm6hOwQlroRTr5p7+iBxRK/7WMcSSesw+a5w+tyeJy9jyR1rJk2U5MOiJLHpu f+uo9WioUGOTFNdK07XTOxyraOQrFdAjImucRBKcvPh+hJWSO0TreCLuhf8x5PPNZq8x 2AY7VyNSNDMRy77Ww1dJb75Bv3ZfyPhJhV0pP9ElvZTkNiqNneWxUQdMaipyR2ARlxA8 UTvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p11si1573129ota.300.2020.02.28.04.46.34; Fri, 28 Feb 2020 04:46:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726579AbgB1MqP (ORCPT + 99 others); Fri, 28 Feb 2020 07:46:15 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:45246 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725900AbgB1MqO (ORCPT ); Fri, 28 Feb 2020 07:46:14 -0500 Received: from [82.43.126.140] (helo=[192.168.0.11]) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1j7f1w-0005r1-H0; Fri, 28 Feb 2020 12:46:12 +0000 To: Ilya Dryomov , Jeff Layton , Sage Weil , ceph-devel@vger.kernel.org Cc: "linux-kernel@vger.kernel.org" From: Colin Ian King Autocrypt: addr=colin.king@canonical.com; prefer-encrypt=mutual; keydata= mQINBE6TJCgBEACo6nMNvy06zNKj5tiwDsXXS+LhT+LwtEsy9EnraKYXAf2xwazcICSjX06e fanlyhB0figzQO0n/tP7BcfMVNG7n1+DC71mSyRK1ZERcG1523ajvdZOxbBCTvTitYOy3bjs +LXKqeVMhK3mRvdTjjmVpWnWqJ1LL+Hn12ysDVVfkbtuIm2NoaSEC8Ae8LSSyCMecd22d9Pn LR4UeFgrWEkQsqROq6ZDJT9pBLGe1ZS0pVGhkRyBP9GP65oPev39SmfAx9R92SYJygCy0pPv BMWKvEZS/7bpetPNx6l2xu9UvwoeEbpzUvH26PHO3DDAv0ynJugPCoxlGPVf3zcfGQxy3oty dNTWkP6Wh3Q85m+AlifgKZudjZLrO6c+fAw/jFu1UMjNuyhgShtFU7NvEzL3RqzFf9O1qM2m uj83IeFQ1FZ65QAiCdTa3npz1vHc7N4uEQBUxyXgXfCI+A5yDnjHwzU0Y3RYS52TA3nfa08y LGPLTf5wyAREkFYou20vh5vRvPASoXx6auVf1MuxokDShVhxLpryBnlKCobs4voxN54BUO7m zuERXN8kadsxGFzItAyfKYzEiJrpUB1yhm78AecDyiPlMjl99xXk0zs9lcKriaByVUv/NsyJ FQj/kmdxox3XHi9K29kopFszm1tFiDwCFr/xumbZcMY17Yi2bQARAQABtCVDb2xpbiBLaW5n IDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+iQI2BBMBCAAhBQJOkyQoAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEGjCh9/GqAImsBcP9i6C/qLewfi7iVcOwqF9avfGzOPf7CVr n8CayQnlWQPchmGKk6W2qgnWI2YLIkADh53TS0VeSQ7Tetj8f1gV75eP0Sr/oT/9ovn38QZ2 vN8hpZp0GxOUrzkvvPjpH+zdmKSaUsHGp8idfPpZX7XeBO0yojAs669+3BrnBcU5wW45SjSV nfmVj1ZZj3/yBunb+hgNH1QRcm8ZPICpjvSsGFClTdB4xu2AR28eMiL/TTg9k8Gt72mOvhf0 fS0/BUwcP8qp1TdgOFyiYpI8CGyzbfwwuGANPSupGaqtIRVf+/KaOdYUM3dx/wFozZb93Kws gXR4z6tyvYCkEg3x0Xl9BoUUyn9Jp5e6FOph2t7TgUvv9dgQOsZ+V9jFJplMhN1HPhuSnkvP 5/PrX8hNOIYuT/o1AC7K5KXQmr6hkkxasjx16PnCPLpbCF5pFwcXc907eQ4+b/42k+7E3fDA Erm9blEPINtt2yG2UeqEkL+qoebjFJxY9d4r8PFbEUWMT+t3+dmhr/62NfZxrB0nTHxDVIia u8xM+23iDRsymnI1w0R78yaa0Eea3+f79QsoRW27Kvu191cU7QdW1eZm05wO8QUvdFagVVdW Zg2DE63Fiin1AkGpaeZG9Dw8HL3pJAJiDe0KOpuq9lndHoGHs3MSa3iyQqpQKzxM6sBXWGfk EkK5Ag0ETpMkKAEQAMX6HP5zSoXRHnwPCIzwz8+inMW7mJ60GmXSNTOCVoqExkopbuUCvinN 4Tg+AnhnBB3R1KTHreFGoz3rcV7fmJeut6CWnBnGBtsaW5Emmh6gZbO5SlcTpl7QDacgIUuT v1pgewVHCcrKiX0zQDJkcK8FeLUcB2PXuJd6sJg39kgsPlI7R0OJCXnvT/VGnd3XPSXXoO4K cr5fcjsZPxn0HdYCvooJGI/Qau+imPHCSPhnX3WY/9q5/WqlY9cQA8tUC+7mgzt2VMjFft1h rp/CVybW6htm+a1d4MS4cndORsWBEetnC6HnQYwuC4bVCOEg9eXMTv88FCzOHnMbE+PxxHzW 3Gzor/QYZGcis+EIiU6hNTwv4F6fFkXfW6611JwfDUQCAHoCxF3B13xr0BH5d2EcbNB6XyQb IGngwDvnTyKHQv34wE+4KtKxxyPBX36Z+xOzOttmiwiFWkFp4c2tQymHAV70dsZTBB5Lq06v 6nJs601Qd6InlpTc2mjd5mRZUZ48/Y7i+vyuNVDXFkwhYDXzFRotO9VJqtXv8iqMtvS4xPPo 2DtJx6qOyDE7gnfmk84IbyDLzlOZ3k0p7jorXEaw0bbPN9dDpw2Sh9TJAUZVssK119DJZXv5 2BSc6c+GtMqkV8nmWdakunN7Qt/JbTcKlbH3HjIyXBy8gXDaEto5ABEBAAGJAh8EGAEIAAkF Ak6TJCgCGwwACgkQaMKH38aoAiZ4lg/+N2mkx5vsBmcsZVd3ys3sIsG18w6RcJZo5SGMxEBj t1UgyIXWI9lzpKCKIxKx0bskmEyMy4tPEDSRfZno/T7p1mU7hsM4owi/ic0aGBKP025Iok9G LKJcooP/A2c9dUV0FmygecRcbIAUaeJ27gotQkiJKbi0cl2gyTRlolKbC3R23K24LUhYfx4h pWj8CHoXEJrOdHO8Y0XH7059xzv5oxnXl2SD1dqA66INnX+vpW4TD2i+eQNPgfkECzKzGj+r KRfhdDZFBJj8/e131Y0t5cu+3Vok1FzBwgQqBnkA7dhBsQm3V0R8JTtMAqJGmyOcL+JCJAca 3Yi81yLyhmYzcRASLvJmoPTsDp2kZOdGr05Dt8aGPRJL33Jm+igfd8EgcDYtG6+F8MCBOult TTAu+QAijRPZv1KhEJXwUSke9HZvzo1tNTlY3h6plBsBufELu0mnqQvHZmfa5Ay99dF+dL1H WNp62+mTeHsX6v9EACH4S+Cw9Q1qJElFEu9/1vFNBmGY2vDv14gU2xEiS2eIvKiYl/b5Y85Q QLOHWV8up73KK5Qq/6bm4BqVd1rKGI9un8kezUQNGBKre2KKs6wquH8oynDP/baoYxEGMXBg GF/qjOC6OY+U7kNUW3N/A7J3M2VdOTLu3hVTzJMZdlMmmsg74azvZDV75dUigqXcwjE= Subject: re: libceph: follow redirect replies from osds Message-ID: <6ea7e486-a3f3-7def-1f88-2e645e3b9780@canonical.com> Date: Fri, 28 Feb 2020 12:46:11 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Static analysis with Coverity has detected a potential issue in the following commit in function ceph_redirect_decode(): commit 205ee1187a671c3b067d7f1e974903b44036f270 Author: Ilya Dryomov Date: Mon Jan 27 17:40:20 2014 +0200 libceph: follow redirect replies from osds The issue is as follows: 3486 len = ceph_decode_32(p); Unused value (UNUSED_VALUE) assigned_pointer: Assigning value from len to *p here, but that stored value is overwritten before it can be used. 3487 *p += len; /* skip osd_instructions */ 3488 3489 /* skip the rest */ value_overwrite: Overwriting previous write to *p with value from struct_end. 3490 *p = struct_end; The *p assignment in line 3487 is effectively being overwritten by the *p assignment in 3490. Maybe the following is correct: len = ceph_decode_32(p); - p += len; /* skip osd_instructions */ + struct_end = *p + len; /* skip osd_instructions */ /* skip the rest */ *p = struct_end; I'm not familiar with the ceph structure here, so I'm not sure what the correct fix would be. Colin