Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030315AbWBMXxg (ORCPT ); Mon, 13 Feb 2006 18:53:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030310AbWBMXxg (ORCPT ); Mon, 13 Feb 2006 18:53:36 -0500 Received: from mx1.redhat.com ([66.187.233.31]:1740 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1030306AbWBMXxe (ORCPT ); Mon, 13 Feb 2006 18:53:34 -0500 Date: Mon, 13 Feb 2006 18:52:44 -0500 From: Dave Jones To: linux-kernel@vger.kernel.org Cc: davi.arnaut@gmail.com, len.brown@intel.com, pavel@ucw.cz, mm-commits@vger.kernel.org Subject: Re: + acpi_os_acquire_object-gfp_kernel-called-with-irqs.patch added to -mm tree Message-ID: <20060213235244.GA11200@redhat.com> Mail-Followup-To: Dave Jones , linux-kernel@vger.kernel.org, davi.arnaut@gmail.com, len.brown@intel.com, pavel@ucw.cz, mm-commits@vger.kernel.org References: <200602132314.k1DNElaA011901@shell0.pdx.osdl.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200602132314.k1DNElaA011901@shell0.pdx.osdl.net> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5746 Lines: 103 On Mon, Feb 13, 2006 at 03:13:55PM -0800, Andrew Morton wrote: > The patch titled > > acpi_os_acquire_object (GFP_KERNEL) called with IRQs disabled through suspend-resume > > has been added to the -mm tree. Its filename is > > acpi_os_acquire_object-gfp_kernel-called-with-irqs.patch > > From: Davi Arnaut > > acpi_os_acquire_object() gets called, with IRQs disabled, from: > > Debug: sleeping function called from invalid context at mm/slab.c:2499 > in_atomic():0, irqs_disabled():1 > [] kmem_cache_alloc+0x40/0x4f [] acpi_os_acquire_object+0xb/0x3c > [] acpi_ut_allocate_object_desc_dbg+0x13/0x49 [] acpi_ut_create_internal_object_dbg+0xf/0x5e > [] acpi_rs_set_srs_method_data+0x3d/0xb9 [] acpi_pci_link_set+0x102/0x17b > [] irqrouter_resume+0x1e/0x3c [] __sysdev_resume+0x11/0x6b > [] sysdev_resume+0x34/0x52 [] device_power_up+0x5/0xa > [] suspend_enter+0x44/0x46 [] suspend_prepare+0x63/0xc1 > [] enter_state+0x5e/0x7c [] state_store+0x81/0x8f > [] state_store+0x0/0x8f [] subsys_attr_store+0x1e/0x22 > [] flush_write_buffer+0x22/0x28 [] sysfs_write_file+0x4c/0x71 > [] sysfs_write_file+0x0/0x71 [] vfs_write+0xa2/0x15a > [] sys_write+0x41/0x6a [] syscall_call+0x7/0xb > > The patch also fixes a missing check for NULL return from > acpi_os_acquire_object(). > > Signed-off-by: Davi Arnaut > Cc: "Brown, Len" > Cc: Pavel Machek > Signed-off-by: Andrew Morton > --- > > drivers/acpi/osl.c | 2 +- > drivers/acpi/parser/psutils.c | 8 ++++++-- > 2 files changed, 7 insertions(+), 3 deletions(-) > > diff -puN drivers/acpi/osl.c~acpi_os_acquire_object-gfp_kernel-called-with-irqs drivers/acpi/osl.c > --- devel/drivers/acpi/osl.c~acpi_os_acquire_object-gfp_kernel-called-with-irqs 2006-02-13 15:13:26.000000000 -0800 > +++ devel-akpm/drivers/acpi/osl.c 2006-02-13 15:13:26.000000000 -0800 > @@ -1175,7 +1175,7 @@ acpi_status acpi_os_release_object(acpi_ > > void *acpi_os_acquire_object(acpi_cache_t * cache) > { > - void *object = kmem_cache_alloc(cache, GFP_KERNEL); > + void *object = kmem_cache_alloc(cache, GFP_ATOMIC); > WARN_ON(!object); > return object; > } This is potentially a lot of atomic allocations. acpi_os_acquire_object is called by.. drivers/acpi/parser/psutils.c acpi_ps_alloc_op() drivers/acpi/utilities/utobject.c: acpi_ut_allocate_object_desc_dbg() drivers/acpi/utilities/utstate.c: acpi_ut_create_generic_state() Those three functions are called all over the place in acpi. drivers/acpi/dispatcher/dsmethod.c: op = acpi_ps_alloc_op(AML_METHOD_OP); drivers/acpi/dispatcher/dsopcode.c: op = acpi_ps_alloc_op(AML_INT_EVAL_SUBTREE_OP); drivers/acpi/dispatcher/dsopcode.c: op = acpi_ps_alloc_op(AML_INT_EVAL_SUBTREE_OP); drivers/acpi/dispatcher/dswload.c: op = acpi_ps_alloc_op(walk_state->opcode); drivers/acpi/dispatcher/dswload.c: op = acpi_ps_alloc_op(walk_state->opcode); drivers/acpi/parser/psargs.c: name_op = acpi_ps_alloc_op(AML_INT_NAMEPATH_OP); drivers/acpi/parser/psargs.c: field = acpi_ps_alloc_op(opcode); drivers/acpi/parser/psargs.c: arg = acpi_ps_alloc_op(AML_BYTE_OP); drivers/acpi/parser/psargs.c: arg = acpi_ps_alloc_op(AML_INT_BYTELIST_OP); drivers/acpi/parser/psargs.c: arg = acpi_ps_alloc_op(AML_INT_NAMEPATH_OP); drivers/acpi/parser/psloop.c: acpi_ps_alloc_op(walk_state-> drivers/acpi/parser/psloop.c: op = acpi_ps_alloc_op(walk_state->opcode); drivers/acpi/parser/psparse.c: acpi_ps_alloc_op(AML_INT_RETURN_VALUE_OP); drivers/acpi/parser/psparse.c: acpi_ps_alloc_op(AML_INT_RETURN_VALUE_OP); drivers/acpi/parser/psparse.c: acpi_ps_alloc_op(op->common. drivers/acpi/parser/psparse.c: acpi_ps_alloc_op(AML_INT_RETURN_VALUE_OP); drivers/acpi/parser/psutils.c: scope_op = acpi_ps_alloc_op(AML_SCOPE_OP); drivers/acpi/utilities/utobject.c: acpi_ut_allocate_object_desc_dbg(module_name, line_number, drivers/acpi/utilities/utobject.c: second_object = acpi_ut_allocate_object_desc_dbg(module_name, drivers/acpi/dispatcher/dswscope.c: scope_info = acpi_ut_create_generic_state(); drivers/acpi/dispatcher/dswstate.c: state = acpi_ut_create_generic_state(); drivers/acpi/events/evmisc.c: notify_info = acpi_ut_create_generic_state(); drivers/acpi/namespace/nseval.c: scope_info = acpi_ut_create_generic_state(); drivers/acpi/parser/psscope.c: scope = acpi_ut_create_generic_state(); drivers/acpi/parser/psscope.c: scope = acpi_ut_create_generic_state(); drivers/acpi/utilities/utstate.c: state = acpi_ut_create_generic_state(); drivers/acpi/utilities/utstate.c: state = acpi_ut_create_generic_state(); drivers/acpi/utilities/utstate.c: state = acpi_ut_create_generic_state(); drivers/acpi/utilities/utstate.c: state = acpi_ut_create_generic_state(); I'll bet these callsites are all also called from multiple locations. Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/