Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Alexandre Chartre <alexandre.chartre@oracle.com>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     x86@kernel.org, Steven Rostedt <rostedt@goodmis.org>,
        Brian Gerst <brgerst@gmail.com>,
        Juergen Gross <jgross@suse.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Arnd Bergmann <arnd@arndb.de>
Subject: Re: [patch 07/24] x86/traps: Prepare for using DEFINE_IDTENTRY
In-Reply-To: <af1808f4-93a3-d015-753f-168c742f89f7@oracle.com>
References: <20200225221606.511535280@linutronix.de> <20200225222648.880108780@linutronix.de> <af1808f4-93a3-d015-753f-168c742f89f7@oracle.com>
Date:   Fri, 28 Feb 2020 15:18:02 +0100
Message-ID: <8736auhk2t.fsf@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Alexandre Chartre <alexandre.chartre@oracle.com> writes:
> On 2/25/20 11:16 PM, Thomas Gleixner wrote:
>> Prepare for using IDTENTRY to define the C exception/trap entry points. It
>> would be possible to glue this into the existing macro maze, but it's
>> simpler and better to read at the end to just make them distinct. Provide
>> a trivial inline helper to read the trap address.
>> 
>> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>> ---
>>   arch/x86/kernel/traps.c |    5 +++++
>>   1 file changed, 5 insertions(+)
>> 
>> --- a/arch/x86/kernel/traps.c
>> +++ b/arch/x86/kernel/traps.c
>> @@ -274,6 +274,11 @@ static void do_error_trap(struct pt_regs
>>   	}
>>   }
>>   
>> +static inline void __user *error_get_trap_addr(struct pt_regs *regs)
>> +{
>> +	return (void __user *)uprobe_get_trap_addr(regs);
>> +}
>> +
>>   #define IP ((void __user *)uprobe_get_trap_addr(regs))
>
> And you will eventually get rid of this IP macro, right?

The whole macro maze will be gone at the end.