Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030329AbWBNAUg (ORCPT ); Mon, 13 Feb 2006 19:20:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030331AbWBNAUg (ORCPT ); Mon, 13 Feb 2006 19:20:36 -0500 Received: from adsl-70-250-156-241.dsl.austtx.swbell.net ([70.250.156.241]:19634 "EHLO gw.microgate.com") by vger.kernel.org with ESMTP id S1030329AbWBNAUf (ORCPT ); Mon, 13 Feb 2006 19:20:35 -0500 Message-ID: <43F12248.7070608@microgate.com> Date: Mon, 13 Feb 2006 18:20:24 -0600 From: Paul Fulghum User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Paul Fulghum CC: Jason Baron , Andrew Morton , Linux Kernel Mailing List , "jesper.juhl@gmail.com" , Alan Cox Subject: Re: [PATCH] tty reference count fix References: <1139861610.3573.24.camel@amdx2.microgate.com> <43F119FC.10900@microgate.com> In-Reply-To: <43F119FC.10900@microgate.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 631 Lines: 20 Paul Fulghum wrote: > Your patch leaves the schedule() call at the bottom of > the while loop between setting tty_closing and > setting TTY_CLOSING flag. Nevermind. After schedule() the count is reread, so you are right. Dropping tty_sem altogether would work. It is a matter of where you ultimately wish to push the locking to BKL or tty_sem. -- Paul Fulghum Microgate Systems, Ltd - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/