Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200227132826.195669-1-brgerst@gmail.com> <20200227132826.195669-2-brgerst@gmail.com>
In-Reply-To: <20200227132826.195669-2-brgerst@gmail.com>
From:   Andy Lutomirski <luto@kernel.org>
Date:   Fri, 28 Feb 2020 10:33:43 -0800
Message-ID: <CALCETrWqmpChXCs0b-rO4X-yKKy0Afy3ioaK01ZmeiCvsN=3+Q@mail.gmail.com>
Subject: Re: [PATCH v3 1/8] x86, syscalls: Refactor SYSCALL_DEFINEx macros
To:     Brian Gerst <brgerst@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, X86 ML <x86@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dominik Brodowski <linux@dominikbrodowski.net>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Feb 27, 2020 at 5:28 AM Brian Gerst <brgerst@gmail.com> wrote:
>
> Pull the common code out from the SYSCALL_DEFINEx macros into a new
> __SYS_STUBx macro.  Also conditionalize the X64 version in preparation for
> enabling syscall wrappers on 32-bit native kernels.
>
> Signed-off-by: Brian Gerst <brgerst@gmail.com>
> ---


> -#define COMPAT_SYSCALL_DEFINEx(x, name, ...)                                   \
> -       static long __se_compat_sys##name(__MAP(x,__SC_LONG,__VA_ARGS__));      \
> -       static inline long __do_compat_sys##name(__MAP(x,__SC_DECL,__VA_ARGS__));\
> -       __IA32_COMPAT_SYS_STUBx(x, name, __VA_ARGS__)                           \
> -       __X32_COMPAT_SYS_STUBx(x, name, __VA_ARGS__)                            \
> -       static long __se_compat_sys##name(__MAP(x,__SC_LONG,__VA_ARGS__))       \
> -       {                                                                       \
> -               return __do_compat_sys##name(__MAP(x,__SC_DELOUSE,__VA_ARGS__));\
> -       }                                                                       \
> -       static inline long __do_compat_sys##name(__MAP(x,__SC_DECL,__VA_ARGS__))
> +#define COMPAT_SYSCALL_DEFINEx(x, name, ...)                           \
> +       static long                                                     \
> +       __se_compat_sys##name(__MAP(x, __SC_LONG, __VA_ARGS__));        \
> +       static inline long                                              \
> +       __do_compat_sys##name(__MAP(x, __SC_DECL, __VA_ARGS__));        \
> +       __IA32_COMPAT_SYS_STUBx(x, name, __VA_ARGS__)                   \
> +       __X32_COMPAT_SYS_STUBx(x, name, __VA_ARGS__)                    \
> +       static long                                                     \
> +       __se_compat_sys##name(__MAP(x, __SC_LONG, __VA_ARGS__))         \
> +       {                                                               \
> +               return __do_compat_sys##name(                           \
> +                       __MAP(x, __SC_DELOUSE, __VA_ARGS__));           \
> +       }                                                               \
> +       static inline long                                              \
> +       __do_compat_sys##name(__MAP(x, __SC_DECL, __VA_ARGS__))
>

This hunk looks like a pure anti-cleanup.  I much prefer slightly long
lines over messy excessively multi-line macros.

Other than that:

Reviewed-by: Andy Lutomirski <luto@kernel.org>

--Andy