Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200227132826.195669-1-brgerst@gmail.com> <20200227132826.195669-3-brgerst@gmail.com>
In-Reply-To: <20200227132826.195669-3-brgerst@gmail.com>
From:   Andy Lutomirski <luto@kernel.org>
Date:   Fri, 28 Feb 2020 10:35:28 -0800
Message-ID: <CALCETrXYxKk+30Py0hUHuMiXCXLzYW6Oh8tDo-bBp9G2OWxqyw@mail.gmail.com>
Subject: Re: [PATCH v3 2/8] x86, syscalls: Refactor SYSCALL_DEFINE0 macros
To:     Brian Gerst <brgerst@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, X86 ML <x86@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dominik Brodowski <linux@dominikbrodowski.net>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Feb 27, 2020 at 5:28 AM Brian Gerst <brgerst@gmail.com> wrote:
>
> Pull the common code out from the SYSCALL_DEFINE0 macros into a new
> __SYS_STUB0 macro.  Also conditionalize the X64 version in preparation for
> enabling syscall wrappers on 32-bit native kernels.

Reviewed-by: Andy Lutomirski <luto@kernel.org>

It would be really nice if there was a clean way to get rid of the
0-arg special case, but I don't immediately see one.

--Andy