Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200223231711.157699-1-jbi.octave@gmail.com> <20200223231711.157699-30-jbi.octave@gmail.com>
In-Reply-To: <20200223231711.157699-30-jbi.octave@gmail.com>
From:   Robin Holt <robinmholt@gmail.com>
Date:   Fri, 28 Feb 2020 13:22:00 -0600
Message-ID: <CAPp3RGrrurNVniL6Og-+hGuYOBeiiZdjj1iEwvodnx6i3Qs7GQ@mail.gmail.com>
Subject: Re: [PATCH 29/30] sgi-xp: Add missing annotation for xpc_disconnect_channel()
To:     Jules Irenge <jbi.octave@gmail.com>
Cc:     boqun.feng@gmail.com, LKML <linux-kernel@vger.kernel.org>,
        Cliff Whickman <cpw@sgi.com>, Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Feb 23, 2020 at 5:18 PM Jules Irenge <jbi.octave@gmail.com> wrote:
>
> Sparse reports a warning at xpc_disconnect_channel()
> warning: context imbalance in xpc_disconnect_channel() - unexpected unlock
> The root cause is a missing annotation at xpc_disconnect_channel()
> Add the missing __must_hold(&ch->lock) annotation
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Acked-by: Robin Holt <robinmholt@gmail.com>