Message-ID: <43F14DAA.6000703@bigpond.net.au>
Date: Tue, 14 Feb 2006 14:25:30 +1100
From: Peter Williams <pwil3058@bigpond.net.au>
User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929)
MIME-Version: 1.0
To: quilt-dev@nongnu.org
CC: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Quilt-dev] Quilt 0.43 has been released! [SERIOUS BUG]
References: <20060202230210.05a6ad4a.khali@linux-fr.org>
In-Reply-To: <20060202230210.05a6ad4a.khali@linux-fr.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1548
Lines: 41

Jean Delvare wrote:
> Hi all,
> 
> Quilt 0.43 is now available for download from Savannah:
> http://download.savannah.gnu.org/releases/quilt/
> 
> Enjoy!
> 

I've experienced a serious problem with this version of quilt that is 
rather hard to explain but definitely arrived with this version as 
reverting to 0.42 makes the problem go away.

Now to try to explain the problem :-(

The problem arises when pushing a patch that has errors in it (due to 
changes in the previous patches in the series) and needs the -f flag to 
force the push.  What's happening is that the reverse of the errors is 
being applied to the "pre patch" file in the .pc directory.  Then when 
you pop this patch it returns the file to a state with the reverse of 
the errors applied to it.

I'm having trouble understanding how quilt could be dumb enough to do 
this as surely the "pre patch" file in the .pc directory should be just 
a copy of the file before the patch is applied.

This bug can completely hose a set of patches if the user doesn't notice 
it very early and do something about it.  The work around is to revert 
to version 0.42 of quilt.

Peter
-- 
Peter Williams                                   pwil3058@bigpond.net.au

"Learning, n. The kind of ignorance distinguishing the studious."
  -- Ambrose Bierce
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/