Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200227132826.195669-1-brgerst@gmail.com> <20200227132826.195669-7-brgerst@gmail.com>
 <CALCETrW=R-tanwBwX9vCsnUiRdHooPq59uDVRBfwiOpC0MzRYQ@mail.gmail.com>
In-Reply-To: <CALCETrW=R-tanwBwX9vCsnUiRdHooPq59uDVRBfwiOpC0MzRYQ@mail.gmail.com>
From:   Brian Gerst <brgerst@gmail.com>
Date:   Fri, 28 Feb 2020 15:06:14 -0500
Message-ID: <CAMzpN2j7hO6vpopjc8po+v-9u3mmQ5Z_ZefVai3pJeV823_7Uw@mail.gmail.com>
Subject: Re: [PATCH v3 6/8] x86-32: Enable syscall wrappers
To:     Andy Lutomirski <luto@kernel.org>
Cc:     LKML <linux-kernel@vger.kernel.org>, X86 ML <x86@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Dominik Brodowski <linux@dominikbrodowski.net>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Feb 28, 2020 at 2:01 PM Andy Lutomirski <luto@kernel.org> wrote:
>
> On Thu, Feb 27, 2020 at 5:28 AM Brian Gerst <brgerst@gmail.com> wrote:
> >
> > Enable pt_regs based syscalls for 32-bit.  This makes the 32-bit native
> > kernel consistent with the 64-bit kernel, and improves the syscall
> > interface by not needing to push all 6 potential arguments onto the stack.
>
> Was the change to the table mechanically generated or mechanically
> verified?  If so, how?

It was done by hand, but I can look into writing a script to verify it.

> After this goes in, I should dust off my code to get rid of all the
> __abi crud in the tables.  I never quite got it working well enough,
> but your series should help.

That would be nice.  After my patches, everything has the ABI prefix
to the functions.

--
Brian Gerst