Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp1069276ybf; Fri, 28 Feb 2020 13:23:06 -0800 (PST) X-Google-Smtp-Source: APXvYqyGQfAmocRZZQiaVooTRfzl8V/JtN2XzOwDN4xRPL97H1bsyEXZs9zpqWybR65WWfkPZjJU X-Received: by 2002:aca:f517:: with SMTP id t23mr4391786oih.160.1582924986396; Fri, 28 Feb 2020 13:23:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582924986; cv=none; d=google.com; s=arc-20160816; b=NiybSlEfCW45mw7mg6Houa/1CWZuSVXvMFb6maRm0raBbswU1qPqpuowx5GqILiYfz Zw29wl9QVXBvR80YjOiI0uitv2f/fJAiSovMzc4RNj48+kIfS3SST9WnVWEzohg4mrek LG0YY11GvsYept4WFFX2CeWP0wdUR2UweQZEjGBGSA4DOLrUYql/H8tIODV8qg9XHlEh ZBPb5D+GKFiRiSagDWOQuxQBfeMtbHYMkcH+fSJMXIWeAtCpR33EiLfjYrQGPEhYV1TH mPkKOaO+aU669lUgSxTR0T1odrDcwbobUBBk4tJNM8/4p5cKNazAXa1+YBm0kl36HeYb L9xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:message-id:subject:date:mime-version :content-transfer-encoding:from:dkim-signature; bh=3aXcF2AhQGGFWexI0lq42oU+QMdi8F3NchIn9iNMank=; b=vihK2XuOUUTGbv2CrptNJLv//cqNslS5+LIx71U5DhwLtpGqJ3FmR2blN+Q6RDoPi7 NvhmHdv17i7tz3CrIzP4Iz0tGqQCW/PdxPU1Aod/EOnVd8LCaz2TtUogu1QA2LLw1P7R Z/cFwiPROnNVVqiZyCz2Aj5JsadErLrLFB3ytaylaxufd/3Sqmb5B81FxXPqIowcWIqV 5a4ju5o+Fem7Rn/ZoABljiubRFIGlEU853z9UOs3BQ7buGuPVgYMMRx4+68loT3FdeXE 08hGrHu261mVvJLpbv1M0UNXzUKoHD4zW2NuPROcqVBvA863Iv2FkQs8ni8w+7cKfrn2 ybJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=pSX3F6AU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g18si2140235otp.61.2020.02.28.13.22.54; Fri, 28 Feb 2020 13:23:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=pSX3F6AU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726359AbgB1VWa (ORCPT + 99 others); Fri, 28 Feb 2020 16:22:30 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:42578 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725805AbgB1VW3 (ORCPT ); Fri, 28 Feb 2020 16:22:29 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01SLIjRt002145 for ; Fri, 28 Feb 2020 21:22:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : content-type : content-transfer-encoding : mime-version : date : subject : message-id : to; s=corp-2020-01-29; bh=3aXcF2AhQGGFWexI0lq42oU+QMdi8F3NchIn9iNMank=; b=pSX3F6AUWjEBFtKxyzTtsk5IjmoMcMV5zYoM8go4FFtmoS4a/AR+5A2FHMwHHPYv7E+s Kwokt/y5+iF5Y677oFO5pw4/1sfsvDo6zXK59RwNyfAhjJNLRHcuZ2YyXFN7sjZ13KrV gY19P8Qt3Kd2BxtL2zXY97mcFmzCQltbdtPcXebTtlzJquYWIkjLPlu2rQTZBz6YYH8b Tdi1oMIcmkI7fhkRGrXQJrovHaAjad90Wk+2O3uoYN0L7cPbyJ/c5Hy1ZVdsqzXyKr36 A8qeJ/ZHRqwU1bkoqE3H4cxE8DBM1R+ysWiVRfnmAr4JJlwE3P0EZLraS+X7DTui4CPq Ig== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2ydct3nbhy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 28 Feb 2020 21:22:28 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01SLICSt048807 for ; Fri, 28 Feb 2020 21:22:28 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 2ydj4rt6ww-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 28 Feb 2020 21:22:28 +0000 Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 01SLMRk0024049 for ; Fri, 28 Feb 2020 21:22:27 GMT Received: from dhcp-10-154-108-96.vpn.oracle.com (/10.154.108.96) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 28 Feb 2020 13:22:27 -0800 From: John Donnelly Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Date: Fri, 28 Feb 2020 15:22:25 -0600 Subject: [PATCH ] ipmi_si: Fix false error about IRQ registration Message-Id: <161D2B48-8034-4467-A085-7B69458144C9@oracle.com> To: linux-kernel@vger.kernel.org X-Mailer: Apple Mail (2.3445.9.1) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9545 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 suspectscore=5 spamscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002280150 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9545 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 spamscore=0 priorityscore=1501 malwarescore=0 adultscore=0 phishscore=0 mlxlogscore=999 mlxscore=0 suspectscore=5 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002280150 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since commit 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq()"), platform_get_irq() will call dev_err() on an error, even though the IRQ usage in the ipmi_si driver is optional. Use the platform_get_irq_optional() call to avoid the message from alerting users with false alarms. Orabug: 30970275 Signed-off-by: John Donnelly --- drivers/char/ipmi/ipmi_si_platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/ipmi/ipmi_si_platform.c = b/drivers/char/ipmi/ipmi_si_platform.c index c78127ccbc0d..638c693e17ad 100644 --- a/drivers/char/ipmi/ipmi_si_platform.c +++ b/drivers/char/ipmi/ipmi_si_platform.c @@ -194,7 +194,7 @@ static int platform_ipmi_probe(struct = platform_device *pdev) else io.slave_addr =3D slave_addr; =20 - io.irq =3D platform_get_irq(pdev, 0); + io.irq =3D platform_get_irq_optional(pdev, 0); if (io.irq > 0) io.irq_setup =3D ipmi_std_irq_setup; else @@ -378,7 +378,7 @@ static int acpi_ipmi_probe(struct platform_device = *pdev) io.irq =3D tmp; io.irq_setup =3D acpi_gpe_irq_setup; } else { - int irq =3D platform_get_irq(pdev, 0); + int irq =3D platform_get_irq_optional(pdev, 0); =20 if (irq > 0) { io.irq =3D irq; --=20 2.20.1=