Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   John Donnelly <john.p.donnelly@oracle.com>
Content-Type: text/plain;
        charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Subject: Re: [PATCH ] ipmi_si: Fix false error about IRQ registration
Date:   Fri, 28 Feb 2020 15:25:16 -0600
References: <161D2B48-8034-4467-A085-7B69458144C9@oracle.com>
To:     linux-kernel@vger.kernel.org
In-Reply-To: <161D2B48-8034-4467-A085-7B69458144C9@oracle.com>
Message-Id: <5E488521-038E-4F6E-A2DB-5A5A61271069@oracle.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Please Ignore . =20

Let me correct the contents in v2=20


> On Feb 28, 2020, at 3:22 PM, John Donnelly =
<john.p.donnelly@oracle.com> wrote:
>=20
> Since commit 7723f4c5ecdb ("driver core: platform: Add an error =
message
> to platform_get_irq()"), platform_get_irq() will call dev_err() on an
> error,  even though the IRQ usage in the ipmi_si driver is optional.
>=20
> Use the platform_get_irq_optional() call to avoid the message from
> alerting users with false alarms.
>=20
> Orabug: 30970275
>=20
> Signed-off-by: John Donnelly <john.p.donnelly@oracle.com>
> ---
> drivers/char/ipmi/ipmi_si_platform.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/char/ipmi/ipmi_si_platform.c =
b/drivers/char/ipmi/ipmi_si_platform.c
> index c78127ccbc0d..638c693e17ad 100644
> --- a/drivers/char/ipmi/ipmi_si_platform.c
> +++ b/drivers/char/ipmi/ipmi_si_platform.c
> @@ -194,7 +194,7 @@ static int platform_ipmi_probe(struct =
platform_device *pdev)
> 	else
> 		io.slave_addr =3D slave_addr;
>=20
> -	io.irq =3D platform_get_irq(pdev, 0);
> +	io.irq =3D platform_get_irq_optional(pdev, 0);
> 	if (io.irq > 0)
> 		io.irq_setup =3D ipmi_std_irq_setup;
> 	else
> @@ -378,7 +378,7 @@ static int acpi_ipmi_probe(struct platform_device =
*pdev)
> 		io.irq =3D tmp;
> 		io.irq_setup =3D acpi_gpe_irq_setup;
> 	} else {
> -		int irq =3D platform_get_irq(pdev, 0);
> +		int irq =3D platform_get_irq_optional(pdev, 0);
>=20
> 		if (irq > 0) {
> 			io.irq =3D irq;
> --=20
> 2.20.1