Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp1072974ybf; Fri, 28 Feb 2020 13:28:46 -0800 (PST) X-Google-Smtp-Source: APXvYqxRzEwafxahXXUqJKk0J4yKyUApMH45Tn5k/zIHlce4s8vyqlCdul6to8Xs/g9QTs75rVR8 X-Received: by 2002:a9d:2c2:: with SMTP id 60mr4911694otl.208.1582925326703; Fri, 28 Feb 2020 13:28:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582925326; cv=none; d=google.com; s=arc-20160816; b=W3XsVYSo29gUAUQGa6ekVm1L5++vYpIMGCJxgtUDRhzszpK118ooRKYKg4Qo6/g+RC PV0ZMWx1FFwmePFLG3PXR+MQ1fDZbVM8Y3gTKEwLjggbprBSFo3BiCVybJSR0kvIVCHC PSUX9h2bWHJi7+gPCATXx5Rd/UO/zWKfYuEl2wUwMBWwY+x7uZyJ6gHBKetwPGpSZrVy Y31RbVRgug+ysNgb7bmxDJu5E9JQbc/O8NBuFTMeAKpPxHBIGnUGBk0oSscf62crwv90 2RVW7+3eLmft5MPifdLmLX4SpxSXbYJBGsTWeVVZE2Ds0l0yHkeuayZZQRmdfrI96tut dwPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:message-id:subject:date:mime-version :content-transfer-encoding:from:dkim-signature; bh=oImuifTpYNk8lG3PdcuMkS3w5Vx5Llw/cJtUmARLtAc=; b=o3QGq2POcwwbmG16W6OrdcW1tMCHQAwchValn2N681XZiuCseBUId/ydJJg0T4eO9d yQOsA+vlvyO2HLDuSw/NVHJRuNlA0wiuZYBwy0UUVd1XFWcDVeUP15HsXp8KqfgK+89q wkwP1dURUjlgkf+f+6TtN/z68XKXPZjUHLhu26PhEzFt4AyyKlGm0r/O8vk4HpXuFbuP inc9gtNqeNCzqnqCY1ZH62jSzZxrIrY8ieaSdnUEdbCyHtOloc24+rHvNWOIBMHoucpX 3Cg6I1tVNwCS/DSp3a6jHrJjqLshF6cqmxOtpBMjYrG+PMlwfczfLVQwfL/JkMu7Y+b+ ycTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=Rz8PdD9j; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g18si2140235otp.61.2020.02.28.13.28.34; Fri, 28 Feb 2020 13:28:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=Rz8PdD9j; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726118AbgB1V2J (ORCPT + 99 others); Fri, 28 Feb 2020 16:28:09 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:50014 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725805AbgB1V2J (ORCPT ); Fri, 28 Feb 2020 16:28:09 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01SLMsPf005552 for ; Fri, 28 Feb 2020 21:28:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : content-type : content-transfer-encoding : mime-version : date : subject : message-id : to; s=corp-2020-01-29; bh=oImuifTpYNk8lG3PdcuMkS3w5Vx5Llw/cJtUmARLtAc=; b=Rz8PdD9j0DsYsMyIjUvDyqES5Me1RIeosS+GWH1KzJQDRZ9I5hmDwSWbi5iYq+iqq2rh ASCp3BB8zjsu7I7j99dTuhVcfLTaK/qjiahAHEOtQdkqmK4BhUbCYZexWgpQoSGohKNI IaH/Vl0RsXHirW13U5OYLIrvdOYLFW5FNaKRzeswTwNHqeD/sqEIArYgxN6fJc0G3M59 L8I+OR9z4x7IH8AyrBXA7INbPfqqYY3lr5Rzy381PDpNDk8j6uJMYg1uGO3t3LoMR4hB 4hW+k2Srh4PFSFdJtsI/n4BVE5/HhWobchYD4jYJXcwbsMRvJwqGPYq92cozpFG95j/5 9A== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 2ydct3nc9u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 28 Feb 2020 21:28:08 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01SLGlkk115071 for ; Fri, 28 Feb 2020 21:28:07 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 2ydcsg7arm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 28 Feb 2020 21:28:07 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 01SLS6s6026950 for ; Fri, 28 Feb 2020 21:28:06 GMT Received: from dhcp-10-154-108-96.vpn.oracle.com (/10.154.108.96) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 28 Feb 2020 13:28:05 -0800 From: John Donnelly Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Date: Fri, 28 Feb 2020 15:28:04 -0600 Subject: [PATCH v2 ] ipmi_si: Fix false error about IRQ registration Message-Id: <95A6B0CD-9C09-4165-AF60-A2789C53E926@oracle.com> To: linux-kernel@vger.kernel.org X-Mailer: Apple Mail (2.3445.9.1) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9545 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 bulkscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 suspectscore=5 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002280150 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9545 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 spamscore=0 priorityscore=1501 malwarescore=0 adultscore=0 phishscore=0 mlxlogscore=999 mlxscore=0 suspectscore=5 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002280150 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since commit 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq()"), platform_get_irq() will call dev_err() on an error, even though the IRQ usage in the ipmi_si driver is optional. Use the platform_get_irq_optional() call to avoid the message from alerting users with false alarms. cc: stable@vger.kernel.org # 5.4.x Signed-off-by: John Donnelly --- drivers/char/ipmi/ipmi_si_platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/ipmi/ipmi_si_platform.c = b/drivers/char/ipmi/ipmi_si_platform.c index c78127ccbc0d..638c693e17ad 100644 --- a/drivers/char/ipmi/ipmi_si_platform.c +++ b/drivers/char/ipmi/ipmi_si_platform.c @@ -194,7 +194,7 @@ static int platform_ipmi_probe(struct = platform_device *pdev) else io.slave_addr =3D slave_addr; =20 - io.irq =3D platform_get_irq(pdev, 0); + io.irq =3D platform_get_irq_optional(pdev, 0); if (io.irq > 0) io.irq_setup =3D ipmi_std_irq_setup; else @@ -378,7 +378,7 @@ static int acpi_ipmi_probe(struct platform_device = *pdev) io.irq =3D tmp; io.irq_setup =3D acpi_gpe_irq_setup; } else { - int irq =3D platform_get_irq(pdev, 0); + int irq =3D platform_get_irq_optional(pdev, 0); =20 if (irq > 0) { io.irq =3D irq; --=20 2.20.1