Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp1170302ybf; Fri, 28 Feb 2020 15:57:00 -0800 (PST) X-Google-Smtp-Source: APXvYqy5HNJjbGQDJOBYMVrEMIOfvWTHxEWna7lKDWgzDgKxVQUpPAPutXga+wa6cDmkTtFtECf3 X-Received: by 2002:a9d:6b91:: with SMTP id b17mr4994600otq.235.1582934220541; Fri, 28 Feb 2020 15:57:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582934220; cv=none; d=google.com; s=arc-20160816; b=yNHSZG0treXxlN1vjj4w6Iy8xU3Vp3Yvenpg/x+mZIJhTzqhVHgPAzY5ccYCVD6U/8 fN1C1/BgKujvvr69WjtmjvVhSsUfq76JlT5WBg+JPL9fsy5k3BvbKr5VaAF5GuQM+1mM k4Gis+3+Fclc44L/hAPllui41YWBZHnyIUEZKwygZJTt4vN1fVT9XA0KsUO9VNfmXJmW g73WkZai6Y9OFabPR09BTiU6PMqyoUaltHYn0XnNWVVi+sp3CTCOZGXl9XLZC6JjHn08 13T+u3fTR3EWLL4bGNoSEFq0nV1V7FHyY4BL1VtVLKU/Kl5+fG3A+2eg2n8++MZyFSRt 1tXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:subject:autocrypt:from:references:cc:to; bh=bRhleWaygIIeYNptAaYQbiWAERKe+GIi++v5VarQWlQ=; b=gQgi8KTGh7bNyIX6xMJ3rQHTGAcGQ4D8qJoBOBvR7x5bWqBUeWsgoJcylzLMANf7PC uYPcwgZvYzt6GOuZF1CHk/jkE7C3I3EndVxxlL2J1PsZJWU97JXZadGU8pb4MOyAnQGx yFykgBGwe8wvRD0nGVowWxqvwSIAUobEwX0zCkEH31Nu7IsGFrJuTTDfIA8JYCN6ZpYt CiBEv712bRvChTO7p8okP8UJSx7EwpOyIbumSE3rywgHXa9oZ8ovPRAQinzB4jQ39+5+ /ts+05nFNeElj425655JlahVQwrFLNQwEWo5uBkqmDMUnav2NLbXIip38ek5SSd34ZUA GUqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p83si2649231oih.198.2020.02.28.15.56.47; Fri, 28 Feb 2020 15:57:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726527AbgB1Xz1 (ORCPT + 99 others); Fri, 28 Feb 2020 18:55:27 -0500 Received: from mga12.intel.com ([192.55.52.136]:2999 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725957AbgB1Xz0 (ORCPT ); Fri, 28 Feb 2020 18:55:26 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Feb 2020 15:55:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,497,1574150400"; d="scan'208";a="437592392" Received: from schen9-desk.jf.intel.com (HELO [10.54.74.162]) ([10.54.74.162]) by fmsmga005.fm.intel.com with ESMTP; 28 Feb 2020 15:55:25 -0800 To: Vineeth Remanan Pillai , Aubrey Li Cc: Aaron Lu , Julien Desfossez , Nishanth Aravamudan , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , Paul Turner , Linus Torvalds , Linux List Kernel Mailing , Dario Faggioli , =?UTF-8?B?RnLDqWTDqXJpYyBXZWlzYmVja2Vy?= , Kees Cook , Greg Kerr , Phil Auld , Valentin Schneider , Mel Gorman , Pawan Gupta , Paolo Bonzini References: <5e3cea14-28d1-bf1e-cabe-fb5b48fdeadc@linux.intel.com> <3c3c56c1-b8dc-652c-535e-74f6dcf45560@linux.intel.com> <20200212230705.GA25315@sinkpad> <29d43466-1e18-6b42-d4d0-20ccde20ff07@linux.intel.com> <20200225034438.GA617271@ziqianlu-desktop.localdomain> From: Tim Chen Autocrypt: addr=tim.c.chen@linux.intel.com; prefer-encrypt=mutual; keydata= mQINBE6ONugBEAC1c8laQ2QrezbYFetwrzD0v8rOqanj5X1jkySQr3hm/rqVcDJudcfdSMv0 BNCCjt2dofFxVfRL0G8eQR4qoSgzDGDzoFva3NjTJ/34TlK9MMouLY7X5x3sXdZtrV4zhKGv 3Rt2osfARdH3QDoTUHujhQxlcPk7cwjTXe4o3aHIFbcIBUmxhqPaz3AMfdCqbhd7uWe9MAZX 7M9vk6PboyO4PgZRAs5lWRoD4ZfROtSViX49KEkO7BDClacVsODITpiaWtZVDxkYUX/D9OxG AkxmqrCxZxxZHDQos1SnS08aKD0QITm/LWQtwx1y0P4GGMXRlIAQE4rK69BDvzSaLB45ppOw AO7kw8aR3eu/sW8p016dx34bUFFTwbILJFvazpvRImdjmZGcTcvRd8QgmhNV5INyGwtfA8sn L4V13aZNZA9eWd+iuB8qZfoFiyAeHNWzLX/Moi8hB7LxFuEGnvbxYByRS83jsxjH2Bd49bTi XOsAY/YyGj6gl8KkjSbKOkj0IRy28nLisFdGBvgeQrvaLaA06VexptmrLjp1Qtyesw6zIJeP oHUImJltjPjFvyfkuIPfVIB87kukpB78bhSRA5mC365LsLRl+nrX7SauEo8b7MX0qbW9pg0f wsiyCCK0ioTTm4IWL2wiDB7PeiJSsViBORNKoxA093B42BWFJQARAQABtDRUaW0gQ2hlbiAo d29yayByZWxhdGVkKSA8dGltLmMuY2hlbkBsaW51eC5pbnRlbC5jb20+iQI+BBMBAgAoAhsD BgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCXFIuxAUJEYZe0wAKCRCiZ7WKota4STH3EACW 1jBRzdzEd5QeTQWrTtB0Dxs5cC8/P7gEYlYQCr3Dod8fG7UcPbY7wlZXc3vr7+A47/bSTVc0 DhUAUwJT+VBMIpKdYUbvfjmgicL9mOYW73/PHTO38BsMyoeOtuZlyoUl3yoxWmIqD4S1xV04 q5qKyTakghFa+1ZlGTAIqjIzixY0E6309spVTHoImJTkXNdDQSF0AxjW0YNejt52rkGXXSoi IgYLRb3mLJE/k1KziYtXbkgQRYssty3n731prN5XrupcS4AiZIQl6+uG7nN2DGn9ozy2dgTi smPAOFH7PKJwj8UU8HUYtX24mQA6LKRNmOgB290PvrIy89FsBot/xKT2kpSlk20Ftmke7KCa 65br/ExDzfaBKLynztcF8o72DXuJ4nS2IxfT/Zmkekvvx/s9R4kyPyebJ5IA/CH2Ez6kXIP+ q0QVS25WF21vOtK52buUgt4SeRbqSpTZc8bpBBpWQcmeJqleo19WzITojpt0JvdVNC/1H7mF 4l7og76MYSTCqIKcLzvKFeJSie50PM3IOPp4U2czSrmZURlTO0o1TRAa7Z5v/j8KxtSJKTgD lYKhR0MTIaNw3z5LPWCCYCmYfcwCsIa2vd3aZr3/Ao31ZnBuF4K2LCkZR7RQgLu+y5Tr8P7c e82t/AhTZrzQowzP0Vl6NQo8N6C2fcwjSrkCDQROjjboARAAx+LxKhznLH0RFvuBEGTcntrC 3S0tpYmVsuWbdWr2ZL9VqZmXh6UWb0K7w7OpPNW1FiaWtVLnG1nuMmBJhE5jpYsi+yU8sbMA 5BEiQn2hUo0k5eww5/oiyNI9H7vql9h628JhYd9T1CcDMghTNOKfCPNGzQ8Js33cFnszqL4I N9jh+qdg5FnMHs/+oBNtlvNjD1dQdM6gm8WLhFttXNPn7nRUPuLQxTqbuoPgoTmxUxR3/M5A KDjntKEdYZziBYfQJkvfLJdnRZnuHvXhO2EU1/7bAhdz7nULZktw9j1Sp9zRYfKRnQdIvXXa jHkOn3N41n0zjoKV1J1KpAH3UcVfOmnTj+u6iVMW5dkxLo07CddJDaayXtCBSmmd90OG0Odx cq9VaIu/DOQJ8OZU3JORiuuq40jlFsF1fy7nZSvQFsJlSmHkb+cDMZDc1yk0ko65girmNjMF hsAdVYfVsqS1TJrnengBgbPgesYO5eY0Tm3+0pa07EkONsxnzyWJDn4fh/eA6IEUo2JrOrex O6cRBNv9dwrUfJbMgzFeKdoyq/Zwe9QmdStkFpoh9036iWsj6Nt58NhXP8WDHOfBg9o86z9O VMZMC2Q0r6pGm7L0yHmPiixrxWdW0dGKvTHu/DH/ORUrjBYYeMsCc4jWoUt4Xq49LX98KDGN dhkZDGwKnAUAEQEAAYkCJQQYAQIADwIbDAUCXFIulQUJEYZenwAKCRCiZ7WKota4SYqUEACj P/GMnWbaG6s4TPM5Dg6lkiSjFLWWJi74m34I19vaX2CAJDxPXoTU6ya8KwNgXU4yhVq7TMId keQGTIw/fnCv3RLNRcTAapLarxwDPRzzq2snkZKIeNh+WcwilFjTpTRASRMRy9ehKYMq6Zh7 PXXULzxblhF60dsvi7CuRsyiYprJg0h2iZVJbCIjhumCrsLnZ531SbZpnWz6OJM9Y16+HILp iZ77miSE87+xNa5Ye1W1ASRNnTd9ftWoTgLezi0/MeZVQ4Qz2Shk0MIOu56UxBb0asIaOgRj B5RGfDpbHfjy3Ja5WBDWgUQGgLd2b5B6MVruiFjpYK5WwDGPsj0nAOoENByJ+Oa6vvP2Olkl gQzSV2zm9vjgWeWx9H+X0eq40U+ounxTLJYNoJLK3jSkguwdXOfL2/Bvj2IyU35EOC5sgO6h VRt3kA/JPvZK+6MDxXmm6R8OyohR8uM/9NCb9aDw/DnLEWcFPHfzzFFn0idp7zD5SNgAXHzV PFY6UGIm86OuPZuSG31R0AU5zvcmWCeIvhxl5ZNfmZtv5h8TgmfGAgF4PSD0x/Bq4qobcfaL ugWG5FwiybPzu2H9ZLGoaRwRmCnzblJG0pRzNaC/F+0hNf63F1iSXzIlncHZ3By15bnt5QDk l50q2K/r651xphs7CGEdKi1nU0YJVbQxJQ== Subject: Re: [RFC PATCH v4 00/19] Core scheduling v4 Message-ID: Date: Fri, 28 Feb 2020 15:55:24 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/26/20 1:54 PM, Vineeth Remanan Pillai wrote: > rq->curr being NULL can mean that the sibling is idle or forced idle. > In both the cases, I think it makes sense to migrate a task so that it can > compete with the other sibling for a chance to run. This function > can_migrate_task actually only says if this task is eligible and > later part of the code decides whether it is okay to migrate it > based on factors like load and util and capacity. So I think its > fine to declare the task as eligible if the dest core is running > idle. Does this thinking make sense? > > On our testing, it did not show much degradation in performance with > this change. I am reworking the fix by removing the check for > task_est_util. It doesn't seem to be valid to check for util to migrate > the task. > In Aaron's test case, there is a great imbalance in the load on one core where all the grp A tasks are vs the other cores where the grp B tasks are spread around. Normally, load balancer will move the tasks for grp A. Aubrey's can_migrate_task patch prevented the load balancer to migrate tasks if the core cookie on the target queue don't match. The thought was it will induce force idle and reduces cpu utilization if we migrate task to it. That kept all the grp A tasks from getting migrated and kept the imbalance indefinitely in Aaron's test case. Perhaps we should also look at the load imbalance between the src rq and target rq. If the imbalance is big (say two full cpu bound tasks worth of load), we should migrate anyway despite the cookie mismatch. We are willing to pay a bit for the force idle by balancing the load out more. I think Aubrey's patch on can_migrate_task should be more friendly to Aaron's test scenario if such logic is incorporated. In Vinnet's fix, we only look at the currently running task's weight in src and dst rq. Perhaps the load on the src and dst rq needs to be considered to prevent too great an imbalance between the run queues? Tim