Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp180956ybf; Sat, 29 Feb 2020 01:01:32 -0800 (PST) X-Google-Smtp-Source: APXvYqzcKFV5n9cdbuMMzonfa5tptkNYC+XsVPqSxRarHrKEdDEO9qQVdCITyc00jNznzeZnZHW2 X-Received: by 2002:a54:4086:: with SMTP id i6mr5747836oii.65.1582966891905; Sat, 29 Feb 2020 01:01:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582966891; cv=none; d=google.com; s=arc-20160816; b=sJXbTfogCjZjKZaaNfD/2ry0v/UIh/FCenfj2wicoJG4NVXQuXdJzl43ATm3OJL4Cy u2VlrXeUo2Wn1slqEayhdeochS1zBx0Tp8onm5ZOqUSD8MRc3R1n57bXNYEbw4wD15Mp boSrusk9lFzl8mU/OmWsE/5n6FIuf4hsX5fxPqM30Q797CAeG0dNYXTFi4S8sQkdrF3T 4ZCFFd6VgK61Fm3TVjhB5QinHYhCl9KcI+bwpQ1tCeoPBi+nhFHKSFvVwyfESXmPytbC avu0cWiEV1i86zyF6UfYJMqIpzp50czNGvTfFWNb+ZkxpqNiaHEJ9JCMVnnArExV3TZx m/qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :from:references:cc:to:subject; bh=XCp7YyGGYLbPBSffXV3vFlDcrZhnzxQgXj8tytqUhgk=; b=n35FlRTlJ221ZHY0zikZAJ651GFJIQFwrzfZ22NLjbNJgeeTbmohbHqy2VCZg9l5bp laPuHOyM3siTa6C8vICL/vRMR4kK1ACQPJawT1inz1gtHdkHPaEIpvHaDuxoGeRfFdeS /ZgqBHyR4t4MQwfSymyOmh2g5f7CVWplWgcu6hUZ0GDZgobyNly9l0eO1AVNpwatAvmh 2esgnXd7NJ2Ho2nkFC1BRIq6ZqvuIN08a+lAnWtNq7E12MOGVQ03HdbShSdU/ZAlZR0U 6gN0oMD3p/eHRFwGfuPfWga80PnAtwGuuf2u2Ud07zQsc6nOGtxBt68oYu3aDGMxghBG jKjQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z62si2995962oiz.271.2020.02.29.01.01.19; Sat, 29 Feb 2020 01:01:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726891AbgB2I7J (ORCPT + 99 others); Sat, 29 Feb 2020 03:59:09 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:26336 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725747AbgB2I7J (ORCPT ); Sat, 29 Feb 2020 03:59:09 -0500 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01T8wmnu143009 for ; Sat, 29 Feb 2020 03:59:07 -0500 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0b-001b2d01.pphosted.com with ESMTP id 2yepwk13k6-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 29 Feb 2020 03:59:07 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 29 Feb 2020 08:59:05 -0000 Received: from b06avi18626390.portsmouth.uk.ibm.com (9.149.26.192) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Sat, 29 Feb 2020 08:59:02 -0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 01T8w3S240763844 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 29 Feb 2020 08:58:03 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8DEEDA405B; Sat, 29 Feb 2020 08:59:00 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E02F3A4054; Sat, 29 Feb 2020 08:58:58 +0000 (GMT) Received: from [9.199.55.146] (unknown [9.199.55.146]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Sat, 29 Feb 2020 08:58:58 +0000 (GMT) Subject: Re: [RFC 0/1] Weighted approach to gather and use history in TEO governor To: Doug Smythies , ego@linux.vnet.ibm.com Cc: linux-kernel@vger.kernel.org, rafael.j.wysocki@intel.com, peterz@infradead.org, daniel.lezcano@linaro.org, svaidy@linux.ibm.com, pratik.sampat@in.ibm.com, pratik.r.sampat@gmail.com References: <20200222070002.12897-1-psampat@linux.ibm.com> <20200225051306.GG12846@in.ibm.com> <000001d5ed89$0b711340$225339c0$@net> From: Pratik Sampat Date: Sat, 29 Feb 2020 14:28:58 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <000001d5ed89$0b711340$225339c0$@net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 20022908-0020-0000-0000-000003AEB286 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20022908-0021-0000-0000-00002206D86E Message-Id: <204c27ed-9993-2809-3b78-8ac8ea8c1713@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-02-29_02:2020-02-28,2020-02-29 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 phishscore=0 adultscore=0 suspectscore=0 malwarescore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002290068 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Doug, Thanks for running these numbers for me. On 27/02/20 9:44 pm, Doug Smythies wrote: > On 2020.02.24 21:13 Gautham R Shenoy wrote: > > ... > >> Could you also provide power measurements for the duration when the >> system is completely idle for each of the variants of TEO governor ? >> Is it the case that the benefits that we are seeing above are only due >> to Wt. TEO being more conservative than TEO governor by always >> choosing a shallower state ? For system idle I see similar power statistics for both the TEO and the wtteo. > For what it's worth: > > CPU: Intel: i7-2600K > Kernel: 5.6-rc2 (teo) and + this patch set (wtteo) > Note: in general, "idle" on this system is considerably more "idle" than most systems. > Sample period: 5 minutes. > CPU scaling driver: intel_cpufreq > Governor: performance > Deepest idle state: 4 (C6) > > teo: > Test duration 740 minutes (12.33 hours). > Average processor package power: 3.84 watts > Idle state 0: 4.19 / minute > Idle state 1: 29.26 / minute > Idle state 2: 46.71 / minute > Idle state 3: 7.42 / minute > Idle state 4: 1124.55 / minute > Total: 2.525 idle entries per cpu per second > > wtteo: > Test duration 1095 minutes (18.25 hours). > Average processor package power: 3.84 watts > Idle state 0: 7.98 / minute > Idle state 1: 30.49 / minute > Idle state 2: 52.51 / minute > Idle state 3: 8.65 / minute > Idle state 4: 1125.33 / minute > Total: 2.552 idle entries per cpu per second > > The above/below data for this test is incomplete because my program > doesn't process it if there are not enough state entries per sample period. > (I need to fix that for this type of test.) > > I have done a couple of other tests with this patch set, > but nothing to report yet, as the differences have been minor so far. > > ... Doug > > --- Pratik