Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
To:     linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Oleksandr Suvorov <oleksandr.suvorov@toradex.com>,
        Oleksandr Suvorov <cryosay@gmail.com>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Igor Opaniuk <igor.opaniuk@toradex.com>,
        Philippe Schenker <philippe.schenker@toradex.com>,
        Mark Brown <broonie@kernel.org>
Subject: [PATCH 2/2] spi: spidev: fix speed setting message
Date:   Sat, 29 Feb 2020 18:18:41 +0200
Message-Id: <20200229161841.89144-3-oleksandr.suvorov@toradex.com>
In-Reply-To: <20200229161841.89144-1-oleksandr.suvorov@toradex.com>
References: <20200229161841.89144-1-oleksandr.suvorov@toradex.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from localhost (194.105.145.90) by PR3P191CA0046.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:55::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.18 via Frontend Transport; Sat, 29 Feb 2020 16:18:58 +0000
X-Mailer: git-send-email 2.24.1
X-Originating-IP: [194.105.145.90]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f5970205-fb10-4aad-7135-08d7bd3314cf
X-MS-TrafficTypeDiagnostic: VI1PR05MB5581:|VI1PR05MB5581:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR05MB5581944FE89A6C8DC6B606D5F9E90@VI1PR05MB5581.eurprd05.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3173;
X-Forefront-PRVS: 03283976A6
X-Forefront-Antispam-Report: SFV:SPM;SFS:(10019020)(4636009)(366004)(376002)(396003)(346002)(39840400004)(136003)(199004)(189003)(478600001)(2906002)(54906003)(86362001)(5660300002)(4326008)(36756003)(1076003)(316002)(6486002)(44832011)(8936002)(81166006)(81156014)(8676002)(66556008)(956004)(2616005)(15650500001)(6666004)(66476007)(4744005)(6496006)(52116002)(16526019)(186003)(26005)(66946007)(23200700001);DIR:OUT;SFP:1501;SCL:5;SRVR:VI1PR05MB5581;H:VI1PR05MB3279.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;CAT:OSPM;
Received-SPF: None (protection.outlook.com: toradex.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: PonE2eLV5muMcgyLZqXR0BfigvXrP94VQbYNml2ZKREIGc5ZZM7CtHTA2nbqLJxaZSz8EW2FeGEjALY7FFUbx8+9Qf18JCdEC5qPWiNVcNBOP5Br1T6MdcPs8dJbN9JMiGjlWJBgJaCvuEAeLBJg7l/7SUipFkLE9rMM9OOUADwWE58M+c5Osou9pgDwvaqXIwWpqWwgVLW/L34RRqmDuRMj97eUt7mgh2KnfmNsWbn2xetLINYz14NlYlpsenAiWUOcXUsLM9mawFExiJfPGPdNMFko4DbW0fIdHJswZhBrrPRtEy5UHm6Xnwmu1rsBTJq3xOLwLmdApc7WCxy0aqZzA0X6Om+vouniVFe1fKMV6WnYHFYXYbHhJhl3HNnRxMNIwj3Pbjv/xXCCet7CHi/Y4eLib0S5cHkHSoki/aJKxgwXGQfAYYXZN5kBCB0NGVR062XgtnbakrB5rwMUVKYPs0YZD0zZWl+dI8txT3E7yeGwYyB5PACGTd5Q89aBWZ3oWDl6zGCnWgqA9w9dIt8wtcfnOpkBXaJemOhU+2kFMHRCGpeIOwTAs/mHQVSQHZ6JAL6WXcqsgRKIAnOZlrsB7sJg4rIKHy0ajRKfScBiP/DSMZd+0Z1A2X9+PzdfP+DjNcg6kYzu18YGKaseba1daSZE9csgeJ+ItqBbJ5dBC2HmH3wW6DqMBydHK9FNXekbI2zLzmg/FhnoIaAIAFMFZzWmQxPMmAjE3zQhLj7gs0CXodyUB6tntmOvPDpqKBaS6tasbxLN6HkFepxpFw==
X-MS-Exchange-AntiSpam-MessageData: mM6CnhwY5KrMAmGrpfUrKGXks37vU7p50Z0KmKbYH1e1VUqLMYxTDO6+5prQ/rVV4g9faiWBvpMw+7L98UoyH/0kD8vU16ew8Bc9VYglK7p1edwYt8blk2GGd9OGxr0YOtgzBW7F7+5KUd1d7gTV7Q==
X-OriginatorOrg: toradex.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5970205-fb10-4aad-7135-08d7bd3314cf
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2020 16:18:58.7844
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d9995866-0d9b-4251-8315-093f062abab4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5RYYPfL2233vSHlXRa8baqZsGI8iOMqDMYUF3keOaS6eJFmm/condYtdK8WF/fl9ITTC8qqtiPdxJXfdLD/Nifeby0GPyafeEWwLlFLb6Q8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB5581
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The message of max device speed setting is shown when
an error in spi_setup() occurs.
Instead, it should be shown when the setup call succeeds.

Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
---

 drivers/spi/spidev.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index c97e853dbf5c..80dd1025b953 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -454,10 +454,11 @@ spidev_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 
 			spi->max_speed_hz = tmp;
 			retval = spi_setup(spi);
-			if (retval >= 0)
+			if (retval == 0) {
 				spidev->speed_hz = tmp;
-			else
-				dev_dbg(&spi->dev, "%d Hz (max)\n", tmp);
+				dev_dbg(&spi->dev, "%d Hz (max)\n",
+					spidev->speed_hz);
+			}
 			spi->max_speed_hz = save;
 		}
 		break;
-- 
2.24.1