Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp737239ybf; Sat, 29 Feb 2020 14:48:34 -0800 (PST) X-Google-Smtp-Source: APXvYqz462RA6/ZMkuEDI5oyJJuCY59Rkmh9e3w4KE+FoLk0UvZJ95bxyKKCRDXrXsqJbBZLruij X-Received: by 2002:a9d:d06:: with SMTP id 6mr8336065oti.176.1583016513865; Sat, 29 Feb 2020 14:48:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583016513; cv=none; d=google.com; s=arc-20160816; b=CDdmPnnqgXNYlHO2rOzZGaqcnIhvwhqhGilYGqlXbxKuLx0L4atLV32rz+mewbcRV1 MjsmSw6qnLSEPBv+RPciba69GjWn6/SS6hZl73vSjKRkPSv9lnHnuZXOaQfwJsWDA61D SHG3iKGtJkf8m3LzI9snZb4zCQrGzmMqdulvolW8AuULyDipulGYWCIzxGILwUI72l8z AJ8jHAAk9nqZYpqzaZDY0TnWehP4Jv0/NyuZwS9rdpYpAnLAxPxwjSQAb1TEUcpiseIw nnBz1e/NlKajD9RsGlwe83NNDPNX8kA6Yt4X50ikCDYnNpyzEIfNIKyJjDfvoq1Q2SYT rfIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=vMgdrB1ihQCYAIbfFMzkiv3JHJetoGVM7PTi0q5ALmo=; b=U/iwl4RwSr8g57BvkomArIoDoesHb+aS9tniFHGe1w6YCyvqOrX5cWzF/CSifGinCY 2OAWGQnFj6bXR85mK0Y6nj8FKOYv8CRlPYncfMvHcALgsFMuxs8M0udKgQ2TCHxzlgC6 zy+wvkbQMiZJOGuNk1AWlVaPjFL3EPTI3KKkqrdTKvnYO9L5w3RsaiuGzhZ6guSDLTSR BinHjNqTIXr6GnrJP/PzHW0Om/VDuoL1owQTKsZFIidSE08vNVo08VyJR6EOvjndFdSM d6owMaU8XOoJdxy6AD/eTzwOF3c/OA0C0QeSVgaq1zhmWwNTBFuyl0BFOL6tS9D7aHhY ZYkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=OsiUhUD4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c144si4149588oig.263.2020.02.29.14.48.03; Sat, 29 Feb 2020 14:48:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=OsiUhUD4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727303AbgB2Whn (ORCPT + 99 others); Sat, 29 Feb 2020 17:37:43 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:40379 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727244AbgB2Whn (ORCPT ); Sat, 29 Feb 2020 17:37:43 -0500 Received: by mail-oi1-f193.google.com with SMTP id j80so4641934oih.7 for ; Sat, 29 Feb 2020 14:37:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vMgdrB1ihQCYAIbfFMzkiv3JHJetoGVM7PTi0q5ALmo=; b=OsiUhUD4bT1O7upbHwDuinmveawahmkCK+8PabYGyG4OgCvzVO2Y9gPARZOt8Q/czD +gKk4PjNad9Cr3uGC/89VvuVJcnJzMxJ6ySwmoXkUgS4Qbmfer8kAdJCtymsZ4N4Kisj xhsW4Trq+pLWIg+nu+GHlVmCRXyn51E/QSA0Axc54CrRDbWXQQuvdO5+eE5LbwM4gEdp uF4zuIbpl+wi5BquzuZ+DBrW3+oz59DM54WqcTU+Q4EjA/hE6ZkxGgQBfjmJzKNErQrc d4M1+ejrtFxlmMb9QI6A2Bvzid6CQiM91vKcAXrSOKEwClT+jdHfQPTQ7XCWj2cSd8Cg EVvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vMgdrB1ihQCYAIbfFMzkiv3JHJetoGVM7PTi0q5ALmo=; b=QpRlHBnGOKdJwC2v45ss53UN/mbsZO/J0C6I1N/sMSsG2DoIp4UCXNeVZ/qSGC00WQ eQeTZoLJ4H9SFdMbO2ykZJm2Aq8lDMGbs0RhGZTMPqj0Vf88WjAukQ4hmnL1qMzFUO6/ 56vGfCWpCdpvsktl8ijoy/rbY7/GiYe7POl2zKWvQz01AswMDwDy+SRB5KAeAQOSPDov /TMDEINnrTyRhQh/3Er0rs4dcPoeXOdcpostzCct4VpBPWgvFPz7JviUK6YEPHuMPplZ W8c9n7jYDbJIwtHeCHtjjLiYeKv6yFJOlhnHB+//0Qymz1Wb9WYCCp9ca7YHiWyjpAJc NUKw== X-Gm-Message-State: APjAAAX/bVvZ7Lzn9RYcw3fwOHbHgmDTqVsfLFQKsSN5hVL2dQM7NieL Z56DGwveRepC36jIQ8F3gYw6m5eUNflBR12uDubtzg== X-Received: by 2002:a54:4098:: with SMTP id i24mr5511480oii.149.1583015862617; Sat, 29 Feb 2020 14:37:42 -0800 (PST) MIME-Version: 1.0 References: <20200221182503.28317-1-logang@deltatee.com> <20200221182503.28317-4-logang@deltatee.com> In-Reply-To: <20200221182503.28317-4-logang@deltatee.com> From: Dan Williams Date: Sat, 29 Feb 2020 14:37:31 -0800 Message-ID: Subject: Re: [PATCH v3 3/7] x86/mm: Thread pgprot_t through init_memory_mapping() To: Logan Gunthorpe Cc: Linux Kernel Mailing List , Linux ARM , linux-ia64@vger.kernel.org, linuxppc-dev , linux-s390 , Linux-sh , platform-driver-x86@vger.kernel.org, Linux MM , Michal Hocko , David Hildenbrand , Andrew Morton , Christoph Hellwig , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Eric Badger , "H. Peter Anvin" , X86 ML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 21, 2020 at 10:25 AM Logan Gunthorpe wrote: > > In prepartion to support a pgprot_t argument for arch_add_memory(). > > It's required to move the prototype of init_memory_mapping() seeing > the original location came before the definition of pgprot_t. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: "H. Peter Anvin" > Cc: x86@kernel.org > Cc: Dave Hansen > Cc: Andy Lutomirski > Cc: Peter Zijlstra > Signed-off-by: Logan Gunthorpe Looks good, checked for argument confusion, passes the nvdimm unit tests. Reviewed-by: Dan Williams