Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp751478ybf; Sat, 29 Feb 2020 15:13:27 -0800 (PST) X-Google-Smtp-Source: APXvYqxaSweGx7G8kGUxA6L3Wdh5VqqmYdCnQnPAEKHTWdmaz7DSpuTSjxqvkHiNPrNLCCzv5mBP X-Received: by 2002:a05:6830:1101:: with SMTP id w1mr8131689otq.202.1583018007423; Sat, 29 Feb 2020 15:13:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583018007; cv=none; d=google.com; s=arc-20160816; b=OFJsV5cQ8hUBEv5HoDhSbmchw8tWPFYDLCo0c/wdAnZODjovgWY29mMNtxVhCrw30h Chzx2mJS79UKHzeqtNkS1wvfqlRSPF67P3MEkkOwjdNgiBu9CiShI5CLM2tl8mqttj3b T3GEv7S0a/ZiHSt3LZ2FO2Yd75+jpxO4lZrYza2xf9+L992zTxn1cN3A7b+NEtCoBhOE 9q8jTa9oQmfd5Rw66ecRHU886Cu0rmJd9AbeGedANrngjpTf2VhPl2dGz1umlJWxwBnk bm5WHjAsHgQYJE6BzBI7gnkrxXt7vVZXrPOl+DdNdz9WioDMy68k91cBcVEkJxzI2Wwm lleg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:message-id :in-reply-to:subject:cc:to:from:date; bh=ysIdEtCZt7nh2UMTJ/gZuhVlZAqluo9a77RTCuZsu+M=; b=b7/xlkeH2Q0HrKfL+s86t/91l/nd7G3gzKOVv9IDpL4mJjrH/dDR6gvSmyTsNbmESD kRbCHGq1IMI6Vu3S57J8QEPMC7nf7uEvi4mfwLVur8A8ek2nZlVjQegImF010Fb0fYDC FA0RYBkVFuGE6Zf3R209POJcPeYXKNVNJ0lZJ9tCqaqljZ0yYU+OX/A6v8NiTCBvw72c 9e5lQtW1CFqozaMTGUtg7Zg0l9eYxQ2zAmbgDdueckNwkmoT9QxEEg1mjq2ruqzlFQDe eMWl6YT+JLTB4arkYY+lwMePABIQZB1u0DcYzhwMJcGoXzO792QLC6O1gvnHG4uoTfwQ EJBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r22si3715564otn.192.2020.02.29.15.13.15; Sat, 29 Feb 2020 15:13:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727635AbgB2XME (ORCPT + 99 others); Sat, 29 Feb 2020 18:12:04 -0500 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:50622 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727563AbgB2XMD (ORCPT ); Sat, 29 Feb 2020 18:12:03 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by kvm5.telegraphics.com.au (Postfix) with ESMTP id 2A1B729C9F; Sat, 29 Feb 2020 18:11:59 -0500 (EST) Date: Sun, 1 Mar 2020 10:11:51 +1100 (AEDT) From: Finn Thain To: afzal mohammed cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, Greg Ungerer , Thomas Gleixner , Geert Uytterhoeven Subject: Re: [PATCH v2 06/18] m68k: Replace setup_irq() by request_irq() In-Reply-To: <20200229131553.GA4985@afzalpc> Message-ID: References: <00b0bf964278dd0bb3e093283994399ff796cca5.1582471508.git.afzal.mohd.ma@gmail.com> <20200229131553.GA4985@afzalpc> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 29 Feb 2020, afzal mohammed wrote: > [...] > Specific to m68k, following changes has been made based on m68 family > ;) feedback, > None of my comments were specific to any architecture. Also, I am not the maintainer for the affected m68k code. Greg is. > 3. s/pr_err/pr_debug > Please just ignore my opinion on that, since it contradicts the maintainer's guidance/preference.