Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp773030ybf; Sat, 29 Feb 2020 15:52:08 -0800 (PST) X-Google-Smtp-Source: APXvYqzMLh0jU5t+UrGtMQOCdH6Q7n8AGRPtdqcZtIOQ4K29kIxhQhtx77AkSlcVXBhYm+FCkALi X-Received: by 2002:aca:44d7:: with SMTP id r206mr7533370oia.33.1583020328756; Sat, 29 Feb 2020 15:52:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583020328; cv=none; d=google.com; s=arc-20160816; b=CDWx70CJVP93Cb/nJvwXNZm0ZAzBlUlIUs7b6S3MrQjxUHz3+jhRw8taDZtNWUsQVX lNhTFaPxomPTMm9UfkfQu64PsOIfKsTkZy5XyMU0hfb18Zrak/oYTaoKLVvjo5Lyg8Dz aKyb9BX3H/9ZQzj56/legMgGaZSI8cxjAQc7/jZdJZBduc9czoATYSDtpPs6keRAaybn QHkqeAusndQQMZwbYptwVEMLk+jBXjK7VplpglbzdMqj+edO0kJ2G3rCf9drG47iBKVK gwtdnZVAK75JFUyEF7CKj8VEBnTZxOwSaIghQx1MR01+lfooCm1+n3eJYul8YTEtCZ1q +bDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=JCx5kM2FMe+phgvKiMpcu0iiorhySMfHXJQpD4PHwa8=; b=WY7mhoM2mxfkRst9daos6rQawgUxo9hzsoXZKx+cOnMfZnCQ5j8/Gn/QNdK5/gyATv G8ktO6Ft+APIPqWRnOen64ktZ71RXAE06293b1ZIEk5ShjJY5LgyH8Qw+XsALeBdOv49 1Wl/g/8jQ1NBfF/klhKBdM8Q+ELvxdqF/ruDnMF6ms6ctDonhjLhvqA+Gd5FLxocKS7P ENKaxvS9kXTcRrB+R1CrOYdLAugTWSVy7WJrgghiYFvL042A7xO/wBP9u8/sxtuWfHv+ C3wWG9/VbYQqdKB+0otDI331VmHWZREPRuuOHY67bLqUUFgLJRF+fIOWgL5oyOME5rVc U3HQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="P/Nsf2a2"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o7si3950941otk.185.2020.02.29.15.51.56; Sat, 29 Feb 2020 15:52:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="P/Nsf2a2"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727254AbgB2Xvs (ORCPT + 99 others); Sat, 29 Feb 2020 18:51:48 -0500 Received: from mail-pj1-f66.google.com ([209.85.216.66]:55250 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726786AbgB2Xvs (ORCPT ); Sat, 29 Feb 2020 18:51:48 -0500 Received: by mail-pj1-f66.google.com with SMTP id dw13so2819977pjb.4 for ; Sat, 29 Feb 2020 15:51:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :in-reply-to; bh=JCx5kM2FMe+phgvKiMpcu0iiorhySMfHXJQpD4PHwa8=; b=P/Nsf2a2wOYy7D1u146YWjS1s0ujxd2TAgYMb/LLAdf9b3eCgjLNdXrDZV2mViHn+a WmdqTo54POm0wJbKOda2WLgKO23AX8ZVC56n86ceOp/d7nQqrv40YovrJ9GeywHUeIDu muZunWBfnMGLQSnTUszHU82kX6t5xpQt2TdhQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:in-reply-to; bh=JCx5kM2FMe+phgvKiMpcu0iiorhySMfHXJQpD4PHwa8=; b=L7YrawCw1Q+r9ub9fEVqTgJWOy5KngFxwvP4vpO+RUzXmC6w5Ps0vgTeZDGHb3PVuA fgz/8VjRPKj0DQDJR1jrppW+kNzrEumfVP+k4TuXq3ZQO95/0Fys+LakbSPNpVndQY5X qIFXP889PKZYmx6MYV1IHGkQFPaVgz5g14BvjvoZjrJAb/UtY4sycon0o6myjIZ9yWsk Gk1DmRHbHdefDx3nTQ0Y0fmVOezsGZbjPmICja109S0krGIgPsv4pp96+wpFzjx9jKIO KAZcTv6ZJOP6jYDnZ+6MKTc+sxebCDItUqq04sEA97TA6tEC9QVEXE3wOU4Xrn9XGsSC yg9A== X-Gm-Message-State: APjAAAUv9cxHyI8cFtC9jsOcrTn54I/oR2ccuE0kTIlltTKcz213M5tI C9cJ6rPtil/Q+4Uf+an4Nf7T016IYZ4= X-Received: by 2002:a17:90b:11d0:: with SMTP id gv16mr12761318pjb.109.1583020307505; Sat, 29 Feb 2020 15:51:47 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id w17sm10706874pfg.33.2020.02.29.15.51.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Feb 2020 15:51:46 -0800 (PST) Date: Sat, 29 Feb 2020 15:51:45 -0800 From: Kees Cook To: Arvind Sankar Cc: dave.hansen@linux.intel.com, kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org, luto@kernel.org, me@tobin.cc, peterz@infradead.org, tycho@tycho.ws, x86@kernel.org Subject: Re: [PATCH] x86/mm/init_32: Don't print out kernel memory layout if KASLR Message-ID: <202002291534.ED372CC@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200226215039.2842351-1-nivedita@alum.mit.edu> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arvind Sankar said: > For security, only show the virtual kernel memory layout if KASLR is > disabled. These have been entirely removed on other architectures, so let's just do the same for ia32 and remove it unconditionally. 071929dbdd86 ("arm64: Stop printing the virtual memory layout") 1c31d4e96b8c ("ARM: 8820/1: mm: Stop printing the virtual memory layout") 31833332f798 ("m68k/mm: Stop printing the virtual memory layout") fd8d0ca25631 ("parisc: Hide virtual kernel memory layout") adb1fe9ae2ee ("mm/page_alloc: Remove kernel address exposure in free_reserved_area()") -Kees -- Kees Cook