Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp787040ybf; Sat, 29 Feb 2020 16:12:42 -0800 (PST) X-Google-Smtp-Source: APXvYqxoOxkbYtwWUJQL7TBH2slftPzF28hqGJKcAfZT8im51VoY4MIzCnz8S4i9Vi3zyl+nghTf X-Received: by 2002:a9d:443:: with SMTP id 61mr7593167otc.357.1583021562529; Sat, 29 Feb 2020 16:12:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583021562; cv=none; d=google.com; s=arc-20160816; b=pVJynhRx1WbHez6JTmIGeT9x2k7DMBUAQh1ZXDSDlzsOrGIwsRlXJT89+T7ntBOxaK PBkbbqnFoI0BUTtDDqpBnyq4l11jUOAcPKDConFM6YdG0fjp/0l87/qgVOoLNOCBn+lZ dXJvjIKf1CrFMgdl7G13k4FO4HIx0qylnqfyEnRpVhFEdGeLs7+v1d1yBg1CZSnlODmD 9Zyp02gXx0g89ejv/nM13DT3nDiq4soKvzKxF3FHfYvi7eiolHHhb8a1yzRTK5xK3yrk a4lrKTzvm0R8uNhbWk+e9suDHwN81WI8gHuQW0jDRY7mY8qlLUerMHkd+rBgcxMAvIpB YG9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=0tTQpY19p3YOQ7sgf8HTMtSFinGBxI5aHxd4kFj3uKU=; b=uo4tUncAeJqscYTZhCG4OwzIgTT9hOJ0R/Z3bTsZcx8NqpbrFG7v+2fF1asYmfldKy YvcEkIniKG/m4mFZuaa4QPjMRGcH7MERH+HT5lEpLIHfyanN8hrR5xxjh2AbaVcD66Hl F50bnUvfD+KmHCtJm0ebVB5Dw3cDY2BOmRpdjOkrOmJWrj6wTLaGFIYyiaevCfJ6tMY5 eGtdC0wtnaMoaGFqtWJPtlovZm2rs9LoElapYpnpjpnBe89KXmnb71NGEZ9bbkmGnmd5 PRVGf9a1jNePX3i4xXz9q9frlFOCVmC5K9/RRN1+MvEDNr1NiHVHvp0BPmL6QRNerv5Q EU7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=ThQ4pTJO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a8si3510137otp.258.2020.02.29.16.12.30; Sat, 29 Feb 2020 16:12:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=ThQ4pTJO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727267AbgCAALu (ORCPT + 99 others); Sat, 29 Feb 2020 19:11:50 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:47254 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726786AbgCAALu (ORCPT ); Sat, 29 Feb 2020 19:11:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0tTQpY19p3YOQ7sgf8HTMtSFinGBxI5aHxd4kFj3uKU=; b=ThQ4pTJObQ4Ta4mG22/o18PGw2 GKkN+UNRUR7Qcui9VQxaPmCxOEKwyGpmkqNeG2tvntwnOxG6wn4AADOrMBvgkPaIxRoJ/t34fGB/z HeyH2yl7mK1f4xcLlABRcNN3bmmiDN2qpWt5nPM42xLjeFWis/Mc1TrvrbO+fanNqxke2gaTfDeFW W6YmYw0aWBIFq82Dm53ocwRie//MnwqNav6E/76urUZA+WJGWujjke+R1ZXtXdkLTMGr//R0i67FN IpPVy4363QKd8/xGZnKKMFqdZ6uhjL+IVev8jKrb9ujiHsNd1uHws/SFD2WmxJrgDjPibPvLYC2qS U9HDFBPA==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j8CCy-0008Az-TO; Sun, 01 Mar 2020 00:11:48 +0000 Date: Sat, 29 Feb 2020 16:11:48 -0800 From: Matthew Wilcox To: mateusznosek0@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH] mm/vmscan.c: Clean code by removing unnecessary assignment Message-ID: <20200301001148.GM29971@bombadil.infradead.org> References: <20200229214022.11853-1-mateusznosek0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200229214022.11853-1-mateusznosek0@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 29, 2020 at 10:40:22PM +0100, mateusznosek0@gmail.com wrote: > From: Mateusz Nosek > > Previously 0 was assigned to variable 'lruvec_size', > but the variable was never read later. > So the assignment can be removed. > > Signed-off-by: Mateusz Nosek It _was_ used, until commit f87bccde6a7dd1bdb219a4045e8ac111590c9314 which removed lru_pages. So this is just a left-over, and I agree it's now superfluous. Reviewed-by: Matthew Wilcox (Oracle)